Re: [devel] [PATCH 1/1] imm: inform status to NID before exit during start-up phrase [#2845]

Thanks Hans, I modified code a bit to test this change, and found that immnd was respawned successfully as we expected. Here are the syslogs: May 10 10:20:09 PL-3 local0.notice osafimmnd[436]: NO SERVER STATE: IMM_SERVER_LOADING_PENDING --> IMM_SERVER_SYNC_PENDING May 10 10:20:09 PL-3

[devel] [PATCH 1/1] ntf: remove sending SIGTERM and SIGABRT when killing osafntfimcnd [#2851]

The handler of SIGTERM is just _Exit, so using SIGTERM/SIGABRT is not needed. The patch changes to send SIGKILL when terminating osafntfimcnd process. --- src/ntf/ntfd/ntfs_imcnutil.c| 100 src/ntf/ntfimcnd/ntfimcn_main.c | 18 2 files

[devel] [PATCH 0/1] Review Request for ntf: remove sending SIGTERM and SIGABRT when killing osafntfimcnd V2 [#2851]

Summary: ntf: remove sending SIGTERM and SIGABRT when killing osafntfimcnd [#2851] Review request for Ticket(s): 2851 Peer Reviewer(s): Lennart, Vu Pull request to: Vu Affected branch(es): develop, release Development branch: ticket-2851 Base revision: fdb037f450570582df20d603193cffe1eff8b107

Re: [devel] [PATCH 1/1] ntf: remove sending SIGTERM and SIGABRT when killing osafntfimcnd [#2851]

Hi Canh, You have removed the code that makes ntf wait for ntfimcn to terminate before returning from CSI set callback when doing a switch over. This will probably work but I don't think it is a good idea. The only change needed is to remove kill_imcnproc(SIGTERM) and kill_imcnproc(SIGABRT)

Re: [devel] [PATCH 1/1] ntf: remove sending SIGTERM and SIGABRT when killing osafntfimcnd [#2851]

Hi aVu, "[Vu] Use "else {" instead (without if) in order to cover all error cases?" Look like function "KillProc()", I think we don't need handle printout in the case with the error "ESRCH" (The process or process group specified in pid cannot be found) ? Regards Canh -Original

Re: [devel] [PATCH 1/1] ntf: remove sending SIGTERM and SIGABRT when killing osafntfimcnd [#2851]

Hi Canh, Ack with a minor comment, started with [Vu]. Regards, Vu > -Original Message- > From: Canh Van Truong > Sent: Wednesday, May 9, 2018 3:30 PM > To: lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au; > minh.c...@dektech.com.au > Cc:

Re: [devel] [PATCH 1/1] imm: inform status to NID before exit during start-up phrase [#2845]

Hi Vu, I'll revise my comment a bit, before sending nid_notify, the fifo monitoring is not started. So removing the exit should not be necessary, good if you can test this. /Thanks HansN -Original Message- From: Hans Nordebäck Sent: den 8 maj 2018 15:06 To: 'Vu Minh Nguyen'

[devel] [PATCH 1/1] ntf: remove sending SIGTERM and SIGABRT when killing osafntfimcnd [#2851]

The handler of SIGTERM is just _Exit, so using SIGTERM/SIGABRT is not needed. The patch changes to send SIGKILL when terminating osafntfimcnd process. --- src/ntf/ntfd/ntfs_imcnutil.c| 136 +++- src/ntf/ntfimcnd/ntfimcn_main.c | 18 -- 2 files

[devel] [PATCH 0/1] Review Request for ntf: remove sending SIGTERM and SIGABRT when killing osafntfimcnd [#2851]

Summary: ntf: remove sending SIGTERM and SIGABRT when killing osafntfimcnd [#2851] Review request for Ticket(s): 2851 Peer Reviewer(s): Lennart, Minh, Vu Pull request to: Minh Affected branch(es): develop, release Development branch: ticket-2851 Base revision:

Re: [devel] [PATCH 1/1] plm: don't instantiate child EEs twice when unlocking parent EE [#2846]

Hi Alex, Ack for the patch, code review only Regards, Ravi -Original Message- From: Alex Jones [mailto:ajo...@rbbn.com] Sent: Thursday, May 03, 2018 9:08 PM To: mathi.np@gmail.com; Ravi Sekhar Reddy Konda Cc: opensaf-devel@lists.sourceforge.net; Alex

Re: [devel] [PATCH 1/1] imm: fix PBE terminated when adding data with duplicated values [#2422]

Hi Danh, Ack from me. Thanks, Vu. > -Original Message- > From: Danh Vo > Sent: Tuesday, May 8, 2018 4:35 PM > To: ravisekhar.ko...@oracle.com; hans.nordeb...@ericsson.com; > zoran.milinko...@ericsson.com; anders.wid...@ericsson.com; >