Currently changing attribute saAmfCtDefDisableRestart of SaAmfCompType
object not affect to all components at runtime. Because the change
does not broadcast to all nodes.
Broadcast the change once it is updated.
Similar fix for attribute saAmfCtDefInstantiationLevel.
---
Summary: amf: correct changing attribute saAmfCtDefDisableRestart [#2876]
Review request for Ticket(s): 2876
Peer Reviewer(s): Gary, Minh
Pull request to: Gary, Minh
Affected branch(es): develop
Development branch: ticket-2876
Base revision: 9df337b030ff51c05e5d9d95eca15efeb8641a0a
Personal
Hi Anders,
Please see my comments in line.
Thanks,
Minh
On 21/06/18 19:30, Anders Widell wrote:
Good work! Ack with comments inline, marked AndersW> below.
Some additional comments (you don't have to address all the comments in
this ticket but they could be considered for future
Currently, if an upgrade DELETE or MODIFY CCB contains empty-value
attributes, SMF will create rollback data for those attributes with
the hard-coded "<_empty_>" string value. However, this hard-coded
string will actually make the later rollback fail, especially for
numeric-type attributes, when
Summary: smf: Fix failed rollback of DELETE/MODIFY CCB with originally empty
attributes [#2877]
Review request for Ticket(s): 2877
Peer Reviewer(s): Lennart Lund
Pull request to: Lennart Lund
Affected branch(es): develop
Development branch: ticket-2877
Base revision:
Good work! Ack with comments inline, marked AndersW> below.
Some additional comments (you don't have to address all the comments in
this ticket but they could be considered for future improvements):
* Trace files seem to be dumped also when threads exit normally? Is it
dumped from some
Hi Gary,
I got you point. But actually remain attributes use the same behavior.
I updated the fix and re-sent .
B.R
/Thang-CMW Maint
-Original Message-
From: Minh Hon Chau
Sent: Wednesday, June 20, 2018 4:15 PM
To: Gary Lee ; thang.nguyen
Cc: opensaf-devel@lists.sourceforge.net
Summary: amf: correct changing attribute saAmfCtDefDisableRestart [#2876]
Review request for Ticket(s): 2876
Peer Reviewer(s): Gary, Minh
Pull request to: Gary, Minh
Affected branch(es): develop
Development branch: ticket-2876
Base revision: 9df337b030ff51c05e5d9d95eca15efeb8641a0a
Personal
Currently changing attribute saAmfCtDefDisableRestart of SaAmfCompType
object not affect to all components at runtime. Because the change
does not broadcast to all nodes.
Broadcast the change once it is updated.
Similar fix for attribute saAmfCtDefInstantiationLevel.
---
