Thanks Hans, I'll rewrite that part.
-Original Message-
From: Hans Nordeback
Date: Thursday, 20 September 2018 at 10:18 pm
To: gary
Cc:
Subject: Re: [PATCH 2/3] base: add config file reader [#2923]
Hi Gary,
I think we need to replace the use of std::regex for now.
According to https://isocpp.org/blog/2014/04/gcc-4.9.0
It's been released for over 4 years.
-Original Message-
From: gary
Date: Thursday, 20 September 2018 at 10:11 pm
To: Hans Nordeback
Cc:
Subject: Re: [devel] [PATCH 2/3] base: add config file reader [#2923]
Hi Hans
Hi Hans
Just tested it with 4.9.3 and it works fine.
It doesn't link with 4.8.5
config_file_reader.cc:(.text+0x1c8): undefined reference to
`std::regex_token_iterator<__gnu_cxx::__normal_iterator, char, std::regex_traits
>::regex_token_iterator(__gnu_cxx::__normal_iterator,
Ack (review only)
-Original Message-
From: "thuan.tran"
Date: Monday, 17 September 2018 at 9:39 pm
To: , gary
Cc: , "thuan.tran"
Subject: [PATCH 1/1] smf: improve CcbApplyCallback() to avoid NULL access
[#2927]
Current CcbApplyCallback() is not safe, may access NULL pointer
ack, review only. Minor comments below. /Thanks HansN
On 09/19/2018 05:42 AM, Gary Lee wrote:
Only FMS_PROMOTE_ACTIVE_TIMER, FMS_NODE_ISOLATION_TIMEOUT and
FMS_ACTIVATION_SUPERVISION_TIMER are currently supported.
These values can be changed in fmd.conf and take effect
by sending SIGHUP to
ack, review only. Some comments below. /Thanks HansN
On 09/19/2018 05:42 AM, Gary Lee wrote:
Some configuration attribute are read by OpenSAF daemons as
environment variables. eg.
export FMS_PROMOTE_ACTIVE_TIMER=0
There is no easy way to reload these values without a restart.
ack, review only/Thanks HansN
On 09/19/2018 05:42 AM, Gary Lee wrote:
We need to use SIGHUP for reload of configuration
---
src/base/daemon.c| 5 +++--
src/base/logtrace.cc | 22 --
2 files changed, 3 insertions(+), 24 deletions(-)
diff --git a/src/base/daemon.c
