Summary: plm: fix build to determine location and name of systemd library
[#2931]
Review request for Ticket(s): 2931
Peer Reviewer(s): Mathi, Hans, Ravi
Pull request to:
Affected branch(es): develop
Development branch: ticket-2931
Base revision: 63a69b464a9173f6ccabdab9c12978b9372283cf
Personal
plmcd does not build on Fedora 27. This may occur on other distros, too.
CCLD bin/plmcd
CXXLD lib/libosaf_common.la
CXXLD lib/libimmpbe_dump.la
/usr/bin/ld: cannot find -lsystemd-daemon
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:11016: bin/plmcd] Error 1
The systemd library
ack, code review only/Thanks HansN
On 09/19/2018 12:50 AM, Minh Chau wrote:
---
src/amf/amfd/sg_nwayact_fsm.cc | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/amf/amfd/sg_nwayact_fsm.cc b/src/amf/amfd/sg_nwayact_fsm.cc
index f339026..bbd63c8 100644
---
ack, code review only/Thanks HansN
On 09/19/2018 12:50 AM, Minh Chau wrote:
After split-brain, the assignments can go over the preferred number.
Reboot the node once at time until the current active assignments
is equal to preferred number.
---
src/amf/amfd/sg_nwayact_fsm.cc | 20
ack, code review only.
/Thanks HansN
On 09/21/2018 08:55 AM, Gary Lee wrote:
Some configuration attribute are read by OpenSAF daemons as
environment variables. eg.
export FMS_PROMOTE_ACTIVE_TIMER=0
There is no easy way to reload these values without a restart.
ConfigFileReader will parse
Perhaps this part can moved into to a separate function.
Ack,
Mathi.
On Tue, Sep 18, 2018 at 4:43 PM Jones, Alex wrote:
> Application can receive START step after responding to VALIDATE step after
> EE has uninstantiated.
>
> Ongoing admin operations are not cleaned up after EE uninstantiates.
ack, code review only.
/Thanks HansN
On 09/21/2018 08:55 AM, Gary Lee wrote:
Only FMS_PROMOTE_ACTIVE_TIMER, FMS_NODE_ISOLATION_TIMEOUT and
FMS_ACTIVATION_SUPERVISION_TIMER are currently supported.
These values can be changed in fmd.conf and take effect
by sending SIGHUP to fmd.
---
ack, code review only.
/Thanks HansN
On 09/21/2018 08:55 AM, Gary Lee wrote:
We need to use SIGHUP for reload of configuration
---
src/base/daemon.c| 5 +++--
src/base/logtrace.cc | 22 --
2 files changed, 3 insertions(+), 24 deletions(-)
diff --git
