Hi Minh,
I had noticed that point while review. But, if both SCs have gone down,
then expected is both should join.
If only one SC starts, then yes timeout will happen. Do you see any major
implications than assignments delay, which I think should be fine because, the
expected delay is
Hi Alex,
Sorry for the confusion.Yes 1/2 is pushed.Please review 2/2.
I will be publishing the other patches related to apitest under the same ticket.
Thanks,
Meenakshi
High Availability Solutions Pvt. Ltd.
www.hasolutions.in
- Original Message - Subject: Re: [PATCH 0/2]
Hi Gary,
ack (code review only)
Thanks
Minh
On 23/10/18 5:45 pm, Gary Lee wrote:
Keep the SC with the earlier boot time alive, if split brain is
detected. In the unlikely event that the boot up time
is equal, the node with the lower ID survives.
---
src/rde/rded/rde_cb.h| 2 ++
Hi Nagu
Thanks for the quick review.
1. Good point; I will set defaults at startup, in case the attributes
are blank or the attribute definitions not present.
2. Yes. We need details about the node, in case it does come back.
3. They are called at these places:
node_state.cc:
Hi Gary, Nagu
One notice you may know from the patch.
If we have two SCs cluster, go headless, only start SC1, now the
headless sync will be always timeout to wait for SC2 up.
Thanks
Minh
On 29/10/18 7:19 pm, Nagendra Kumar wrote:
Hi Gary,
Great simplification!. Ack.
Thanks
Hi Meenakshi,
I'm confused. We pushed this ticket back at the beginning of
October. Are these new tests?
Alex
On 10/29/2018 07:50 AM, Meenakshi TK wrote:
__
NOTICE: This email was received from an
Hi Gary,
Again, great patch!
Ack with the following:
1. I hope you might have tested upgrade and downgrade test cases, where Act
will not have these configuration params in xml, but Standby will try to
read as it has the latest code.
2. When f/o timer expires and Amf does failover and mark
Ack(Code Review Only).
Thanks
-Nagu
-Original Message-
From: Gary Lee [mailto:gary@dektech.com.au]
Sent: 24 October 2018 17:57
To: hans.nordeb...@ericsson.com; minh.c...@dektech.com.au;
nagen...@hasolutions.in
Cc: opensaf-devel@lists.sourceforge.net; Gary Lee
Subject: [PATCH 3/4]
Ack(Code Review Only).
Thanks
-Nagu
-Original Message-
From: Gary Lee [mailto:gary@dektech.com.au]
Sent: 24 October 2018 17:57
To: hans.nordeb...@ericsson.com; minh.c...@dektech.com.au;
nagen...@hasolutions.in
Cc: opensaf-devel@lists.sourceforge.net; Gary Lee
Subject: [PATCH 1/4]
Ack(Code Review Only).
Thanks
-Nagu
-Original Message-
From: Gary Lee [mailto:gary@dektech.com.au]
Sent: 24 October 2018 17:57
To: hans.nordeb...@ericsson.com; minh.c...@dektech.com.au;
nagen...@hasolutions.in
Cc: opensaf-devel@lists.sourceforge.net; Gary Lee
Subject: [PATCH 2/4]
---
src/plm/apitest/test_saPlmInitialize.c | 57 ++
1 file changed, 57 insertions(+)
diff --git a/src/plm/apitest/test_saPlmInitialize.c
b/src/plm/apitest/test_saPlmInitialize.c
index 777d913..f9826e4 100644
--- a/src/plm/apitest/test_saPlmInitialize.c
+++
---
src/plm/apitest/test_saPlmInitialize.c | 6 ++
src/plm/apitest/test_saPlmSelectionObjectGet.c | 21 +
2 files changed, 27 insertions(+)
diff --git a/src/plm/apitest/test_saPlmInitialize.c
b/src/plm/apitest/test_saPlmInitialize.c
index f9826e4..825aea0 100644
Summary: plm: Add missing test cases of saPlmSelectionObjectGet() in plm
apitest [#2938]
Review request for Ticket(s): 2938
Peer Reviewer(s): Alex, Mathi
Pull request to: Alex, Mathi
Affected branch(es): develop
Development branch: ticket-2938
Base revision:
The coredump is generated in the context of processing the message type
"IMMND_EVT_D2ND_IMPLDELETE" because the memory is corrupted at the time
of decoding that message.
It allocated 'size' bytes of memory with the boundary in range [0 - 'size - 1'],
but modified - added null terminated, the
Summary: imm: fix osafimmnd coredump genereted during sanity test [#2947]
Review request for Ticket(s): 2947
Peer Reviewer(s): Lennart, Hans, Gary
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-2947
Base revision:
Hi Gary,
You are welcome!
Yes, I had figured out when I had gone through the patch. :-)
Thanks
-Nagu
-Original Message-
From: Gary Lee [mailto:gary@dektech.com.au]
Sent: 29 October 2018 14:11
To: Nagendra Kumar
Cc: minh.c...@dektech.com.au; hans.nordeb...@ericsson.com;
Hi Nagu
Thanks for the quick review!
‘Also modify avd_count_node_up() not to count standby SC’ - I guess you figured
out the NOT shouldn’t be there :)
Thanks
> On 29 Oct 2018, at 7:19 pm, Nagendra Kumar wrote:
>
> Also modify avd_count_node_up() not to count standby SC
Hi Gary,
Great simplification!. Ack.
Thanks
-Nagu
-Original Message-
From: Gary Lee [mailto:gary@dektech.com.au]
Sent: 29 October 2018 12:36
To: minh.c...@dektech.com.au; hans.nordeb...@ericsson.com; Nagendra Kumar
Cc: opensaf-devel@lists.sourceforge.net; Gary Lee
Subject:
If all nodes are synced after headless, the timer is stopped
but node_sync_window_closed is never set to true.
Later on, if a node becomes split from the main network and
rejoins, it will send a headless sync to amfd.
amfd will go into a never ending loop of processing the message,
putting back
Summary: amfd: ensure node_sync_window_closed is set [#2946]
Review request for Ticket(s): 2946
Peer Reviewer(s): Minh, Hans, Nagu
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-2946
Base revision:
20 matches
Mail list logo
