[devel] [PATCH 0/1] Review Request for amf: check node before handling node failover [#2971] V2

2018-11-23 Thread thuan.tran
Summary: amf: check node before handling node failover [#2971] Review request for Ticket(s): 2971 Peer Reviewer(s): Gary, Minh Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2971 Base revision:

[devel] [PATCH 1/1] amf: check node before handling node failover [#2971]

2018-11-23 Thread thuan.tran
- Standby amfd may miss node delete apply callback by somehow. Then it will crash when handling event in failover state due to: Assertion 'avnd->list_of_ncs_su.empty() != true' failed in function avd_node_down_mw_susi_failover(). --- src/amf/amfd/ndproc.cc | 6 ++ src/amf/amfd/node.cc | 18

Re: [devel] [PATCH 1/1] amf: should not run check_nodes_after_reinit_imm() out of main [#2972]

2018-11-23 Thread Gary Lee
ack Thanks On 23/11/18 10:00 pm, thuan.tran wrote: --- src/amf/amfd/imm.cc | 4 src/amf/amfd/main.cc | 2 ++ 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/amf/amfd/imm.cc b/src/amf/amfd/imm.cc index e990288..82d2b13 100644 --- a/src/amf/amfd/imm.cc +++

[devel] [PATCH 0/1] Review Request for amf: should not run check_nodes_after_reinit_imm() out of main [#2972]

2018-11-23 Thread thuan.tran
Summary: amf: should not run check_nodes_after_reinit_imm() out of main [#2972] Review request for Ticket(s): 2972 Peer Reviewer(s): Gary, Minh Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2972 Base revision:

[devel] [PATCH 1/1] amf: should not run check_nodes_after_reinit_imm() out of main [#2972]

2018-11-23 Thread thuan.tran
--- src/amf/amfd/imm.cc | 4 src/amf/amfd/main.cc | 2 ++ 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/amf/amfd/imm.cc b/src/amf/amfd/imm.cc index e990288..82d2b13 100644 --- a/src/amf/amfd/imm.cc +++ b/src/amf/amfd/imm.cc @@ -41,7 +41,6 @@ #include

Re: [devel] [PATCH 1/1] log: add new test cases in log apitest v3 [#2915]

2018-11-23 Thread Lennart Lund
Hi Mohan, Ack Thanks Lennart -Original Message- From: Mohan Kanakam Sent: den 21 november 2018 11:12 To: Lennart Lund ; Vu Minh Nguyen Cc: opensaf-devel@lists.sourceforge.net; Mohan Kanakam Subject: [PATCH 1/1] log: add new test cases in log apitest v3 [#2915] ---