Re: [devel] [PATCH 1/1] amfd: Fix misordered and dropped item in job queue [#2981]

Hi Minh ack with minor comments: - it seems like we have the wrong data structure here, maybe fix in an enhancement. - try to simplify the else statement, eg a single place that calls dequeue/queue? On 10/12/18 4:44 pm, Minh Chau wrote: --- src/amf/amfd/imm.cc | 54

Re: [devel] [PATCH 1/1] amfd: Only start clm track for 2N Opensaf SU in failover [#2980]

Hi Minh, ack, review only/Thanks HansN On 12/10/18 07:00, Minh Chau wrote: > --- > src/amf/amfd/sg_2n_fsm.cc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/amf/amfd/sg_2n_fsm.cc b/src/amf/amfd/sg_2n_fsm.cc > index a218786..91ffc63 100644 > ---

Re: [devel] [PATCH 1/1] amfd: Update the assignment counters after restore absent assignment from imm [#2977]

Hi Minh, ack, code review only/Thanks HansN On 12/3/18 04:29, Minh Chau wrote: > AMF performs headless recovery by syncing the assignments from AMFND(s) and > re-create them in AMFD's db and IMM. Next step, AMFD compares the assignment > objects from IMM and from AMFND(s) to figure out the

Re: [devel] [PATCH 1/1] imm: add new test cases in imm apitest v2 [#2951]

Ack. Thanks, Vu > -Original Message- > From: Mohan Kanakam > Sent: Friday, November 30, 2018 1:04 PM > To: vu.m.ngu...@dektech.com.au; hans.nordeb...@ericsson.com > Cc: opensaf-devel@lists.sourceforge.net; Mohan Kanakam > > Subject: [PATCH 1/1] imm: add new test cases in imm apitest