Re: [devel] [PATCH 1/1] imm: allow empty-value attribute with default-tag persisted [#2985]

Hi, Any comment from you? I will push this ticket B/next week if no comment. Regards, Vu > -Original Message- > From: Vu Minh Nguyen > Sent: Wednesday, December 19, 2018 6:11 PM > To: hans.nordeb...@ericsson.com; lennart.l...@ericsson.com; > gary@dektech.com.au > Cc:

Re: [devel] [PATCH 1/2] ntf: Limit the logger buffer [#2961]

Hi Canh, ack with comments, please see with [M] Thanks Minh On 9/1/19 8:22 pm, Canh Van Truong wrote: When writing the notificaion fail with TRY_AGAIN in callback, the notificaion is pushed again to the list. If this happens for long time, the list is going to be very big. This cause NTFD

[devel] FW: [PATCH 1/2] ntf: Limit the logger buffer [#2961]

Thanks Lennart for quick review is_buffer_full is needed because we need to check if the buffer is full or not before we log all notification in the buffer and empty the buffer. Then we check if the buffer was full as before, the new notification shouldn’t be logged Regards Canh

Re: [devel] [PATCH 2/2] ntf: Update TRY_AGAIN error in ntfsend tool [#2961]

Hi Canh, Ack, see minor comment below [Lennart] Thanks Lennart Från: Canh Van Truong Skickat: den 9 januari 2019 10:22 Till: Lennart Lund; Minh Hon Chau Kopia: opensaf-devel@lists.sourceforge.net; Canh Van Truong Ämne: [PATCH 2/2] ntf: Update TRY_AGAIN

Re: [devel] [PATCH 1/2] ntf: Limit the logger buffer [#2961]

Hi Canh Ack for "ntf: Limit the logger buffer" commit with some comments. See [Lennart] below Thanks Lennart Från: Canh Van Truong Skickat: den 9 januari 2019 10:22 Till: Lennart Lund; Minh Hon Chau Kopia: opensaf-devel@lists.sourceforge.net; Canh Van

[devel] [PATCH 2/2] ntf: Update TRY_AGAIN error in ntfsend tool [#2961]

ntfsend is blocked in case TRY_AGAIN error. It should do the retry in limit time. --- src/ntf/tools/ntfclient.c | 75 --- src/ntf/tools/ntfsend.c | 240 +++--- 2 files changed, 120 insertions(+), 195 deletions(-) diff --git

[devel] [PATCH 0/2] Review Request for ntf: Limit the logger buffer [#2961] V2

Summary: ntf: Limit the logger buffer [#2961] Review request for Ticket(s): 2961 Peer Reviewer(s): Lennart, Minh Pull request to: Minh Affected branch(es): develop, release Development branch: ticket-2961 Base revision: 8679707a45014fc2cb964cd931126a3607a03aab Personal repository:

[devel] [PATCH 1/2] ntf: Limit the logger buffer [#2961]

When writing the notificaion fail with TRY_AGAIN in callback, the notificaion is pushed again to the list. If this happens for long time, the list is going to be very big. This cause NTFD take time to process writing all the notification in the list and the request from NTFA come this time may