Re: [devel] Review request ntf: update document for limit of logger buffer [#2994]

2019-01-17 Thread Canh Van Truong
Hi aMinh I have updated your comments. Please help check and push the document if there are no more comments. Thanks Canh From: Minh Hon Chau Sent: Friday, January 18, 2019 7:25 AM To: Lennart Lund ; Canh Van Truong Cc: opensaf-devel@lists.sourceforge.net Subject: Re: Review

Re: [devel] Review request ntf: update document for limit of logger buffer [#2994]

2019-01-17 Thread Minh Hon Chau
Hi Canh, A very minor comment, that we may have to mention it's for alarm notif only. Thanks, Minh On 11/1/19 11:30 pm, Lennart Lund wrote: Hi Canh, I should have Acked the document in my previous answer. Just fix any minor things and push. Thanks Lennart *From:*Canh Van Truong

Re: [devel] [PATCH 1/1] mdstest: fix tet_svc_subscr_VDEST_11() fail with TIPC transport [#2978]

2019-01-17 Thread Minh Hon Chau
Hi Thuan, I think it's ok for sleep() to make the test simple, ack from me. thanks Minh On 29/11/18 7:47 pm, thuan.tran wrote: TIPC published event received is not as order MDS service install. Service 600 got published role active before role standby even install role standby before role

[devel] [PATCH 3/5] log: fix truncation warning [#2999]

2019-01-17 Thread Jones, Alex
--- src/log/apitest/tet_LogOiOps.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/log/apitest/tet_LogOiOps.c b/src/log/apitest/tet_LogOiOps.c index 23fe13838..e74cd5331 100644 --- a/src/log/apitest/tet_LogOiOps.c +++ b/src/log/apitest/tet_LogOiOps.c @@ -99,8 +99,11

[devel] [PATCH 0/5] Review Request for all: fix warnings from gcc 8.2.1 [#2999]

2019-01-17 Thread Jones, Alex
Summary: all: fix warnings from gcc 8.2.1 [#2999] Review request for Ticket(s): 2999 Peer Reviewer(s): Anders, Lennart, Vu, Hans Pull request to: Affected branch(es): develop Development branch: ticket-2999 Base revision: 6c5c389b4d92bf48e42615b067f8a9028880a2a8 Personal repository:

[devel] [PATCH 1/5] all: fix warnings from gcc 8.2.1 [#2999]

2019-01-17 Thread Jones, Alex
These are mostly string overflow issues. --- src/base/conf.cc | 4 +-- src/base/daemon.c | 7 +++-- src/dtm/dtmnd/dtm_main.cc | 2 +- src/dtm/dtmnd/multicast.cc | 2 +- src/imm/immnd/immnd_proc.c | 2 +- src/imm/immnd/immnd_utils.cc

[devel] [PATCH 5/5] logd: fix crash in logd [#2999]

2019-01-17 Thread Jones, Alex
--- src/log/logd/lgs_dest.cc | 2 +- src/log/logd/lgs_unixsock_dest.cc | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/log/logd/lgs_dest.cc b/src/log/logd/lgs_dest.cc index 0bd1fd3b0..0e70ddd12 100644 --- a/src/log/logd/lgs_dest.cc +++

[devel] [PATCH 4/5] logd: fix truncation warnings [#2999]

2019-01-17 Thread Jones, Alex
--- src/log/logd/lgs_util.cc | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/log/logd/lgs_util.cc b/src/log/logd/lgs_util.cc index 9b0707fd7..28b2a3271 100644 --- a/src/log/logd/lgs_util.cc +++ b/src/log/logd/lgs_util.cc @@ -199,19 +199,14 @@ char

[devel] [PATCH 2/5] smfd: fix uninitialized variable warning [#2999]

2019-01-17 Thread Jones, Alex
--- src/smf/smfd/SmfUpgradeStep.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/smf/smfd/SmfUpgradeStep.cc b/src/smf/smfd/SmfUpgradeStep.cc index 80da668de..0a8d52363 100644 --- a/src/smf/smfd/SmfUpgradeStep.cc +++ b/src/smf/smfd/SmfUpgradeStep.cc @@ -1419,7 +1419,7 @@