Re: [devel] [PATCH 1/1] dtm: Fix dtm close socket due to duplication of adding node IP info [#2984]

2019-03-06 Thread Canh Van Truong
Hi Gary and Hans, Thanks for your review. I updated Gary comment and running patch test again. @Hans. Because there is just small changes that does not related to the ticket. (the changes in dtm_node_delete() and dtm_node_add() with replace number by enum) so I don’t separate the patch. I

Re: [devel] [PATCH 1/1] log: Fix the last value of logRecordDestinationConfiguration is not deleted [#3014]

2019-03-06 Thread Vu Minh Nguyen
Hi Canh, Ack. Thanks. Regards, Vu > -Original Message- > From: Canh Van Truong > Sent: Friday, March 1, 2019 5:36 PM > To: lennart.l...@ericsson.com; vu.m.ngu...@dektech.com.au > Cc: opensaf-devel@lists.sourceforge.net; Canh Van Truong > > Subject: [PATCH 1/1] log: Fix the last value

Re: [devel] [PATCH 1/1] dtm: Fix dtm close socket due to duplication of adding node IP info [#2984]

2019-03-06 Thread Gary Lee
Hi Canh One minor comment, KEY_TYPES should probably be called KeyTypes. Also, can you make it an enum class, rather than plain enum? Thanks Gary On 7/3/19 12:53 am, Hans Nordebäck wrote: Hi Canh, ack, review only. I think it would be good to separate the re-factoring part in a separate

Re: [devel] [PATCH 1/1] dtm: Fix dtm close socket due to duplication of adding node IP info [#2984]

2019-03-06 Thread Hans Nordebäck
Hi Canh, ack, review only. I think it would be good to separate the re-factoring part in a separate ticket though. /BR Hans On 12/18/18 08:25, Canh Van Truong wrote: > During cluster start, one node (node 1) broadcast up msg to other node. The > remote node (node 2) get this msg and send the