Re: [devel] [PATCH 1/1] amfd: prevent infinite loop [#3050]

Hi Gary, ack, code review only/Thanks HansN On 2019-06-20 04:13, Gary Lee wrote: > In handle_event_in_failover_state(), we iterate through > queue_evt in a while loop, but process_event() can insert > items into the queue inside the loop, and we may end > up never exiting the while loop. > --- >

Re: [devel] [PATCH 1/1] amf: remove SUSI assignemnt of dependent SI during failover [#3049]

Hi Thang, ack (review + test). In below syslog, I got the assignment of sponsor + dependent on the locked SC removed, and the other SC creates new active assignments. Minor comment: In sg_2n_fsm:node_fail_su_oper(), starting from line 3153, the codes are now most likely the same for both

Re: [devel] [PATCH 1/1] utils: Use a fence daemon as an alternative to payload reboot fencing [#3048]

Hi Hans Looks good, ack (review only). One very, very minor comment: # systemd services managed by fenced. Separate service names by whitespace, e.g. "opensafd" SERVICES_TO_FENCE="opensafd" I guess you could put a second service in the example :-) Thanks Gary On 5/6/19 6:36 pm, Hans