[devel] [PATCH 0/1] Review Request for smfd: set campaign state failed when error msg is introduced V2 [#3063]

Summary: smfd: set campaign state failed when error msg is introduced V2 [#3063] Review request for Ticket(s): 3063 Peer Reviewer(s): Lennart Lund, Thuan Tran Pull request to: Minh Chau Affected branch(es): develop Development branch: ticket-3063 Base revision:

[devel] [PATCH 1/1] smfd: set campaign state failed when error msg is introduced [#3063]

With single step upgrade method, after a manual cluster reboot, campaign status gets error but state remains EXECUTION_COMPLETED. This change corrects the state of campaign in such case. --- src/smf/smfd/SmfCampaign.cc | 17 + 1 file changed, 17 insertions(+) diff --git

Re: [devel] [PATCH 1/1] nid: use the tipc command instead of tipc-config [#2104]

Hi Vu ack (review only) Thanks On 1/8/19 12:53 pm, Vu Minh Nguyen wrote: The tipc-config command is obsolete and no longer being maintained. We should switch to using the "tipc" command instead --- Makefile.am | 3 ++- opensaf.spec.in

Re: [devel] [PATCH 1/1] amfd: add support for dynamically changing saAmfRank of SaAmfSIRankedSU [#3058]

Hi Alex, ack code review only, a few minor comments below/Thanks HansN On 2019-07-18 21:04, Jones, Alex wrote: Allow saAmfRank of SaAmfSIRankedSU to be changed at runtime --- src/amf/amfd/si.cc | 103 + src/amf/amfd/si.h | 3 ++ src/amf/amfd/siass.cc | 38

Re: [devel] [PATCH 1/1] smfd: set campaign state failed when error msg is introduced [#3063]

Hi Khanh, It's better if you add comment for code. Example: // This happen when unexpected cluster reboot // when campaign (merged to single step) reach EXECUTION_COMPLETED // Keep state EXCUTION_COMPLETED then user try to commit lead to // SMFD crash and campaign cannot be committed in anyway.