Summary: smf: Fix c-linkage and string op errors V3 [#3065]
Review request for Ticket(s): 3065
Peer Reviewer(s): *** LIST THE TECH REVIEWER(S) / MAINTAINER(S) HERE ***
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-3065
Base
- Fix faults in C linkage in file
src/smf/smfd/SmfUtils.h.
- Fix fault in string concatenation in file
src/smf/smfd/SmfUpgradeCampaign.cc
---
src/smf/smfd/SmfUpgradeCampaign.cc | 3 ++-
src/smf/smfd/SmfUtils.h| 10 ++
2 files changed, 8 insertions(+), 5 deletions(-)
diff
Summary: smf: Fix c-linkage and string op errors V2 [#3065]
Review request for Ticket(s): 3065
Peer Reviewer(s): *** LIST THE TECH REVIEWER(S) / MAINTAINER(S) HERE ***
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-3065
Base
Hi Hans,
I will update the code for that point.
Thanks
Minh
On 23/8/19 11:14 pm, Hans Nordebäck wrote:
Hi Minh,
see one comment below. /Thanks Hans
On 2019-08-23 03:48, Minh Hon Chau wrote:
Hi Hans,
Thanks for your time to review the patch, please see my replies below
your comments.