Re: [devel] [PATCH 1/1] amfd: fix coredump during downgrade if delayed failover is enabled [#3078]

2019-09-10 Thread Minh Hon Chau
Hi Gary, The patch works fine in the reported scenario, no coredump in amfd. But after downgrade succeeds (meaning the sc1 is active and running old software, the sc2 is standby running latest software + #3078), I continue another switchover to make sc2 back to active, I got error Thanks

Re: [devel] [PATCH 3/9] mds: Add implementation for TIPC buffer overflow solution [#1960]

2019-09-10 Thread Minh Hon Chau
Hi Gary, Thanks for the review, please find comments with [M]. /Minh On 10/9/19 6:02 pm, Gary Lee wrote: Hi Minh & Thuan Some minor comments marked with [GL]. On 14/8/19 4:38 pm, Minh Chau wrote: This is a collaborative patch of two participants:Thuan, Minh. Main changes: - Add

Re: [devel] [PATCH 1/1] evtd: handle CLM-API errors during SC absence [#3081]

2019-09-10 Thread Mathi N P
About the patch, I have no clue why the indentation looks strange. I just have a question below, otherwise ack: +while (true) { +/* Say Hello */ +rc = saClmInitialize_4(>clm_hdl, _cbk, _version); +if (rc == SA_AIS_OK) +break; +else if (rc == SA_AIS_ERR_TRY_AGAIN || +rc == SA_AIS_ERR_UNAVAILABLE) {

Re: [devel] [PATCH 3/9] mds: Add implementation for TIPC buffer overflow solution [#1960]

2019-09-10 Thread Gary Lee
Please ignore the Encode/Decode comment. On 10/9/19 6:02 pm, Gary Lee wrote: Hi Minh & Thuan Some minor comments marked with [GL]. On 14/8/19 4:38 pm, Minh Chau wrote: This is a collaborative patch of two participants:Thuan, Minh. Main changes: - Add mds_tipc_fctrl_intf.h,

Re: [devel] [PATCH 3/9] mds: Add implementation for TIPC buffer overflow solution [#1960]

2019-09-10 Thread Gary Lee
Hi Minh & Thuan Some minor comments marked with [GL]. On 14/8/19 4:38 pm, Minh Chau wrote: This is a collaborative patch of two participants:Thuan, Minh. Main changes: - Add mds_tipc_fctrl_intf.h, mds_tipc_fctrl_intf.cc: These two files introduce new functions which are called in