Re: [devel] [PATCH 4/9] mds: Add timeout for ack message [#1960]

2019-09-15 Thread Nguyen Minh Vu
Hi Minh, I have minor comments below. Regards, Vu On 8/14/19 1:38 PM, Minh Chau wrote: If the ack size is configured greater than 1, there should be a timeout at receiver ends to send the ack message back to senders. The ack message timeout utilizes the poll timeout in flow control thread to

Re: [devel] [PATCH 3/9] mds: Add implementation for TIPC buffer overflow solution [#1960]

2019-09-15 Thread Nguyen Minh Vu
Hi Minh, I have several comments below, started with [Vu]. Regards, Vu On 8/14/19 1:01 PM, Minh Chau wrote: This is a collaborative patch of two participants: - Tran Thuan - Minh Chau Main changes: - Add mds_tipc_fctrl_intf.h, mds_tipc_fctrl_intf.cc: These two files introduce new functions

Re: [devel] [PATCH 3/9] mds: Add implementation for TIPC buffer overflow solution [#1960]

2019-09-15 Thread Minh Hon Chau
Hi Hans, Gary, Vu Do you have any comments on remaining patches? Thanks Minh On 11/9/19 11:01 am, Minh Hon Chau wrote: Hi Gary, Thanks for the review, please find comments with [M]. /Minh On 10/9/19 6:02 pm, Gary Lee wrote: Hi Minh & Thuan Some minor comments marked with [GL]. On