Re: [devel] [PATCH 1/1] amf: handle errors identified by codechecker [#3077]

Hi Gary, ack from me (code review only) Thanks Minh On 3/9/19 12:12 pm, Gary Lee wrote: add assertions where pointers should not be null fix a couple of typos --- src/amf/amfd/comp.cc | 1 + src/amf/amfd/csi.cc| 3 ++- src/amf/amfd/cstype.cc | 2 ++

Re: [devel] [PATCH 8/9] mds: Apply serial number arithmetic for sequence counter [#1960]

Hi Minh, I have a minor comment below. Regards, Vu On 8/14/19 1:38 PM, Minh Chau wrote: This patch applies the serial number arithmetic for the flow control sequence number, referenced to RFC1982. This is only temporary patch, a proper one could be made in /base with template for others

Re: [devel] [PATCH 1/1] amfd: correct handling complete/apply callback on standby sc [#3082]

Hi Thang ack (review only) Thanks Gary On 16/9/19 4:44 pm, thang.d.nguyen wrote: During stanby SC comes up, AMF config objects are deleted on active SC. It causes NOT_EXIST error on standby node. AMFD on standby should ignore this error in this case. --- src/amf/amfd/app.cc| 29

Re: [devel] [PATCH 6/9] mds: Implement kRcvBuffOverflow state [#1960]

Hi Vu, Agree with your comments. Any comments for patches 8/9 and 9/9? thanks Minh On 16/9/19 5:22 pm, Nguyen Minh Vu wrote: Hi Minh, I has few comments below. Regards, Vu On 8/14/19 1:38 PM, Minh Chau wrote: This patch implements the kRcvBuffOverflow state machine as described in README

Re: [devel] [PATCH 1/9] mds: Add README for solution of TIPC buffer overflow at MDS [#1960]

Hi Vu, Thanks for your time to review the patches, the question is interesting. At this moment with normal load traffic, the resource towards the new standby (old active) is not released and will be reused if standby switches back to active. The reason is that mds won't start the "tx

Re: [devel] [PATCH 6/9] mds: Implement kRcvBuffOverflow state [#1960]

Hi Minh, I has few comments below. Regards, Vu On 8/14/19 1:38 PM, Minh Chau wrote: This patch implements the kRcvBuffOverflow state machine as described in README file. --- src/mds/mds_tipc_fctrl_intf.cc | 6 +- src/mds/mds_tipc_fctrl_msg.h | 1 +

[devel] [PATCH 0/1] Review Request for amfd: correct handling complete/apply callback on standby sc [#3082]

Summary: amfd: correct handling complete/apply callback on standby sc [#3082] Review request for Ticket(s): 3082 Peer Reviewer(s): Gary, Minh, Thuan Pull request to: Gary Affected branch(es): develop Development branch: ticket-3082 Base revision: eac09bf540f33cf25ee2a8902aeeef40ee6bbf3b

[devel] [PATCH 1/1] amfd: correct handling complete/apply callback on standby sc [#3082]

During stanby SC comes up, AMF config objects are deleted on active SC. It causes NOT_EXIST error on standby node. AMFD on standby should ignore this error in this case. --- src/amf/amfd/app.cc| 29 - src/amf/amfd/comp.cc | 18 +++---

Re: [devel] [PATCH 3/9] mds: Add implementation for TIPC buffer overflow solution [#1960]

Hi Vu, I see it, will add. Thanks Minh On 16/9/19 4:21 pm, Nguyen Minh Vu wrote: Hi Minh, See my responses to your comments below, started with [Vu2]. Regards, Vu On 9/16/19 1:06 PM, Minh Hon Chau wrote: Hi Vu, Several comments with [M] too :). Thanks Minh On 16/9/19 2:24 pm, Nguyen

Re: [devel] [PATCH 5/9] mds: Add state machine for tipc portid instance [#1960]

Hi Vu, Some comments with [M] Thanks Minh On 16/9/19 2:56 pm, Nguyen Minh Vu wrote: Hi Minh, I has few comments below. Regards, Vu On 8/14/19 1:38 PM, Minh Chau wrote: This patch adds state machine to support tx probation timer. ---   src/mds/mds_tipc_fctrl_intf.cc   |  47

Re: [devel] [PATCH 3/9] mds: Add implementation for TIPC buffer overflow solution [#1960]

Hi Minh, See my responses to your comments below, started with [Vu2]. Regards, Vu On 9/16/19 1:06 PM, Minh Hon Chau wrote: Hi Vu, Several comments with [M] too :). Thanks Minh On 16/9/19 2:24 pm, Nguyen Minh Vu wrote: Hi Minh, I have several comments below, started with [Vu]. Regards,

Re: [devel] [PATCH 4/9] mds: Add timeout for ack message [#1960]

Hi Vu, Some comments with [M] Thanks Minh On 16/9/19 2:37 pm, Nguyen Minh Vu wrote: Hi Minh, I have minor comments below. Regards, Vu On 8/14/19 1:38 PM, Minh Chau wrote: If the ack size is configured greater than 1, there should be a timeout at receiver ends to send the ack message back

Re: [devel] [PATCH 3/9] mds: Add implementation for TIPC buffer overflow solution [#1960]

Hi Vu, Several comments with [M] too :). Thanks Minh On 16/9/19 2:24 pm, Nguyen Minh Vu wrote: Hi Minh, I have several comments below, started with [Vu]. Regards, Vu On 8/14/19 1:01 PM, Minh Chau wrote: This is a collaborative patch of two participants: - Tran Thuan - Minh Chau Main