Re: [devel] [PATCH 1/1] ntfd: Do not send response to client if client down [#3084]

2019-10-09 Thread Thien Minh Huynh
Hi Minh, Thanks for your comment. In case, agent down before clientAdded() then SearchAndSetClientsDownFlag() does not work. Best Regards, ThienHuynh -Original Message- From: Minh Hon Chau Sent: Thursday, October 10, 2019 1:50 AM To: Thien Minh Huynh ; 'Nguyen Minh Vu' ;

[devel] [PATCH 1/1] osaf: return new takeover_request immediately [#3098]

2019-10-09 Thread Gary Lee
If a takeover_request is created just before the active controller calls 'watch takeover_request', then it's possible that the active rded instance is not informed of the request. When 'watch takeover_request' is called, check if there's already a takeover_request in 'NEW' state and return

[devel] [PATCH 0/1] Review Request for osaf: return new takeover_request immediately [#3098]

2019-10-09 Thread Gary Lee
Summary: osaf: return new takeover_request immediately [#3098] Review request for Ticket(s): 3098 Peer Reviewer(s): Minh, Thuan, Thang, Hans Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-3098 Base revision:

Re: [devel] [PATCH 1/1] ntfd: Do not send response to client if client down [#3084]

2019-10-09 Thread Minh Hon Chau
Hi all, What I guess from the ticket that it is a race condition between the mds thread and main thread in ntfd. We normally get NCSDOWN callback from mds, and send event to main thread to remove the client. But the mds callback here comes in the middle of processing Initialize(). We have

Re: [devel] [PATCH 1/1] ntfd: Do not send response to client if client down [#3084]

2019-10-09 Thread Thien Minh Huynh
Hi Vu, Thanks for your time to review the patch. Best Regards, ThienHuynh -Original Message- From: Nguyen Minh Vu Sent: Wednesday, October 9, 2019 11:15 AM To: thien.m.huynh ; thuan.t...@dektech.com.au; minh.c...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net Subject: Re: