Re: [devel] [PATCH 1/1] mds: Add Intro message [#3090]

Hi bro.Minh, ACK from me. Best Regards, ThuanTr -Original Message- From: Minh Hon Chau Sent: Tuesday, October 15, 2019 8:54 AM To: hans.nordeb...@ericsson.com; vu.m.ngu...@dektech.com.au; gary@dektech.com.au; thuan.t...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net

Re: [devel] [PATCH 1/1] mds: Add Intro message [#3090]

Hi, The counters reset will be removed in ReceiveIntro(). Thanks Minh On 15/10/19 12:50 pm, Minh Chau wrote: mds relies on data message sent from the peer to determine whether the MDS_TIPC_FCTRL_ENABLED is set. The data message may not be sent right after TIPC_PUBLISHED event, which can

[devel] [PATCH 1/1] mds: Add Intro message [#3090]

mds relies on data message sent from the peer to determine whether the MDS_TIPC_FCTRL_ENABLED is set. The data message may not be sent right after TIPC_PUBLISHED event, which can cause the tx probation timer timeout. This patch add Intro message, which is sent right after the TIPC_PUBLISHED to

[devel] [PATCH 0/1] Review Request for mds: Add Intro message [#3090]

Summary: mds: Add Intro message [#3090] Review request for Ticket(s): 3090 Peer Reviewer(s): Hans, Vu, Gary, Thuan Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-3090 Base revision: 413b8fa37a190ffe1e34ea09205bc22b8d8e60a4

Re: [devel] [PATCH 1/1] mds: add more tests for mds flow control [#3091]

Hi Thuan Looks OK (review only). Thanks Gary On 14/10/19 8:44 pm, thuan.tran wrote: mdstest for overload - 2 senders overload one receivers - one sender overloads 2 receivers mdstest for SNA (Serial Number Arithmetic) - without overload, mds sender gradually sends more than 65535 messages

Re: [devel] [PATCH 1/1] mds: Add Reset message [#3090]

Hi bro.Minh, Thanks, no more comment from me. Best Regards, ThuanTr -Original Message- From: Minh Hon Chau Sent: Monday, October 14, 2019 7:28 PM To: Tran Thuan ; hans.nordeb...@ericsson.com; gary@dektech.com.au; vu.m.ngu...@dektech.com.au Cc: opensaf-devel@lists.sourceforge.net

Re: [devel] [PATCH 1/1] mds: Add Reset message [#3090]

Hi Thuan, I can rename it as "Intro" message, then the rcvwnd counter shall be removed. This new message can not replace the tx prob timer. This new message is to speed up the determinatin of flow control at the peer side rather than mds data message. It is needed for the flow control

[devel] [PATCH 0/1] Review Request for mds: add more tests for mds flow control [#3091] V4

Summary: mds: add more tests for mds flow control [#3091] Review request for Ticket(s): 3091 Peer Reviewer(s): Minh, Gary Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-3091 Base revision:

[devel] [PATCH 1/1] mds: add more tests for mds flow control [#3091]

mdstest for overload - 2 senders overload one receivers - one sender overloads 2 receivers mdstest for SNA (Serial Number Arithmetic) - without overload, mds sender gradually sends more than 65535 messages and receivers should receive them all - with overload, mds sender sends a burst of

Re: [devel] [PATCH 1/1] mds: Add Reset message [#3090]

Hi bro.Minh, Thanks for explanation. I think the "reset" message should be rename to "introduce" message. Another question: with this fix, will tx probation timer become redundant or still useful in somehow? Best Regards, ThuanTr -Original Message- From: Minh Hon Chau Sent: Monday,

Re: [devel] [PATCH 1/1] mds: Add Reset message [#3090]

Hi Thuan, If the chunkack is configured to send after a few data messages, then the sender is not getting any chunkack for the first message from receiver until chunkack timeout (which is also configurable to be a bit larger value). Then, the probation timer would be timeout at sender. The