Hi Thuan,
Please see comment inline
Thanks
Minh
On 23/10/19 3:32 pm, Tran Thuan wrote:
Hi Minh,
Thanks for comments. See my response inline.
Btw, I am preparing to send out new patch, I think I found an issue in
current patch.
Best Regards,
ThuanTr
-Original Message-
From:
Summary: nid: Remove the absolute path of tipc command [#3105]
Review request for Ticket(s): 3105
Peer Reviewer(s): Thuan, Vu
Pull request to: Vu
Affected branch(es): develop
Development branch: ticket-3105
Base revision: 9b1c588a4f244cb34a304b03c7568e04fa6cd8a7
Personal repository:
---
scripts/tipc-config | 22 --
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/scripts/tipc-config b/scripts/tipc-config
index 34eb9a5..6a20275 100755
--- a/scripts/tipc-config
+++ b/scripts/tipc-config
@@ -36,10 +36,12 @@ EOF
exit 1
fi
+tipc=$(which
Hi Minh,
Thanks for comments. See my response inline.
Btw, I am preparing to send out new patch, I think I found an issue in current
patch.
Best Regards,
ThuanTr
-Original Message-
From: Minh Hon Chau
Sent: Wednesday, October 23, 2019 5:52 AM
To: Tran Thuan ; 'Nguyen Minh
Hi Vu,
Thanks for your comments.
Best Regards,
ThienHuynh
-Original Message-
From: Nguyen Minh Vu
Sent: Wednesday, October 23, 2019 9:58 AM
To: thien.m.huynh ; thuan.t...@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] nid: Remove the absolute path of
Hi Thien,
Ack with comments.
Regards, Vu
On 10/23/19 9:42 AM, thien.m.huynh wrote:
---
scripts/tipc-config | 22 --
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/scripts/tipc-config b/scripts/tipc-config
index 34eb9a5..b7c6cef 100755
---
---
scripts/tipc-config | 22 --
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/scripts/tipc-config b/scripts/tipc-config
index 34eb9a5..b7c6cef 100755
--- a/scripts/tipc-config
+++ b/scripts/tipc-config
@@ -36,10 +36,12 @@ EOF
exit 1
fi
+tipc=$(which
Summary: nid: Remove the absolute path of tipc command [#3105]
Review request for Ticket(s): 3105
Peer Reviewer(s): Thuan, Vu
Pull request to: Vu
Affected branch(es): develop
Development branch: ticket-3105
Base revision: 9b1c588a4f244cb34a304b03c7568e04fa6cd8a7
Personal repository:
Hi Thuan,
I wonder the patch would work in the same reproduced steps if the both
adests have subscribed each other more than 2 services. The svc_cnt will
be greater than 1 until it is the last service down event. I think
that's why mds has the database @subtn_results, in which each item is an
Hi Vu,
Thanks for additional comments.
I reply your concerns inline below.
Best Regards,
ThuanTr
-Original Message-
From: Nguyen Minh Vu
Sent: Tuesday, October 22, 2019 5:28 PM
To: thuan.tran ; 'Minh Chau'
; hans.nordeb...@ericsson.com; gary@dektech.com.au
Cc:
Hi Thuan,
I have additional comments below.
Regards, Vu
On 10/22/19 7:14 AM, thuan.tran wrote:
- When sending response message which Adest not exist (already down)
current MDS try to wait for 1.5 seconds before conclude no route to
send response message.
- There are 2 scenarios may have:
UP
Hi Vu,
Thanks for comments. I reply my answer inline.
Best Regards,
ThuanTr
-Original Message-
From: Nguyen Minh Vu
Sent: Tuesday, October 22, 2019 4:42 PM
To: thuan.tran ; 'Minh Chau'
; hans.nordeb...@ericsson.com; gary@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net
Hi Thuan,
I have few comments below.
Regards, Vu
On 10/22/19 7:14 AM, thuan.tran wrote:
- When sending response message which Adest not exist (already down)
current MDS try to wait for 1.5 seconds before conclude no route to
send response message.
- There are 2 scenarios may have:
UP -> DOWN
Hi Minh,
Thanks for your comments:
1- The wait time 1.5 in this flow:
mds_mcm_process_disc_queue_checks_redundant()
mds_subtn_tbl_add_disc_queue()
if (true == time_wait) {
timeout_val = 150; /* This may need a tuning */
}
2- We should not touch to current adest
14 matches
Mail list logo
