---
src/mds/apitest/mdstipc.h | 2 +-
src/mds/apitest/mdstipc_api.c | 134 +++--
src/mds/apitest/mdstipc_conf.c | 9 ++-
src/mds/mds_c_sndrcv.c | 1 +
src/mds/mds_tipc_fctrl_intf.cc | 4 +-
5 files changed, 88 insertions(+), 62 deletions(-)
diff
Summary: mds: fix memleak in code and test [#1860]
Review request for Ticket(s): 1860
Peer Reviewer(s): Minh, Vu, Gary
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-1860
Base revision: 1aaa913e028197cc4fd6cd77023b3830388cd9c9
Hi Vu,
I used osaf_clock_gettime() since it's used some places already in current code
file.
E.g: Line 626, Line 638. I think we keep use it to easy for code reading.
Or we have to change all osaf_clock_gettime() calls in current code file.
Best Regards,
ThuanTr
-Original Message-
Hi Thuan,
Ack with a minor comment.
Regards,
On 11/4/19 2:57 PM, thuan.tran wrote:
---
src/imm/agent/imma_db.cc | 2 +-
src/imm/immnd/immnd_main.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/imm/agent/imma_db.cc b/src/imm/agent/imma_db.cc
index
Hi Vu,
Agree, please help update NULL to nullptr before push.
Thanks.
Best Regards,
ThuanTr
-Original Message-
From: Nguyen Minh Vu
Sent: Tuesday, November 19, 2019 9:58 AM
To: thuan.tran ; 'Minh Hon Chau'
; gary@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re:
Hi Thuan,
Ack with a minor comment.
Regards, Vu
On 11/4/19 2:17 PM, thuan.tran wrote:
---
src/log/logd/lgs_mbcsv.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/log/logd/lgs_mbcsv.cc b/src/log/logd/lgs_mbcsv.cc
index cd3d70009..ebc659ea1 100644
---
Hi Thuan
ack from me.
Thanks
Minh
On 4/11/19 6:42 pm, thuan.tran wrote:
---
src/ntf/agent/ntfa_api.c | 29 +++--
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git a/src/ntf/agent/ntfa_api.c b/src/ntf/agent/ntfa_api.c
index 417c9d688..e89479bf6 100644
Hi Thuan
ack from me.
thanks
Minh
On 4/11/19 5:56 pm, thuan.tran wrote:
---
src/mds/mds_c_db.c | 1 +
src/mds/mds_c_sndrcv.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/mds/mds_c_db.c b/src/mds/mds_c_db.c
index 58f0e3aee..e1991517e 100644
---
