Re: [devel] [PATCH 1/1] ntf: fix ntfimcn fail to send notification with no space error [#3181]

2020-05-04 Thread Minh Hon Chau
Yes right, i was thinking of a 64bit value. Get Outlook for iOS From: Thuan Tran Sent: Monday, May 4, 2020 8:12:43 PM To: Minh Hon Chau ; Thang Duc Nguyen Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 1/1] ntf: fix ntfimcn

Re: [devel] [PATCH 1/1] ntf: fix ntfimcn fail to send notification with no space error [#3181]

2020-05-04 Thread minhchau
Hi Thuan Ack with comment. I think we need to check the max value of unit32t for ntf_var_data_limit when we source from the env var. Thanks Minh On 27/4/20 9:05 pm, thuan.tran wrote: - Support NTFA_VARIABLE_DATA_LIMIT configuration for NTF Agent. Default value is SHRT_MAX(32767). - In

Re: [devel] [PATCH 1/1] ntf: fix ntfimcn fail to send notification with no space error [#3181]

2020-05-04 Thread Thuan Tran
Hi Minh, Regarding to check max unit32, I think it's not necessary. Because the atoi() returns the converted integral number as an int value. It cannot bigger than max of uint32. Best Regards, Thuan From: Minh Hon Chau Sent: Monday, May 4, 2020 12:37 PM To: