Ack, code review only. Some minor comments below. /Thanks HansN
-Original Message-
From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
Sent: den 6 januari 2015 06:35
To: Hans Feldt; nagendr...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 1
It looks ok to me, code review only. One comment, saAmfNGNodeList is now
ordered, (by std::string) before it was unordered,
so perhaps the comment in su.cc:482 should be updated?
/Thanks HansN
On 02/09/2015 07:24 AM, gary@dektech.com.au wrote:
osaf/services/saf/amf/amfd/include/node.h |
ack, code review only/Thanks HansN
On 01/29/2015 09:39 AM, nagendr...@oracle.com wrote:
osaf/services/saf/amf/amfnd/clc.cc | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
Amfnd is asserting when it gets instantiate success
event during node failover. This was done in the
ack, code review only. One question, the rows above this patch, if
ava_mds_send fails and msg_rsp is set to 0,
SA_AIS_ERR_TRY_AGAIN but seems not be returned?/Thanks HansN
On 12/09/2014 12:40 PM, nagendr...@oracle.com wrote:
if (rec-cbk_info-type == AVSV_AMF_COMP_TERM) {
- if
ack, code review only/Thanks HansN
On 12/04/2014 11:52 AM, nagendr...@oracle.com wrote:
osaf/services/saf/amf/amfd/sgproc.cc | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/sgproc.cc
b/osaf/services/saf/amf/amfd/sgproc.cc
---
ack, code review only/Thanks HansN
On 11/25/2014 09:59 AM, praveen.malv...@oracle.com wrote:
osaf/libs/agents/saf/amfa/ava_api.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
saAmfResponse() communicates with AMFND synchronously for term callback
response.
When AMFND
Ack for the series, code review only/Regards HansN
-Original Message-
From: Hans Feldt
Sent: den 20 oktober 2014 15:53
To: Hans Nordebäck
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 0 of 5] Review Request for pyosaf #751
Summary: fix pylint rating focused on immom Review
Ack, code review only, yes it should be
SaImmAdminOperationParamsT_2./Regards HansN
On 10/20/2014 01:25 PM, Hans Feldt wrote:
On 10/20/2014 10:40 AM, Hans Feldt wrote:
python/pyosaf/saAis.py | 4 ++--
python/pyosaf/saImmOm.py | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
Ack, (tested the pre-patch)/Regards HansN
On 09/24/14 21:26, mathi.naic...@oracle.com wrote:
osaf/services/saf/clmsv/clms/clms_cb.h | 6 +
osaf/services/saf/clmsv/clms/clms_evt.c | 35
-
2 files changed, 40 insertions(+), 1 deletions(-)
There is
Ack, (tested the pre-patch)/Regards HansN
On 09/24/14 21:26, mathi.naic...@oracle.com wrote:
osaf/services/saf/clmsv/clms/clms_evt.c | 16 +++-
1 files changed, 15 insertions(+), 1 deletions(-)
It is quite possible that the agent downs are for the agents that were
running
Ack, (tested the pre-patch)/Regards HansN
On 09/24/14 21:26, mathi.naic...@oracle.com wrote:
osaf/services/saf/clmsv/clms/clms_imm.c | 25 +
1 files changed, 21 insertions(+), 4 deletions(-)
It is possible that when a payload that goes down during controller
Hi Mathi, I tested the patch and SA_CLM_NODE_LEFT are sent to active node:
./rootfs/var/PL-4/log/messages:Sep 23 07:31:23 PL-4 local0.notice
osafamfnd[391]: NO This node has exited the cluster
if run in UML and power off is done in clms_track_send_node_down before
sending checkpoint data.
one node (PLx?) and then the active SC was
rebooted in the middle of handling this.
/HansF
-Original Message-
From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com]
Sent: den 23 september 2014 08:06
To: mathi.naic...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re
september 2014 08:54
To: Hans Nordebäck
Cc: Hans Feldt; opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1 of 1] clm: avoid stale node down processing and
unexpected track callback [#1120]
So, payload 4 and payload 3 were rebooted (stopped and started).
And, it appears
Ack, code review only, (one minor comment below) /Regards HansN
-Original Message-
From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
Sent: den 5 september 2014 07:00
To: Hans Feldt; nagendr...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 1
Ack, code review only/Regards HansN
-Original Message-
From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
Sent: den 6 augusti 2014 11:36
To: Hans Feldt; Hans Nordebäck; nagendr...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd : update
of the newly deleted saAmfCompNumMaxInstantiateWithoutDelay.
Isn't this is how it should work. /Regards HansN
-Original Message-
From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com]
Sent: den 4 september 2014 13:33
To: Nagendra Kumar
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re
Hi Nagu, I'll check this and the other patches. I guess I have missed
these use cases. /Thanks HansN
On 09/04/14 12:41, Nagendra Kumar wrote:
Hi Hans N,
There are some white spaces in the patch, please check below(Search with
Nagu).
Tested following scenarios:
1. Configuring
Hi, any updates on this review?/Thankss HansN
-Original Message-
From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com]
Sent: den 26 augusti 2014 14:41
To: nagendr...@oracle.com; Hans Feldt
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 1 of 1] AMF: support immediate
Ack, code review only/Regards HansN
-Original Message-
From: nagendr...@oracle.com [mailto:nagendr...@oracle.com]
Sent: den 14 augusti 2014 12:50
To: Hans Feldt; Hans Nordebäck; praveen.malv...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd: respond
Ack, code review only/Regards HansN
On 07/31/14 15:45, nagendr...@oracle.com wrote:
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 14 +++---
osaf/services/saf/amf/amfd/su.cc| 18 ++
2 files changed, 21 insertions(+), 11 deletions(-)
Shutdown operation was
Ack, code review only/Regards HansN
-Original Message-
From: nagendr...@oracle.com [mailto:nagendr...@oracle.com]
Sent: den 24 juli 2014 16:05
To: Hans Feldt; Hans Nordebäck; praveen.malv...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd: return admin op
-Original Message-
From: Nagendra Kumar [mailto:nagendr...@oracle.com]
Sent: den 12 augusti 2014 14:19
To: Hans Nordebäck; Hans Feldt; Praveen Malviya
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1 of 1] AMF: support immediate effect when changing
comp-type attributes v5 [#819
Hi Hans, yes, I'll move the variables before pushing./Regards HansN
On 08/12/14 14:40, Hans Feldt wrote:
Ack with minor inline comment
/HansF
-Original Message-
From: Hans Nordebäck
Sent: den 12 augusti 2014 11:18
To: Hans Feldt; nagendr...@oracle.com; praveen.malv...@oracle.com
Cc
Hi Nagu, thanks, I'll correct the white spaces before pushing.
I have only run the AmfDemo app with trace enabled and issued the
following commands:
immcfg -a saAmfHctDefPeriod=200
safHealthcheckKey=AmfDemo,safVersion=1,safCompType=AmfDemo1
immcfg -a
Ack, code review only, one question below. /Regards HansN
On 08/06/14 13:12, nagendr...@oracle.com wrote:
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 44
osaf/services/saf/amf/amfd/sgproc.cc| 5 +++
2 files changed, 32 insertions(+), 17 deletions(-)
saAmfCompCSISetCallbackTimeout if it was not
configured, i.e use saAmfCtDefCallbackTimeout. This is how I interpreted this
requirement. /Regards HansN
-Original Message-
From: Nagendra Kumar [mailto:nagendr...@oracle.com]
Sent: den 18 juli 2014 14:50
To: Hans Nordebäck; Hans Feldt; Praveen
Ack, code review only/Regards HansN
-Original Message-
From: nagendr...@oracle.com [mailto:nagendr...@oracle.com]
Sent: den 23 juli 2014 13:01
To: Hans Feldt; Hans Nordebäck; praveen.malv...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd: replace patricia
Ack, code review only./Regards HansN
-Original Message-
From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
Sent: den 16 juni 2014 07:08
To: Hans Feldt; Hans Nordebäck; nagendr...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd : use
Message-
From: Nagendra Kumar [mailto:nagendr...@oracle.com]
Sent: den 18 juni 2014 12:36
To: Hans Nordebäck; Hans Feldt; Praveen Malviya
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1 of 1] AMF: support immediate effect when changing hc-type
attributes V4 [#819]
Ack.
Please
: Hans Nordebäck
Sent: den 12 juni 2014 15:51
To: Hans Feldt; praveen.malv...@oracle.com; nagendr...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] AMF: support immediate effect when changing hc-type
attributes V4 [#819]
osaf/libs/common/amf/include/amf_defs.h
ack/Regards HansN
On 06/11/14 07:37, Gary Lee wrote:
osaf/services/saf/amf/amfd/include/si.h | 2 +
osaf/services/saf/amf/amfd/si.cc| 46
+++-
2 files changed, 24 insertions(+), 24 deletions(-)
Make avd_si_adjust_si_assignments a class member
ack/Regards HansN
On 06/11/14 07:37, Gary Lee wrote:
osaf/services/saf/amf/amfd/include/si.h | 1 -
osaf/services/saf/amf/amfd/si.cc| 20
2 files changed, 0 insertions(+), 21 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/include/si.h
ack/Regards HansN
On 06/12/14 08:52, Gary Lee wrote:
osaf/services/saf/amf/amfd/include/si.h | 5 +++--
osaf/services/saf/amf/amfd/si.cc | 14 +++---
osaf/services/saf/amf/amfd/sirankedsu.cc | 4 ++--
3 files changed, 12 insertions(+), 11 deletions(-)
diff --git
ack, minor comment, the Makefile.am should be updated with the new
header files. /Regards HansN
On 06/13/14 07:48, Gary Lee wrote:
osaf/services/saf/amf/amfd/include/si.h| 34 +--
osaf/services/saf/amf/amfd/include/svctype.h | 38
++
ack, minor comment, update Makefile.am/Regards HansN
On 06/13/14 07:48, Gary Lee wrote:
osaf/services/saf/amf/amfd/include/si.h | 7 +--
osaf/services/saf/amf/amfd/include/sirankedsu.h | 25
+
2 files changed, 26 insertions(+), 6 deletions(-)
diff
ack/Regards HansN
On 06/13/14 07:48, Gary Lee wrote:
osaf/services/saf/amf/amfd/include/si.h | 10 +-
osaf/services/saf/amf/amfd/sg_nway_fsm.cc| 10 +-
osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc | 10 +-
osaf/services/saf/amf/amfd/si.cc |
some comments inline./Regards HansN
-Original Message-
From: Hans Feldt [mailto:hans.fe...@ericsson.com]
Sent: den 16 juni 2014 12:17
To: praveen malviya; Hans Feldt
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 2 of 4] amfd: add specialized red model specific SG
Message-
From: Hans Feldt [mailto:osafde...@gmail.com]
Sent: den 16 juni 2014 07:08
To: Hans Nordebäck; praveen.malv...@oracle.com; nagendr...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 2 of 4] amfd: add specialized red model specific SG classes
[#713]
osaf/services/saf
ack, code review, built and run amf demo pgm/Regards HansN
On 06/13/14 06:40, nagendr...@oracle.com wrote:
osaf/services/saf/amf/amfd/include/susi.h|7 +-
osaf/services/saf/amf/amfd/sg_nway_fsm.cc| 49 ++---
osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc | 30 +++---
ack, code review only/Regards HansN
-Original Message-
From: Gary Lee [mailto:gary@dektech.com.au]
Sent: den 11 juni 2014 02:44
To: Hans Nordebäck
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd: Add constructor for AVD_SI [#713]
osaf/services/saf/amf/amfd
ack, one minor comment make copy constructor and assignment operator
private if they are not needed./Regards HansN
On 06/10/14 03:28, Gary Lee wrote:
osaf/services/saf/amf/amfd/include/si.h | 5 +++-
osaf/services/saf/amf/amfd/si.cc| 43
++--
2
ack, code review only/Regards HansN
On 06/10/14 03:28, Gary Lee wrote:
osaf/services/saf/amf/amfd/include/si.h | 5 ++-
osaf/services/saf/amf/amfd/si.cc| 45
2 files changed, 9 insertions(+), 41 deletions(-)
diff --git
ack, code review only/Regards HansN
On 06/03/14 07:24, Hans Feldt wrote:
osaf/services/saf/amf/amfd/include/su.h | 2 ++
osaf/services/saf/amf/amfd/sgproc.cc| 26 +++---
osaf/services/saf/amf/amfd/su.cc| 19 +++
3 files changed, 24
ack, code review only/Regards HansN
On 06/03/14 07:24, Hans Feldt wrote:
osaf/services/saf/amf/amfd/include/su.h |9 +
osaf/services/saf/amf/amfd/su.cc| 461
+--
2 files changed, 257 insertions(+), 213 deletions(-)
complexity of su.cc dropped
no, I think the patch is ok as it is/BR HansN
-Original Message-
From: Hans Feldt
Sent: den 9 juni 2014 09:28
To: Hans Nordebäck; Hans Feldt
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 1 of 4] amfd: remove mds copy support [#713]
-Original Message
ack, minor comment, lots of whitespace changes/Regards HansN
On 06/03/14 07:24, Hans Feldt wrote:
osaf/libs/common/amf/d2nmsg.c | 184
--
osaf/libs/common/amf/include/amf_d2nmsg.h |1 -
osaf/services/saf/amf/amfd/include/mds.h |1 -
Hi Praveen, one comment inline below/Regards HansN
-Original Message-
From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
Sent: den 4 juni 2014 12:20
To: Hans Nordebäck; Hans Feldt; nagendr...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 01 of 12
ack, code review only/Regards HansN
On 06/04/14 12:19, praveen.malv...@oracle.com wrote:
osaf/services/saf/amf/amfd/csi.cc| 8 +++---
osaf/services/saf/amf/amfd/cstype.cc | 35
+--
osaf/services/saf/amf/amfd/include/csi.h | 3 +-
3 files
ack, code review only/Regards HansN
On 06/04/14 12:20, praveen.malv...@oracle.com wrote:
osaf/services/saf/amf/amfd/ckpt_updt.cc | 6 ++--
osaf/services/saf/amf/amfd/csi.cc| 42
+--
osaf/services/saf/amf/amfd/csiattr.cc| 12
ack, code review only/Regards HansN
On 06/04/14 12:20, praveen.malv...@oracle.com wrote:
osaf/services/saf/amf/amfd/include/sutype.h | 9 +--
osaf/services/saf/amf/amfd/sgtype.cc| 2 +-
osaf/services/saf/amf/amfd/su.cc| 10 +++---
ack, code review only/Regards HansN
On 06/04/14 12:20, praveen.malv...@oracle.com wrote:
osaf/services/saf/amf/amfd/include/sutcomptype.h | 3 +-
osaf/services/saf/amf/amfd/sutcomptype.cc| 29
---
2 files changed, 7 insertions(+), 25 deletions(-)
diff
ack, code review only/Regards HansN
On 06/04/14 12:20, praveen.malv...@oracle.com wrote:
osaf/services/saf/amf/amfd/apptype.cc | 2 +-
osaf/services/saf/amf/amfd/include/sgtype.h | 4 +-
osaf/services/saf/amf/amfd/sg.cc| 12 +-
ack, code review only/Thanks HansN
-Original Message-
From: praveen malviya [mailto:praveen.malv...@oracle.com]
Sent: den 4 juni 2014 14:17
To: Hans Nordebäck
Cc: Hans Feldt; nagendr...@oracle.com; opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 01 of 12] amfd : use db_template
Is it ok to push these two patches?/Regards HansN
-Original Message-
From: Hans Feldt
Sent: den 4 juni 2014 13:44
To: Hans Nordebäck; praveen.malv...@oracle.com; nagendr...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 2 of 2] amfd: use simple encode in App
if name Is changed to std::string or a conversion operator is added to SaNameT
it can be removed. /HansN
-Original Message-
From: Hans Feldt
Sent: den 3 juni 2014 08:19
To: Hans Nordebäck; nagendr...@oracle.com; praveen.malv...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject
Hi, see inline. /Regards HansN
On 05/28/14 12:18, Hans Feldt wrote:
See inline and please comment.
/HansF
-Original Message-
From: Nagendra Kumar [mailto:nagendr...@oracle.com]
Sent: den 28 maj 2014 12:13
To: Hans Nordebäck; Hans Feldt; Praveen Malviya
Cc: opensaf-devel
Hi Nagu, do you mean I should push this patch without updating dependent/broken
code? /Regrads HansN
-Original Message-
From: Nagendra Kumar [mailto:nagendr...@oracle.com]
Sent: den 28 maj 2014 13:09
To: Hans Nordebäck; Praveen Malviya
Cc: Hans Feldt; opensaf-devel
:58
To: Hans Feldt; Hans Nordebäck
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 1 of 1] amfd: fix SU constructor [#713]
Can you please share the advantage for using 'explicit' here:
+ explicit AVD_SU(const SaNameT *dn);
Thanks
-Nagu
-Original Message-
From
ack, two minor comments:
1. specify the initializers in declaration order, (thats how they get
called).
2. if, as also IngvarB pointed out, SaNameT contained a default
constructor initializing its length to 0, it don't need to be initialized in
the class. I have already sent out a patch for
-Original Message-
From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com]
Sent: 28 May 2014 16:39
To: Nagendra Kumar; Hans Feldt
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 1 of 1] amfd: fix SU constructor [#713]
Hi Nagu, I think it is good practice to use
Ack, tested/Regards HansN
On 05/23/14 08:43, nagendr...@oracle.com wrote:
osaf/services/saf/amf/amfd/node.cc | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
When Act controller is stopped, newly act controller is not sending node oper
state
disable notification.
Ack, code review only./Regards HansN
On 05/23/14 11:15, praveen.malv...@oracle.com wrote:
osaf/services/saf/amf/amfd/include/si.h | 4 +--
osaf/services/saf/amf/amfd/si.cc | 1 -
osaf/services/saf/amf/amfd/svctypecstypes.cc | 40
+++
3 files
ack, /Regards Hans
On 05/22/14 10:31, praveen.malv...@oracle.com wrote:
osaf/services/saf/amf/amfd/su.cc | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
SIs are not assigned to SU when SU was unlocked.
AMFD checks su-saAmfSUNumCurrActiveSIs and assigns SIs if its value is less
...@oracle.com [mailto:nagendr...@oracle.com]
Sent: den 21 maj 2014 12:00
To: Hans Feldt; Hans Nordebäck; praveen.malv...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd: replace patricia tree with stl::maps in
nodegroup [#713]
osaf/services/saf/amf/amfd
ack, code review only/Regards HansN
On 05/02/14 15:01, Hans Feldt wrote:
osaf/services/saf/amf/amfd/include/su.h | 22 +++-
osaf/services/saf/amf/amfd/su.cc| 80
+++-
2 files changed, 46 insertions(+), 56 deletions(-)
diff --git
2014 07:01
To: nagendr...@oracle.com; praveen.malv...@oracle.com; Hans Nordebäck
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 7 of 7] amfd: add and use SU is_in_service [#713]
osaf/services/saf/amf/amfd/include/su.h | 9 +
osaf/services/saf/amf/amfd/node.cc | 4 +---
osaf
ack, code review only, one comment:
in su.h the struct keyword is redundant and can be removed:
avd_avnd_tag *get_node_ptr(void);
/Regards HansN
On 04/30/14 07:01, Hans Feldt wrote:
osaf/services/saf/amf/amfd/comp.cc | 4 ++--
osaf/services/saf/amf/amfd/include/su.h |
ack, code review only/Regards HansN
On 04/30/14 07:01, Hans Feldt wrote:
osaf/services/saf/amf/amfd/include/su.h | 6 +-
osaf/services/saf/amf/amfd/role.cc | 2 +-
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 30 --
osaf/services/saf/amf/amfd/su.cc
ack, only code review, one comment shouldn't copy and assignment
operators be disabled? I.e. declare them private, or use google style
DISALLOW_COPY_AND_ASSIGN(AVD_SU);
/Regards HansN
On 04/30/14 07:01, Hans Feldt wrote:
osaf/services/saf/amf/amfd/include/su.h | 17 +--
ack, code review only/Regards HansN
On 04/30/14 07:01, Hans Feldt wrote:
osaf/services/saf/amf/amfd/clm.cc | 2 +-
osaf/services/saf/amf/amfd/include/su.h | 6 +-
osaf/services/saf/amf/amfd/node.cc | 2 +-
osaf/services/saf/amf/amfd/sg.cc| 5 ++---
ack, code review only, but remove void from members with empty
parameters./Regards HansN
On 04/30/14 07:01, Hans Feldt wrote:
osaf/services/saf/amf/amfd/include/su.h | 8 +++---
osaf/services/saf/amf/amfd/siass.cc | 29 -
osaf/services/saf/amf/amfd/su.cc|
ack, code review only/BR HansN
On 04/22/14 12:58, Hans Feldt wrote:
osaf/services/saf/amf/amfd/ckpt_dec.cc | 28 +
osaf/services/saf/amf/amfd/ckpt_updt.cc | 1 -
osaf/services/saf/amf/amfd/include/su.h | 38 +
Hi, is it ok to push this and the app patch now? I sent out the app patch V4
last week./Regards HansN
-Original Message-
From: Nagendra Kumar [mailto:nagendr...@oracle.com]
Sent: den 11 april 2014 15:10
To: Hans Nordebäck; Hans Feldt; Praveen Malviya
Cc: opensaf-devel
ack, but the method should be named:
void set_readiness_state(SaAmfReadinessStateT readiness_state);
/BR HansN
On 04/10/14 14:53, Hans Feldt wrote:
osaf/services/saf/amf/amfd/include/su.h | 2 +-
osaf/services/saf/amf/amfd/node.cc| 4 +-
ack, a few comments:
ndproc.cc:730
su-oper_state_set(static_castSaAmfOperationalStateT(l_val)); can be
changed to su-oper_state_set(l_val);
and overload oper_state_set in su.hh:
void oper_state_set(uint32_t state);
su.cc
void AVD_SU::oper_state_set(uint32_t oper_state) {
ok, I'll push it now, is it ok to also push the app db patch?/BR HansN
-Original Message-
From: Nagendra Kumar [mailto:nagendr...@oracle.com]
Sent: den 11 april 2014 13:16
To: Hans Nordebäck; Hans Feldt; Praveen Malviya
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1 of 1
Hi, use ULL, e.g 0x123ULL for the constant. Or use UINT64_C(0x123) from
stdint.h/BR HansN
-Original Message-
From: Zoran Milinkovic [mailto:zoran.milinko...@ericsson.com]
Sent: den 8 april 2014 10:46
To: reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject:
Message-
From: Zoran Milinkovic
Sent: den 4 april 2014 15:48
To: praveen malviya; Hans Nordebäck
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 1 of 1] amfd: use template class db to replace
patricia tree db V2 [#713]
+ typename AmfDbMap::iterator it = db.find(name
validations and asserts are not the same thing. Asserts normally logs a message
and aborts and may be compiled away. /BR HansN
-Original Message-
From: Anders Widell
Sent: den 4 april 2014 16:39
To: Hans Nordebäck; Nagendra Kumar; Hans Feldt; Praveen Malviya
Cc: opensaf-devel
ack, code review only. /Rgds. HansN
-Original Message-
From: Hans Feldt [mailto:osafde...@gmail.com]
Sent: den 2 april 2014 07:03
To: Hans Nordebäck
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 3] amfd: remove cast from avd_class_impl_set [#713]
osaf/services/saf/amf
ack, code review only/Rgds. HansN
On 04/02/14 07:02, Hans Feldt wrote:
osaf/services/saf/amf/amfd/comp.cc | 23
osaf/services/saf/amf/amfd/imm.cc| 44
+++
osaf/services/saf/amf/amfd/include/imm.h | 2 +-
Hi Praveen, any update on this?/BR HansN
-Original Message-
From: Hans Nordebäck
Sent: den 11 februari 2014 09:32
To: 'praveen malviya'
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1 of 1] amfd: use bool instead of SaBoolT V3 [#713]
Hi Praveen, Review Request for amf
Ack, I'll push the patch./HansN
-Original Message-
From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com]
Sent: den 12 mars 2014 17:46
To: Carl Johannesson
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1 of 1] pyosaf: Add support for extended Ckpt api
[#802]
Hi
Hi Carl, only code review, one question, the change of
ckptdll.saCkptIOVectorElementDataFree second argument from BYREF to
SaVoidPtr makes this
change not backward compatible, right? /BR HansN
On 03/03/14 14:57, Carl Johannesson wrote:
python/pyosaf/saCkpt.py | 170
2014 14:46
To: Hans Feldt; Hans Nordebäck; nagendr...@oracle.com; Gary Lee
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] AMFND: errors reported by valgrind [#716]
osaf/services/saf/amf/amfnd/amfnd.cc|4 +-
osaf/services/saf/amf/amfnd/cbq.cc |4
ack with one comment, why use a pointer ,static AmfAppMap *db instead of
static AmfAppMap db, then new (delete) is not needed?/BR HansN
On 01/15/14 09:11, Hans Feldt wrote:
osaf/services/saf/amf/amfd/app.cc| 95
++-
:
AmfAppMap db;
};
/BR Hans
On 01/15/14 13:56, Hans Feldt wrote:
-Original Message-
From: Hans Nordebäck
Sent: den 15 januari 2014 12:27
To: Hans Feldt
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1 of 1] amfd: use stl::map in app [#713]
ack with one comment, why use
Hi Nagu, this patch is the same change I provided temporarily internally
a couple of weeks ago. It was verified to work. Do you think we need
additional testing? /BR HansN
On 01/15/14 13:02, nagendr...@oracle.com wrote:
osaf/services/saf/amf/amfd/sgproc.cc | 1 +
1 files changed, 1
as and alternative to use a global g_app_db you can use a class, e.g.:
h file:
class AmfApplicationDb {
public:
static ApplicationMap application_map_db;
static void add(AmfApplication* application);
:
};
cc file:
ApplicationMap AmfApplicationDb::application_map_db;
void
Ack, (only code review)/BR HansN
On 01/13/14 08:30, Gary Lee wrote:
osaf/services/saf/amf/amfd/csi.cc | 25 -
osaf/services/saf/amf/amfd/include/sg.h | 1 -
osaf/services/saf/amf/amfd/sgtype.cc| 3 ++-
osaf/services/saf/amf/amfd/si.cc| 27
But why are not avnd_stop_tmr not updated as avnd_start_tmr?/BR HansN
-Original Message-
From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com]
Sent: den 13 januari 2014 13:09
To: Hans Feldt
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1 of 2] amfnd: remove
great, I'll check this. Yes it is important that it works for osaf
distributions. /Regards HansN
Från: Anders Widell
Skickat: den 20 december 2013 11:00
Till: Hans Nordebäck; mathi.naic...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Ämne: Re: [PATCH
ack, (not tested)/BR HansN
On 11/25/13 16:12, nagendr...@oracle.com wrote:
Summary: amfd: Decrement num_attributes when last attrValue is deleted [#302]
Review request for Trac Ticket(s): #302
Peer Reviewer(s): Hans F, Hans N
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected
ack, (not tested)/BR HansN
On 11/22/13 12:10, nagendr...@oracle.com wrote:
osaf/libs/agents/saf/amfa/ava_api.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/osaf/libs/agents/saf/amfa/ava_api.c
b/osaf/libs/agents/saf/amfa/ava_api.c
---
Hi Nagu, I have problem applying the patch, is it for opensaf-4.3.x branch?
Which changeset? /BR HansN
-Original Message-
From: Nagendra Kumar [mailto:nagendr...@oracle.com]
Sent: den 20 november 2013 11:05
To: Hans Feldt; Hans Nordebäck
Cc: opensaf-devel@lists.sourceforge.net
Subject
ack/BR HansN
On 11/19/13 11:36, Nagendra Kumar wrote:
Would like to push it as soon as possible. Comments ??
Thanks
-Nagu
-Original Message-
From: Nagendra Kumar
Sent: 15 November 2013 12:34
To: hans.fe...@ericsson.com; hans.nordeb...@ericsson.com
Cc:
Hi Carl, the IMM_A_01_01 should be removed and some whitespace issues to be
fixed, e.g. at line 576. Otherwise it looked ok/BR HansN
-Original Message-
From: Carl Johannesson
Sent: den 18 november 2013 11:14
To: Hans Nordebäck
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1
ack, with one comment, the BYREF for attrValues has to be kept, I'll change
that and push the change. /BR Hans
-Original Message-
From: Carl Johannesson
Sent: den 6 november 2013 10:59
To: Hans Nordebäck
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] immoi/pyosaf: Fix
Hi Hans, thanks, see comments below/BR HansN
-Original Message-
From: Hans Feldt [mailto:osafde...@gmail.com]
Sent: den 23 oktober 2013 08:46
To: Hans Nordebäck
Cc: Hans Feldt; praveen malviya; nagendr...@oracle.com;
opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 0 of 1
501 - 600 of 607 matches
Mail list logo
