When PBE loses connection with IMMND, we don't call exit() in IMM library.
Instead, we mark the handle as exposed and then PBE will exit when it fails to
call saImmOmDispatch.
---
src/imm/agent/imma_db.cc | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git
n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision bc497981905f39aaa5b63cdf85b7557972650d94
Author: Hung Nguyen &
n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision 83fefdd98edcc47d82eb8a59f32145f40ad0fb30
Author: Hung Nguyen &
Hi Zoran,
I fixed that when pushing the patch.
Thanks,
Hung Nguyen - DEK Technologies
From: Zoran Milinkovic zoran.milinko...@ericsson.com
Sent: Friday, September 15, 2017 3:30PM
To: Hung Nguyen
hung.d.ngu
Hi Zoran,
Reviewed and tested the patch.
Ack from me.
BR,
Hung Nguyen - DEK Technologies
From: Zoran Milinkovic zoran.milinko...@ericsson.com
Sent: Monday, September 11, 2017 10:53PM
To: Hung Nguyen
When object is in a critical CCB and has no admo,
ERR_TRY_AGAIN will be returned if setting a new admo name to the object.
If setting a different admo name, ERR_EXIST will be returned as stated in IMM
specification.
---
src/imm/immnd/ImmModel.cc | 10 --
1 file changed, 8 insertions(+),
aa47a332e3
Author: Hung Nguyen <hung.d.ngu...@dektech.com.au>
Date: Thu, 14 Sep 2017 11:26:16 +0700
imm: Don't allow setting new admo name when object is in a critical CCB [#2576]
When object is in a critical CCB and has no admo,
ERR_TRY_AGAIN will be returned if setting a new admo na
Hi Anders,
Thanks for the comments.
I agree with you about that, that would be safer.
I will send new solution to review.
BR,
Hung Nguyen - DEK Technologies
From: Anders Bjornerstedt anders.bjornerst
Value of admo name in the after image may not be correct in some cases,
but value of admo name in the before image (in sObjectMap) is always up to date.
We should keep the admo name value of the before image when committing
modification.
---
src/imm/immnd/ImmModel.cc | 22 +++---
OpenSAF servicesn
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision 4557812c01ecea474b8f9d0fece36dca6976537a
Author: H
Regenerate PBE on SQLITE_CORRUPT and SQLITE_MISMATCH.
---
src/imm/common/immpbe_dump.cc | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/imm/common/immpbe_dump.cc b/src/imm/common/immpbe_dump.cc
index 3d7c57e..11af674 100644
--- a/src/imm/common/immpbe_dump.cc
+++
revision c6c765dee4002fa467cbd68ba6e30ddcaacc
Author: Hung Nguyen <hung.d.ngu...@dektech.com.au>
Date: Wed, 6 Sep 2017 17:10:47 +0700
imm: Validate input invocation for saImmOiAdminOperationResult [#2571]
Add new set to IMMA_CLIENT_NODE to store the invocations.
The invocation is
Hi Zoran,
Reviewed and tested the patch.
Ack from me.
BR,
Hung Nguyen - DEK Technologies
From: Zoran Milinkovic zoran.milinko...@ericsson.com
Sent: Monday, August 14, 2017 7:38PM
To: Mahesh Valla
mahesh.va
Hi Zoran,
Reviewed and tested the patch.
Ack from me.
BR,
Hung Nguyen - DEK Technologies
From: Zoran Milinkovic zoran.milinko...@ericsson.com
Sent: Monday, August 07, 2017 10:03PM
To: Mahesh Valla
mahesh.va
Hi Zoran,
Reviewed and tested the patch.
Ack from me.
BR,
Hung Nguyen - DEK Technologies
From: Zoran Milinkovic zoran.milinko...@ericsson.com
Sent: Wednesday, August 09, 2017 6:44PM
To: Mahesh Valla
Hi Zoran,
Reviewed and tested the patch.
Ack from me.
BR,
Hung Nguyen - DEK Technologies
From: Zoran Milinkovic zoran.milinko...@ericsson.com
Sent: Wednesday, June 28, 2017 9:02PM
To: Mahesh Valla
mahesh.va
,
Hung Nguyen - DEK Technologies
From: Mahesh Valla mahesh.va...@oracle.com
Sent: Thursday, June 15, 2017 1:05PM
To: Hung Nguyen, Zoran Milinkovic
hung.d.ngu...@dektech.com.au, zoran.milinko...@ericsson.com
Cc: Opensaf
anyway,
so the mIsStale flag must be unset to make sure that it's able to discard the
stale client.
BR,
Hung Nguyen - DEK Technologies
From: Mahesh Valla mahesh.va...@oracle.com
Sent: Thursday, June 15, 2017 10:48AM
Hi Zoran,
Reviewed and tested the patch.
Ack from me.
BR,
Hung Nguyen - DEK Technologies
From: Zoran Milinkovic zoran.milinko...@ericsson.com
Sent: Wednesday, June 14, 2017 4:33PM
To: Mahesh Valla
mahesh.va
Just like immnd_proc_imma_discard_stales(), in immnd_proc_discard_other_nodes()
we should unset the mIsStale flag of the clients.
So that the clients can be discarded.
---
src/imm/immnd/immnd_proc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/imm/immnd/immnd_proc.c
aeaec08763
Author: Hung Nguyen <hung.d.ngu...@dektech.com.au>
Date: Fri, 9 Jun 2017 13:21:33 +0700
imm: Allow stale clients to be discarded when going to headless [#2487]
Just like immnd_proc_imma_discard_stales(), in immnd_proc_discard_other_nodes()
we should unset the mIsStale flag of
Hi Mahesh,
Because the longDn testsuite use the same implementer for the testcases and the
other testsuites don't.
So we don't have this problem in other testsuites.
BR,
Hung Nguyen - DEK Technologies
From
d0cf938cca
Author: Hung Nguyen <hung.d.ngu...@dektech.com.au>
Date: Tue, 6 Jun 2017 14:27:48 +0700
immtest: Explicitly clear implementer name in OI long DN testcases [#2484]
Explicitly clear implementer name in OI long DN testcases.
Complete diffstat:
--
src/imm/api
Explicitly clear implementer name in OI long DN testcases.
---
src/imm/apitest/implementer/test_saImmOiLongDn.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/imm/apitest/implementer/test_saImmOiLongDn.c
b/src/imm/apitest/implementer/test_saImmOiLongDn.c
index d3912c1..210c7c4
Hi Zoran,
Reviewed and tested the patch.
Ack from me.
BR,
Hung Nguyen - DEK Technologies
From: Zoran Milinkovic zoran.milinko...@ericsson.com
Sent: Friday, June 02, 2017 10:15PM
To: Mahesh Valla
mahesh.va
In immnd_evt_proc_search_next(), before jumping to agent_rsp, mLastResult must
be cleared.
So that it will not be freed again in immnd_proc_imma_discard_connection().
---
src/imm/immnd/immnd_evt.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/imm/immnd/immnd_evt.c
Hi Zoran,
Reviewed the patch.
Ack from me.
BR,
Hung Nguyen - DEK Technologies
From: Zoran Milinkovic zoran.milinko...@ericsson.com
Sent: Friday, May 19, 2017 7:43PM
To: Neelakanta Reddy
reddy.neelaka
Hi Zoran,
I fixed that while pushing.
Thanks,
Hung Nguyen - DEK Technologies
From: Zoran Milinkovic zoran.milinko...@ericsson.com
Sent: Friday, May 19, 2017 4:05PM
To: Hung Nguyen, Neelakanta Reddy
Hi Mahesh,
There's a lot of iterators in IMM code.
I think it's better to have a ticket to refactor them all, just like AMF.
Thanks,
Hung Nguyen - DEK Technologies
From: Mahesh Valla mahesh.va...@oracle.com
Sent
y
OpenSAF servicesn
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision 678cc8c0caa9ba2f817016b81bb3a388ede57e91
Au
During cold-sync, standby IMMD may receive info of dead IMMND.
Before switching to active, the IMMD should clear those dead IMMND info.
---
src/imm/immd/immd_amf.c | 5 +
src/imm/immd/immd_cb.h | 2 +-
src/imm/immd/immd_db.c | 25 +++--
src/imm/immd/immd_evt.c | 3 +++
Discard Adm Impl continuation when peer IMMND is down.
---
src/imm/immnd/ImmModel.cc | 24
1 file changed, 24 insertions(+)
diff --git a/src/imm/immnd/ImmModel.cc b/src/imm/immnd/ImmModel.cc
index 56d8c8d..25f8621 100644
--- a/src/imm/immnd/ImmModel.cc
+++
y
OpenSAF servicesn
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision b4a0395df1aa13495db0c6434cfdb9e70cf0d9dc
Au
TYPE_IMMA;
(should be evt->info.objModify.ccbId)
I will fix them while pushing if there's no comments on the patch.
BR,
Hung Nguyen - DEK Technologies
--------
From: Hung Nguyen hung.d.ngu...@dektech.com.au
Sent: Tuesday,
Skip sending re-intro message if IMMD is not up.
---
src/imm/immnd/immnd_mds.c | 1 +
src/imm/immnd/immnd_proc.c | 6 ++
2 files changed, 7 insertions(+)
diff --git a/src/imm/immnd/immnd_mds.c b/src/imm/immnd/immnd_mds.c
index 76ba77a..dd5ca83 100644
--- a/src/imm/immnd/immnd_mds.c
+++
servicesn
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision dc78ad5ac8ee1a5c388e318e302dfb686ab39ccb
Author: H
Remove CcbErrStrings that are set only on nodes with OI/PBE.
Abort the CCB when those errors occur to avoid taking long time to abort the
CCB (due to timeout).
---
src/imm/immnd/immnd_evt.c | 68 ---
1 file changed, 17 insertions(+), 51 deletions(-)
28f9c9635e
Author: Hung Nguyen <hung.d.ngu...@dektech.com.au>
Date: Tue, 9 May 2017 14:44:40 +0700
imm: Remove CcbErrStrings that are set only on nodes with OI/PBE [#2446]
Remove CcbErrStrings that are set only on nodes with OI/PBE.
Abort the CCB when those errors occur to avoid taking lo
28f9c9635e
Author: Hung Nguyen <hung.d.ngu...@dektech.com.au>
Date: Tue, 9 May 2017 14:44:40 +0700
imm: Remove CcbErrStrings that are set only on nodes with OI/PBE [#2446]
Remove CcbErrStrings that are set only on nodes with OI/PBE.
Abort the CCB when those errors occur to avoid taking lo
Remove CcbErrStrings that are set only on nodes with OI/PBE.
Abort the CCB when those errors occur to avoid taking long time to abort the
CCB (due to timeout).
---
src/imm/immnd/immnd_evt.c | 68 ---
1 file changed, 17 insertions(+), 51 deletions(-)
Hi Zoran,
I will add the error when pushing.
Thanks,
Hung Nguyen - DEK Technologies
From: Zoran Milinkovic zoran.milinko...@ericsson.com
Sent: Friday, April 21, 2017 5:33PM
To: Hung Nguyen, Neelakanta Reddy
Add more details to no dangling CcbErrorString.
---
src/imm/immnd/ImmModel.cc | 50 +++
1 file changed, 50 insertions(+)
diff --git a/src/imm/immnd/ImmModel.cc b/src/imm/immnd/ImmModel.cc
index 35c8a31..7afce0f 100644
--- a/src/imm/immnd/ImmModel.cc
revision 431b8569974cb2cca055feaa90e05a41fcbe3f42
Author: Hung Nguyen <hung.d.ngu...@dektech.com.au>
Date: Fri, 21 Apr 2017 13:08:23 +0700
imm: Add more details to no dangling CcbErrorString [#2433]
Add more details to no dangling CcbErrorString.
Complete diffstat:
--
src/imm/immnd/
Hi Zoran,
I will fix that when pushing the patch.
Thanks,
Hung Nguyen - DEK Technologies
From: Zoran Milinkovic zoran.milinko...@ericsson.com
Sent: Tuesday, April 18, 2017 5:51PM
To: Hung Nguyen
hung.d.ngu
Add new 'isUp' flag to IMMD_IMMND_INFO_NODE.
If a new IMMND node is added during MDS UP event or intro message,
the flag is set to true.
If a new IMMND node is added during coldsync, the flag is set to false.
The flag will be set to true when MDS UP event comes.
---
src/imm/immd/immd_cb.h| 1
n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision c1a8fc00b68836a4043b2d3faa959730430741b2
Author: Hung Nguyen &
n
Other n
Comments (indicate scope for each "y" above):
-
changeset 65955917b1ceee59184013c4d9c2c510f81e8285
Author: Hung Nguyen <hung.d.ngu...@dektech.com.au>
Date: Tue, 11 Apr 2017 19:05:48 +0700
src/imm/immnd/immnd_evt.c | 7 ++-
src/imm/immnd/immnd_proc.c | 25 +
2 files changed, 27 insertions(+), 5 deletions(-)
Use waitpid with WNOHANG to check for sync process and pbe process.
The processes are checked before resending the intro message.
The intro
Hi Hieu,
Reviewed the patch.
Ack from me.
BR,
Hung Nguyen - DEK Technologies
From: Hieu Nguyen hieu.t.ngu...@dektech.com.au
Sent: Monday, April 03, 2017 12:25PM
To: Zoran Milinkovic, Neelakanta Reddy, Hung Nguyen
src/imm/agent/imma_mds.cc | 6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
Check if response is NULL when sending MDS sync message.
diff --git a/src/imm/agent/imma_mds.cc b/src/imm/agent/imma_mds.cc
--- a/src/imm/agent/imma_mds.cc
+++ b/src/imm/agent/imma_mds.cc
@@ -602,8 +602,12
Other n
Comments (indicate scope for each "y" above):
-
changeset 86dfbf17f37c0e569224afc00476e2e69e58f9fd
Author: Hung Nguyen <hung.d.ngu...@dektech.com.au>
Date: Mon, 03 Apr 2017 16:26:53 +0700
imm: C
Hi Neel,
Reviewed and tested the patch.
Ack from me.
BR,
Hung Nguyen - DEK Technologies
From: Neelakanta Reddy reddy.neelaka...@oracle.com
Sent: Monday, March 27, 2017 2:09PM
To: Zoran Milinkovic, Hung Nguyen
Hi Neel,
Reviewed and tested the patch.
Ack with a minor comment.
The mixed indentation should be fixed.
BR,
Hung Nguyen - DEK Technologies
From: Neelakanta Reddy reddy.neelaka...@oracle.com
Sent: Monday, March
Hi Neel,
Reviewed and tested the patch.
Ack from me.
BR,
Hung Nguyen - DEK Technologies
From: Neelakanta Reddy reddy.neelaka...@oracle.com
Sent: Tuesday, March 21, 2017 6:15PM
To: Zoran Milinkovic, Hung Nguyen
Hi Neel,
Reviewed and tested the patch.
Ack from me.
BR,
Hung Nguyen - DEK Technologies
From: Neelakanta Reddy reddy.neelaka...@oracle.com
Sent: Friday, March 17, 2017 4:28PM
To: Zoran Milinkovic, Hung Nguyen
Hi Neel,
Reviewed the patch.
Ack from me.
BR,
Hung Nguyen - DEK Technologies
From: Neelakanta Reddy reddy.neelaka...@oracle.com
Sent: Monday, March 20, 2017 4:35PM
To: Hung Nguyen, Zoran Milinkovic
Hi Zoran,
Reviewed the patch.
Ack from me.
BR,
Hung Nguyen - DEK Technologies
From: Zoran Milinkovic zoran.milinko...@ericsson.com
Sent: Tuesday, March 07, 2017 11:04PM
To: Neelakanta Reddy
reddy.neelaka
Hi Mahesh,
Reviewed and tested the patch.
Ack from me.
BR,
Hung Nguyen - DEK Technologies
From: Mahesh Valla mahesh.va...@oracle.com
Sent: Friday, March 03, 2017 12:42PM
To: Zoran Milinkovic, Hung Nguyen
Hi Neel,
Reviewed the patch.
Ack from me.
BR,
Hung Nguyen - DEK Technologies
From: Neelakanta Reddy reddy.neelaka...@oracle.com
Sent: Monday, March 06, 2017 5:33PM
To: Hung Nguyen, Zoran Milinkovic
Hi Neel,
Reviewed and tested the patch.
Ack from me.
BR,
Hung Nguyen - DEK Technologies
From: Neelakanta Reddy reddy.neelaka...@oracle.com
Sent: Friday, March 03, 2017 6:53PM
To: Hung Nguyen, Zoran Milinkovic
lize(immnd_cb->clm_hdl);
immnd_clm_node_cleanup(immnd_cb);
immnd_init_with_clm();
}
BR,
Hung Nguyen - DEK Technologies
From: Neelakanta Reddy reddy.neelaka...@oracle.com
Sent: Th
Hi Neel,
Reviewed the patches.
Ack from me.
BR,
Hung Nguyen - DEK Technologies
From: Neelakanta Reddy reddy.neelaka...@oracle.com
Sent: Monday, February 27, 2017 8:59PM
To: Hung Nguyen, Zoran Milinkovic
I understand it now.
Thanks,
Hung Nguyen - DEK Technologies
From: Neelakanta Reddy reddy.neelaka...@oracle.com
Sent: Monday, February 27, 2017 4:09PM
To: Zoran Milinkovic, Greg Hurlman
zoran.milinko
memset(cl_node, '\0',
sizeof(IMMND_IMM_CLIENT_NODE));
BR,
Hung Nguyen - DEK Technologies
From: Neelakanta Reddy reddy.neelaka...@oracle.com
Sent: Monday, February 20, 2017 6:15PM
To: Hung Ngu
Other n
Comments (indicate scope for each "y" above):
-
changeset d79e3d47468b927dd5b06f2efa869a63380fe3c4
Author: Hung Nguyen <hung.d.ngu...@dektech.com.au>
Date: Fri, 17 Feb 2017 15:03:49 +0700
imm:
src/imm/immnd/ImmModel.cc | 31 ++-
1 files changed, 18 insertions(+), 13 deletions(-)
If a client is down right before headless, chances are the implementers and
admowners will be orphaned because IMMD fails to broadcast global discard
messages.
This patch cleans
src/imm/immnd/immnd_evt.c | 35 ---
src/imm/immnd/immnd_proc.c | 22 ++
2 files changed, 34 insertions(+), 23 deletions(-)
When SC comes back too fast, it will fail to change to SEVER_READY state
because immnd_proc_server() is not
Hi Zoran,
I will fix the problem and send new patch for review.
Thanks,
Hung Nguyen - DEK Technologies
From: Zoran Milinkovic zoran.milinko...@ericsson.com
Sent: Friday, February 10, 2017 8:49PM
To: Hung Nguyen
n
Other n
Comments (indicate scope for each "y" above):
-
changeset 8383d6a84f2506c8adb5f28ffa6bcc382e1fac4f
Author: Hung Nguyen <hung.d.ngu...@dektech.com.au>
Date: Fri, 10 Feb 2017 14:06:22 +0700
src/imm/immnd/immnd_evt.c | 33 ++---
src/imm/immnd/immnd_proc.c | 22 ++
2 files changed, 32 insertions(+), 23 deletions(-)
When SC comes back too fast, it will fail to change to SEVER_READY state
because immnd_proc_server() is not executed.
Other n
Comments (indicate scope for each "y" above):
-
changeset a53394519920253567e2daeae956c0d7c2e64d7d
Author: Hung Nguyen <hung.d.ngu...@dektech.com.au>
Date: Mon, 06 Feb 2017 10:33:54 +0700
imm: Up
src/imm/README.NO_DANGLING | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
Update NO_DANGLING document with information about ATTR_DN.
diff --git a/src/imm/README.NO_DANGLING b/src/imm/README.NO_DANGLING
--- a/src/imm/README.NO_DANGLING
+++ b/src/imm/README.NO_DANGLING
@@ -9,7 +9,8
Thanks, Zoran.
I will create a ticket to update the document.
BR,
Hung Nguyen - DEK Technologies
From: Zoran Milinkovic zoran.milinko...@ericsson.com
Sent: Monday, January 23, 2017 8:00PM
To: Hung Nguyen
Other n
Comments (indicate scope for each "y" above):
-
changeset d5a580a0c1b2d7ce1e0f91feb4e3021b4c416731
Author: Hung Nguyen <hung.d.ngu...@dektech.com.au>
Date: Mon, 23 Jan 2017 14:52:21 +0700
imm: Ad
src/imm/immnd/ImmModel.cc | 94 ++-
1 files changed, 52 insertions(+), 42 deletions(-)
ImmModel::notCompatibleAtt()
Check for dangling values when adding NO_DANGLING flag to SaStringDN attributes.
ImmModel::ccbObjectModify()
Check for SaStringDN
src/imm/immnd/ImmModel.cc | 58 +-
1 files changed, 32 insertions(+), 26 deletions(-)
The mismatch only happens in ::ccbObjectCreate(), ::ccbObjectModify(),
::deleteObject().
The changes in other functions are to make sure that we handle
n
Comments (indicate scope for each "y" above):
-
changeset d9e87a7b96bb0e2142bafb31032a5d47a43c2f0b
Author: Hung Nguyen <hung.d.ngu...@dektech.com.au>
Date: Thu, 19 Jan 2017 18:12:52 +0700
imm: Fix the mismatc
src/imm/agent/imma_om_api.cc | 147 --
1 files changed, 69 insertions(+), 78 deletions(-)
Remove unused variables from saImmOmClassCreate_2().
diff --git a/src/imm/agent/imma_om_api.cc b/src/imm/agent/imma_om_api.cc
--- a/src/imm/agent/imma_om_api.cc
n
Comments (indicate scope for each "y" above):
-
changeset 43276ece820633e155df5c105ae7fb82a34ab17c
Author: Hung Nguyen <hung.d.ngu...@dektech.com.au>
Date: Thu, 19 Jan 2017 14:05:31 +0700
imm: Remove unuse
src/imm/Makefile.am | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Add imm_common to LIBADD list of libSaImmOi.
diff --git a/src/imm/Makefile.am b/src/imm/Makefile.am
--- a/src/imm/Makefile.am
+++ b/src/imm/Makefile.am
@@ -106,6 +106,7 @@ lib_libSaImmOi_la_LDFLAGS += \
Hi Zoran,
Reviewed and tested the patch.
Ack from me.
BR,
Hung Nguyen - DEK Technologies
From: Zoran Milinkovic zoran.milinko...@ericsson.com
Sent: Saturday, January 14, 2017 9:04PM
To: Neelakanta Reddy
t;mPbeDisableCritical = true;
}
BR,
Hung Nguyen - DEK Technologies
From: Neelakanta Reddy reddy.neelaka...@oracle.com
Sent: Friday, December 30, 2016 2:02PM
To: Hung Nguyen, Zoran Milinkovic
hung.d.ngu...@d
Hi Neel,
Please find my comments inline.
BR,
Hung Nguyen - DEK Technologies
From: Neelakanta Reddy reddy.neelaka...@oracle.com
Sent: Thursday, December 22, 2016 4:44PM
To: Zoran Milinkovic, Hung Nguyen
osaf/services/saf/immsv/immnd/ImmModel.cc | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Fix memory leak when clearing sDeferredObjUpdatesMap.
diff --git a/osaf/services/saf/immsv/immnd/ImmModel.cc
b/osaf/services/saf/immsv/immnd/ImmModel.cc
---
Hi Zoran,
In my repository, that 'immOmIsLoader' variable already has the type of bool.
(default branch)
Can you check if your repository is up to date?
Thanks,
Hung Nguyen - DEK Technologies
From: Zoran
osaf/libs/agents/saf/imma/imma_om_api.cc | 4 ++--
osaf/libs/common/immsv/include/immsv_evt_model.h | 6 +++---
osaf/services/saf/immsv/immnd/ImmModel.cc| 4 ++--
3 files changed, 7 insertions(+), 7 deletions(-)
SaBoolT can be replaced by bool in message type because that
Comments (indicate scope for each "y" above):
-
changeset 3669eff495ef0fed0d22273c63c7a3d66cf58b94
Author: Hung Nguyen <hung.d.ngu...@dektech.com.au>
Date: Tue, 20 Dec 2016 13:18:41 +0700
imm: Remove use of SaBoolT from mes
osaf/services/saf/immsv/immnd/ImmModel.cc| 182 -
osaf/services/saf/immsv/immnd/ImmModel.hh|4 +-
osaf/services/saf/immsv/immnd/ImmSearchOp.cc |6 +-
osaf/services/saf/immsv/immnd/ImmSearchOp.hh |2 +-
osaf/services/saf/immsv/immnd/immnd_evt.c| 486
osaf/tools/safimm/immcfg/imm_cfg.c | 12 ++--
osaf/tools/safimm/src/immutil.c | 4 +-
samples/immsv/immutils/immutil.c| 4 +-
tests/immsv/implementer/test_SaImmOiAdminOperation.c| 30 ++--
scope for each "y" above):
-
changeset 03a077ba8a5acf92d5d068f4db327722dd213af2
Author: Hung Nguyen <hung.d.ngu...@dektech.com.au>
Date: Tue, 13 Dec 2016 09:40:26 +0700
imm: Remove use of SaBoolT from library [#2225]
osaf/libs/agents/saf/imma/imma_oi_api.cc | 6 ++--
osaf/libs/agents/saf/imma/imma_om_api.cc | 48
2 files changed, 27 insertions(+), 27 deletions(-)
imm: Remove use of SaBoolT from library.
diff --git a/osaf/libs/agents/saf/imma/imma_oi_api.cc
scope for each "y" above):
-
changeset 421945c108b10cfabda659cb5412fc1d482ee371
Author: Hung Nguyen <hung.d.ngu...@dektech.com.au>
Date: Tue, 13 Dec 2016 13:40:11 +0700
imm: Remove use of SaBoolT from IMM tools and tests [#22
osaf/tools/safimm/immcfg/imm_cfg.c | 12 ++--
osaf/tools/safimm/src/immutil.c | 4 +-
samples/immsv/immutils/immutil.c| 4 +-
tests/immsv/implementer/test_SaImmOiAdminOperation.c| 30 ++--
(indicate scope for each "y" above):
-
changeset 5bc30a78e98beb7d491f4f3e878cd070e608d54c
Author: Hung Nguyen <hung.d.ngu...@dektech.com.au>
Date: Mon, 12 Dec 2016 18:02:56 +0700
imm: Use return from map::erase() to avoid re
osaf/services/saf/immsv/immnd/ImmModel.cc | 74 ++
1 files changed, 43 insertions(+), 31 deletions(-)
When removing all elements from a map, iterate through the map to free each
element and then use clear() to clear the map.
diff --git
Hi Zoran,
Reviewed and tested the patch.
Ack from me.
BR,
Hung Nguyen - DEK Technologies
From: Zoran Milinkovic zoran.milinko...@ericsson.com
Sent: Thursday, December 08, 2016 8:33PM
To: Neelakanta Reddy
Hi Neel,
Reviewed and tested the patch.
Ack from me.
BR,
Hung Nguyen - DEK Technologies
From: Neelakanta Reddy reddy.neelaka...@oracle.com
Sent: Tuesday, December 06, 2016 6:11PM
To: Hung Nguyen, Zoran Milinkovic
k type is
IMMA_CALLBACK_PBE_PRT_OBJ_CREATE.
It goes to the default of the switch statement in imma_proc_ccbaug_setup().
In imma_oi_ccb_record_note_callback(), with NULL callback,
callback->attrValsForCreateUc is not populated.
Attached is the coredump backtrace.
BR,
Hung Nguyen - DEK Tec
Hi Neel,
I agree with your comments.
Please send new patch for review since there are many fixes.
Thanks,
Hung Nguyen - DEK Technologies
From: Neelakanta Reddy reddy.neelaka...@oracle.com
Sent: Thursday, December
Hi Neel,
Besides Zoran's comment, I have 2 more comments inline.
BR,
Hung Nguyen - DEK Technologies
From: Neelakanta Reddy reddy.neelaka...@oracle.com
Sent: Wednesday, November 30, 2016 12:39PM
To: Zoran
1 - 100 of 450 matches
Mail list logo
