Hi Hans,
Thanks for your very helpful comments. I will fix them before pushing it.
Best regards,
Long Nguyen.
On 11/20/2017 7:54 PM, Hans Nordebäck wrote:
Hi,
ack with some comments below. /Thanks HansN
On 11/10/2017 08:52 AM, Long H Buu Nguyen wrote:
---
python/README_UTILS | 215
Hi Quyen,
Thanks for your comments.
I will fix and send a new patch.
Best regards,
Long Nguyen.
On 10/27/2017 2:12 PM, Quyen Dao wrote:
Hi Long,
Please help fix the below pylint issue and find minor comments marked
with [Quyen].
* Module pyosaf.utils
C:211,26: Using type
Hi Praveen,
I have sent the patch modified by you for other maintainers to review.
Thanks so much,
Long Nguyen.
On 5/17/2017 10:58 AM, Long Nguyen wrote:
> Hi Praveen,
>
> Thanks for your idea.
> Yes, your are right. It is better to move the check to the event
> handler of
Hi Praveen,
Thanks for your idea.
Yes, your are right. It is better to move the check to the event handler
of presence state message.
Best regards,
Long Nguyen.
On 5/16/2017 12:54 PM, praveen malviya wrote:
> Hi Long,
>
> This check is very generic.
> During su restart cases, a
Dear maintainers,
Can you please help to review the patch?
Thanks so much,
Long Nguyen.
On 5/9/2017 9:29 AM, Long Nguyen wrote:
> Hi,
>
> Have you had time to look into the patch?
>
> Best regards,
> Long Nguyen.
>
> On 4/28/2017 11:12 AM, Long H Buu Nguyen wrot
Hi,
Have you had time to look into the patch?
Best regards,
Long Nguyen.
On 4/28/2017 11:12 AM, Long H Buu Nguyen wrote:
> Summary: amf: send oper_state when NCS SUs already instantiated [#2443]
> Review request for Ticket(s): 2443
> Peer Reviewer(s): AMF devs
> Pull request to: AMF
si->invocation, SA_AIS_OK);
> *si->invocation = 0;*
> }
> }
So, the invocation here is reset.
Best regards,
Long Nguyen.
On 11/17/2016 4:15 PM, praveen malviya wrote:
> Hi Long,
>
> As per ticket, issue occurred during si-swap.
> Pleas
Hi Praveen,
I have tested with the patch for #2112. With the patch for #2112, I am
not able to reproduce the problem anymore.
I think we can ignore this ticket.
Thanks so much,
Long Nguyen.
On 11/10/2016 11:23 AM, Long Nguyen wrote:
> Hi Praveen,
>
> Thanks for your information. I wil
Hi Praveen,
Thanks for your information. I will recheck it.
Best regards,
Long Nguyen.
On 11/10/2016 11:18 AM, praveen malviya wrote:
> Hi,
> Thanks for the information.
> I think, like #2175, this issue may not occur after #2112 being
> pushed. Can you please recheck?
>
>
Hi Praveen,
Yes, I think the PL-6 was added after avd_node_config_get() is called so
SC-2 did not have the info about PL-6.
Best regards,
Long Nguyen.
On 11/8/2016 6:50 PM, praveen malviya wrote:
> Hi Long,
>
> I have gone through the traces from both the AMFDs. I think there is
Hi Praveen,
Very sorry. I somehow missed the mail. I have found your mail now.
Thanks so much.
Best regards,
Long Nguyen.
On 10/18/2016 2:01 PM, praveen malviya wrote:
> Hi Long,
>
> I had already acked it on 14th Oct.
>
>
> Thanks,
> Praveen
>
> On 18-Oct-16 12:28 P
Hi Praveen and Nagu,
Did you have a chance to look at the patch?
Best regards,
Long Nguyen.
On 10/10/2016 11:27 AM, Gary Lee wrote:
> Hi Long
>
> ack
>
> Thanks
>
>> On 10 Oct. 2016, at 3:26 pm, Long HB Nguyen <long.hb.ngu...@dektech.com.au>
>> wro
Thanks Praveen,
> Will this fix #1991 also?
No, it won't.
Best regards,
Long Nguyen.
On 9/6/2016 12:40 PM, praveen malviya wrote:
> Ack, code review only.
>
> Will this fix #1991 also?
>
> Thanks,
> Praveen
>
> On 05-Sep-16 5:46 PM, Long HB Nguyen wrote:
>>
Hi Praveen,
Do you have any comments for the PR?
/_Note:_/ I will remove the internal changes in amfd and amfnd later.
Best regards,
Long Nguyen.
On 8/23/2016 2:26 PM, Long Nguyen wrote:
> Summary: amf: update PR doc for long DN support [#1642]
> Review request for Trac Ticket(s): #1642
Hi Minh and Praveen,
I have just sent out the patch (amfa: fix memory leak in protection group).
Please help to review. Thanks so much.
Best regards,
Long Nguyen.
On 8/26/2016 12:47 PM, minh.c...@dektech.com.au wrote:
> Hi Praveen,
>
> Long is preparing the patch adding sentine
Thanks Praveen,
Actually, the PR doc only contains the implementation detail part in
readme file.
I will remove the internal amfd and amfnd changes in the PR doc.
Best regards,
Long Nguyen.
On 8/25/2016 11:42 AM, praveen malviya wrote:
> Ack.
>
> I think implementation details should
Hi Gary,
Ack (Tested).
Best regards,
Long Nguyen.
On 8/24/2016 10:47 AM, Gary Lee wrote:
> osaf/services/saf/amf/amfd/tests/test_amfdb.cc| 2 +-
> osaf/services/saf/amf/amfd/tests/test_ckpt_enc_dec.cc | 46
> +++---
> 2 files changed, 19 insertions(+),
Summary: amf: update PR doc for long DN support [#1642]
Review request for Trac Ticket(s): #1642
Peer Reviewer(s): AMF devs
Pull request to: AMF maintainers
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
Hi Praveen,
Please see my answers marked with [Long].
Best regards,
Long Nguyen.
On 8/19/2016 6:01 PM, praveen malviya wrote:
> Hi Long,
>
> I see one problem if B.01.01 application frees the memory in pg
> tracking callback.
> Please see inline.
>
> Thanks,
> Praveen
add a normal (short) csi instead?
Can you please share with us the scenario?
Best regards,
Long Nguyen.
On 8/16/2016 4:19 PM, praveen malviya wrote:
>
>
> On 15-Aug-16 5:05 PM, Long Nguyen wrote:
>> Hi Praveen,
>>
>> Thanks for your suggestions.
>> Please
Hi Praveen,
Thanks for your suggestions.
Please see my comments marked with [Long[.
Best regards,
Long Nguyen.
On 8/12/2016 5:03 PM, praveen malviya wrote:
>
>
> On 12-Aug-16 1:27 PM, Long Nguyen wrote:
>> Hi Praveen,
>>
>> Actually, since Anders introduced the extend
long names in this case?
Best regards,
Long Nguyen.
On 8/11/2016 3:04 PM, Long Nguyen wrote:
> Hi Praveen,
>
> Thanks for your suggestion.
> In the situation you described below, you add a csi dynamically (long
> DN) to an application (not support long DN).
> So, we only need t
Hi Praveen and others,
I have an idea marked with [Long] below.
Best regards,
Long Nguyen.
On 8/3/2016 1:45 PM, praveen malviya wrote:
>
>
> On 02-Aug-16 3:39 AM, minh chau wrote:
>> Hi Praveen,
>>
>> One comment with [Minh] in line.
>>
>> Thanks,
>>
Hi Praveen,
Thanks for your comments.
I will update the patch and send the V2 version.
Best regards,
Long Nguyen.
On 8/4/2016 4:55 PM, praveen malviya wrote:
> Please find some comments inline with [Praveen]
>
>
> Thanks,
> Praveen
>
> On 11-Jul-16 3:38 PM, Long HB Nguyen
Hi Praveen,
Thanks so much. I will change these #define in another ticket
(https://sourceforge.net/p/opensaf/tickets/1558/).
Best regards,
Long Nguyen.
On 10/22/2015 5:57 PM, praveen malviya wrote:
> Ack for the series.
>
> There are still some #defines like :
>
25 matches
Mail list logo
