Hi Thang,
I think it would be nice you can separate two commits, one for test, one for
gcc/g++ 10 code changes.
Thanks,
Minh
From: Thang Duc Nguyen
Sent: Wednesday, March 16, 2022 11:44 AM
To: Hieu Hong Hoang ; Thien Minh Huynh
; Minh Hon Chau
Cc: opensaf
Hi Thang
Ack from me
Thanks
Minh
Get Outlook for iOS<https://aka.ms/o0ukef>
From: Thang Duc Nguyen
Sent: Tuesday, November 10, 2020 7:58:04 PM
To: Minh Hon Chau ; Thuan Tran
Cc: opensaf-devel@lists.sourceforge.net ;
Thang Duc Nguyen
Subject: [PATCH 1/
Yes right, i was thinking of a 64bit value.
Get Outlook for iOS<https://aka.ms/o0ukef>
From: Thuan Tran
Sent: Monday, May 4, 2020 8:12:43 PM
To: Minh Hon Chau ; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] ntf: fix n
Hi Thuan,
I'm adding Thanh since he's looking at the patch as well.
I see you pushed the patch, here some late comments.
Thanks
Minh
On 9/3/20 4:49 pm, thuan.tran wrote:
- Active SC will reboot if arb time somehow has big gap b/w heartbeats
in watch takeover request. Active SC may still OK
Hi Thuan,
ack from me.
Thanks
Minh
On 9/3/20 5:08 pm, thuan.tran wrote:
- Split-brain recovery in headless enable, IMMND may expected restart.
If AMFND not wait IMMND restart but reinit CLM, CLM callback trigger,
clm_to_amf_node() is called then AMFND stuck in init IMM OM causes delay
Hi Thang,
ack (not tested), would be good if you can elaborate the commit message
to explain how/why the patch can fix coredump.
Thanks
Minh
On 20/2/20 5:27 pm, Thang Duc Nguyen wrote:
Amfnd need to exist in node in shutdown state and all
components terminated.
---
src/amf/amfnd/clc.cc |
Hi Thuan,
Ack from me.
Thanks
Minh
On 12/2/20 9:29 pm, thuan.tran wrote:
Agent enable flow control keep add new portid without remove.
Remove portid when svc count become zero then handle portid reset
properly, peer A may see portid reset (peer B) then peer B should
accept fseq(1) message
Hi aThanh,
ack from me.
Thanks
Minh
On 6/2/20 3:42 pm, Thanh Nguyen wrote:
In the trace record the time value is generated
after acquiring the mutex. The time accuracy is improved
when generated before seizing the mutext.
---
src/base/logtrace.cc| 2 +-
Thanh
-Original Message-
From: Minh Hon Chau [mailto:minh.c...@dektech.com.au]
Sent: Thursday, 6 February 2020 12:48 PM
To: Thanh Nguyen; peter.mcint...@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] dtm: improve time accuracy in a trace record [#3144]
Hi aTh
Hi aThanh,
The patch adds a new pair of CreateLogEntry/CreateLogEntryInternal with
one extra parameter. If the old one (within 3 parameters) is not being
used anywhere else, we can delete them.
Thanks
Minh
On 24/1/20 11:34 am, Thanh Nguyen wrote:
In the trace record the time value is
Hi Vu,
Ack(review).
Thanks,
Minh
Quoting Vu Minh Nguyen :
log agent did not protect the resource `unacked_invocations_ list` from
accessing by multiple threads, so caused segmentation fault.
This patch introduces a mutex in order to synchronize the access to that
common resource.
---
Hi Vu,
Don't you need to protect the list in ~LogClient()? And in
NotifyClientAboutLostInvocations(), does it need to protect before
'read' in the 'for' loop? Otherwise it's ack from me.
Thanks
Minh
On 6/1/20 2:15 pm, Vu Minh Nguyen wrote:
log agent did not protect the resource
Hi Thuan,
- We could give the patch title a bit more meanings than "fix ckpt 20
11..", for example, something as "Using timer to continue sending queued
message".
- And a few comments inline
Thanks
Minh
On 5/12/19 3:05 pm, thuan.tran wrote:
- In overflow, receive chunk ack may stuck in
Hi Thuan
One minor comment, we could separate this commit into one for code
change, one for test case.
@Vu, you have any comments?
Thanks
Minh
On 27/11/19 1:21 pm, thuan.tran wrote:
Summary: mds: not waste 1.5s in waiting dead Adest to send RSP [#3102]
Review request for Ticket(s): 3102
hi Thuan,
ack (review only).
Thanks
Minh
On 3/12/19 7:28 pm, thuan.tran wrote:
Aslo create wrapper of sendto() to retry if errno is ENOMEM/ENOBUFFS/EINTR.
And return for other errors, do not assert() cause coredump.
---
src/mds/mds_dt_tipc.c| 47 +++
Hi Vu, Thuan
Any comments on the patches.
Thanks
Minh
On 28/11/19 10:54 pm, Minh Chau wrote:
Summary: mds: Avoid message reallocation [#3089]
Review request for Ticket(s): 3089
Peer Reviewer(s): Thuan, Vu, Gary
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected
Hi Thang,
I assume you have tried and there is no way to reuse the current *state*
of su to prevent the lock-in op in this scenario, and this patch tested
ok with upgrade/downgrade. The down side of adding checkpoint is that we
will stick with it even then we find better solution later on,
Hi Thuan,
ack with comments.
Thanks
Minh
On 28/11/19 6:55 pm, thuan.tran wrote:
When overflow happens, mds with flow control enabled may keep
all messages in queue if it fails to send a message when receiving
Nack or ChunkAck since no more trigger come after that.
MDS flow control should
Hi Thuan,
We should free() the memory at the same function level where the memory
is allocated. The @buffer is passed to mdtm_sendto() could be from a
stack memory (as it is used to be before this patch).
Thanks
Minh
On 27/11/19 5:40 pm, Tran Thuan wrote:
Hi Minh,
Why not free() inside
But after all retries are still failed, we might need to terminate the
portid, which leads to a MDS DOWN event, but let's look at it later.
On 27/11/19 3:23 pm, Minh Hon Chau wrote:
Hi Thuan,
I'm thinking to retry 3 times with 100 ms in between, but you can
decide it. Also, we need to ensure
Hon Chau
Sent: Wednesday, November 27, 2019 10:30 AM
To: thuan.tran ; thang . d . nguyen
; 'Nguyen Minh Vu' ;
gary@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] mds: Fix mds flow control keep all messages in queue
[#3123]
Hi Thuan,
The TipcPortId:Send
Hi Thuan,
The TipcPortId:Send is also called at a few other places, do you think
it is good if we make a wrapper of TipcPortId::Send with a few retries
on failures, says TipcPortId::TryToSend(), and call TryToSend() instead
of Send()?
Thanks
Minh
On 27/11/19 1:26 pm, thuan.tran wrote:
Hi Vu, Thuan,
The patch misses the error cases and the kDisabled state. I rework for
the V2.
Thanks
Minh
On 25/11/19 6:44 pm, Nguyen Minh Vu wrote:
Hi Minh,
Ack with comments inline.
Regards, Vu
On 11/25/19 1:12 PM, Minh Chau wrote:
The patch avoids message reallocation if enable
Hi Thang,
Instead of adding is_presence_msg_processed, which requires a checkpoint
to standby, can we make it as a function (or might be *if* statement)
that utilizes the pres_state and term_state to (dis)allow the lock-in op?
Thanks
Minh
On 25/11/19 5:50 pm, thang.d.nguyen wrote:
AMFD
Hi Thuan
ack (review only)
Thanks
Minh
On 19/11/19 5:49 pm, thuan.tran wrote:
---
src/mds/apitest/mdstipc.h | 2 +-
src/mds/apitest/mdstipc_api.c | 134 +++--
src/mds/apitest/mdstipc_conf.c | 9 ++-
src/mds/mds_c_sndrcv.c | 1 +
Hi Thuan
ack from me.
Thanks
Minh
On 4/11/19 6:42 pm, thuan.tran wrote:
---
src/ntf/agent/ntfa_api.c | 29 +++--
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git a/src/ntf/agent/ntfa_api.c b/src/ntf/agent/ntfa_api.c
index 417c9d688..e89479bf6 100644
Hi Thuan
ack from me.
thanks
Minh
On 4/11/19 5:56 pm, thuan.tran wrote:
---
src/mds/mds_c_db.c | 1 +
src/mds/mds_c_sndrcv.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/mds/mds_c_db.c b/src/mds/mds_c_db.c
index 58f0e3aee..e1991517e 100644
---
% is FCTRL
protocol.
*Best Regards,*
*ThuanTr***
*From:*Minh Hon Chau
*Sent:* Thursday, November 14, 2019 4:28 PM
*To:* Tran Thuan ;
hans.nordeb...@ericsson.com; gary@dektech.com.au;
vu.m.ngu...@dektech.com.au
*Cc:* opensaf-devel@lists.sourceforge.net
*Subject:* Re: [PATCH 1/3] mds: D
Hi Thuan,
Are you happy with my reply?
Thanks
Minh
On 14/11/19 9:35 am, Minh Hon Chau wrote:
Hi Thuan,
Please see my reply inline.
Thanks
Minh
On 13/11/19 9:54 pm, Tran Thuan wrote:
Hi Minh,
See my comment inline.
Best Regards,
ThuanTr
-Original Message-
From: Minh Chau
Hi Thuan,
ack from me.
THanks
Minh
On 13/11/19 10:00 pm, thuan.tran wrote:
When overload happens, sender will wait for chunkAck to continue
sending more messages, it should send number of message equal chunkAck
size of receiver. If not, receiver don't receive enough messages to send
chunkAck
Hi Thuan,
Please see my reply inline.
Thanks
Minh
On 13/11/19 9:54 pm, Tran Thuan wrote:
Hi Minh,
See my comment inline.
Best Regards,
ThuanTr
-Original Message-
From: Minh Chau
Sent: Friday, November 8, 2019 5:33 PM
To: hans.nordeb...@ericsson.com; gary@dektech.com.au;
Hi Thuan,
Please see comment inline
Thanks
Minh
On 13/11/19 2:24 pm, Tran Thuan wrote:
Hi Minh,
Please check replies inline. Thanks.
Best Regards,
ThuanTr
-Original Message-
From: Minh Hon Chau
Sent: Wednesday, November 13, 2019 10:05 AM
To: Tran Thuan ; 'Nguyen Minh Vu'
; gary
Hi Thuan,
Please see comment inline.
Thanks
Minh
On 13/11/19 1:11 pm, Tran Thuan wrote:
Hi Minh,
Thanks for comments, please check my replies inline.
Best Regards,
ThuanTr
-Original Message-
From: Minh Hon Chau
Sent: Wednesday, November 13, 2019 7:47 AM
To: thuan.tran ; 'Nguyen
Hi,
Any comments on the patches? Otherwise I wish to push them in the next
day or two.
Thanks
Minh
On 8/11/19 9:33 pm, Minh Chau wrote:
Summary: mds: Distinguish protocol version of fragment [#3111]
Review request for Ticket(s): 3111
Peer Reviewer(s): Gary, Vu, Thuan
Pull request to: ***
Hi Thuan,
Some comments inline.
Thanks
Minh
On 12/11/19 5:04 pm, thuan.tran wrote:
When overload happens, sender will wait for chunkAck to continue
sending more messages, it should send number of message equal chunkAck
size of receiver. If not, receiver don't receive enough messages to send
Hi Vu,
Please find comments below.
Thanks
Minh
On 31/10/19 6:15 pm, Nguyen Minh Vu wrote:
Hi Minh,
Ack with minor comments.
Regards, Vu
On 10/31/19 11:55 AM, Minh Chau wrote:
Patch unsets MDS_TIPC_FCTRL_ENABLED, MDS_TIPC_FCTRL_ACKTIMEOUT,
and MDS_TIPC_FCTRL_ACKSIZE to prevent child
Hi Vu,
I think users will lose the value set in env var if users repeat
Init/Finalize/Init. I have sent out V2.
Thanks
Minh
On 31/10/19 2:33 pm, Nguyen Minh Vu wrote:
Hi Minh,
Ack with one question.
What happens if user does following sequence:
1) Init service handle
--> Have this env
Hi Vu,
ack from me.
Thanks
Minh
On 21/10/19 5:51 pm, Nguyen Minh Vu wrote:
Hi,
Any comments on this patch? I will push it by this week if no comments.
Regards, Vu
On 10/4/19 5:30 PM, Vu Minh Nguyen wrote:
Introducing a new option '--rotate' to rotate given logtrace stream(s).
This patch
: Minh Hon Chau
Sent: Wednesday, October 23, 2019 5:52 AM
To: Tran Thuan ; 'Nguyen Minh Vu'
; hans.nordeb...@ericsson.com;
gary@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] mds: not waste 1.5s in waiting Adest already
down to send response message [#3102]
Hi
Hi Thuan,
I wonder the patch would work in the same reproduced steps if the both
adests have subscribed each other more than 2 services. The svc_cnt will
be greater than 1 until it is the last service down event. I think
that's why mds has the database @subtn_results, in which each item is an
Hi Thuan,
1- Can you point out where is the mds code that waits for 1.5 seconds,
is it hard coded within 1.5 secs?
2- Is existing db (mds_c_db.c) in mds not enough so we need to introduce
adest_list? I think mds must have a memory of adest, perhaps in another
implicit form, so mds can
Hi Thuan,
The patch is acked and I pushed it.
The commit message may cause you a missundestanding, but in this context
it does not mention anything regarding to configuration, so I hope it's ok.
Another comment inline.
Thanks
Minh
On 21/10/19 1:56 pm, Tran Thuan wrote:
Hi Minh,
I
Hi,
The counters reset will be removed in ReceiveIntro().
Thanks
Minh
On 15/10/19 12:50 pm, Minh Chau wrote:
mds relies on data message sent from the peer to determine
whether the MDS_TIPC_FCTRL_ENABLED is set. The data message
may not be sent right after TIPC_PUBLISHED event, which can
s fix, will tx probation timer become redundant or
still useful in somehow?
Best Regards,
ThuanTr
-----Original Message-
From: Minh Hon Chau
Sent: Monday, October 14, 2019 1:01 PM
To: Tran Thuan ; hans.nordeb...@ericsson.com;
gary@dektech.com.au; vu.m.ngu...@dektech.com.au
Cc: opens
Hi Thuan,
If the chunkack is configured to send after a few data messages, then
the sender is not getting any chunkack for the first message from
receiver until chunkack timeout (which is also configurable to be a bit
larger value). Then, the probation timer would be timeout at sender.
The
Hi all,
What I guess from the ticket that it is a race condition between the mds
thread and main thread in ntfd. We normally get NCSDOWN callback from
mds, and send event to main thread to remove the client. But the mds
callback here comes in the middle of processing Initialize().
We have
Hi Thuan,
Please see comments inline.
Thanks
Minh
On 7/10/19 3:18 pm, Tran Thuan wrote:
Hi Minh,
Some minor comments from me, check [Thuan] inline.
Thanks.
Best Regards,
ThuanTr
-Original Message-
From: Minh Chau
Sent: Monday, October 7, 2019 7:12 AM
To:
Hi,
I would like to push the patches today if no more comment for them.
Thanks
Minh
On 4/10/19 3:20 pm, Minh Chau wrote:
Summary: mds: Add Nack message for MDS_TIPC_FCTRL_ENABLED [#3095] V2
Review request for Ticket(s): 3095
Peer Reviewer(s): Hans, Vu, Gary, Thuan
Pull request to: *** LIST
clean-up job)\n",
Regards, Vu
On 10/1/19 5:38 PM, Minh Hon Chau wrote:
Hi Vu,
Ok, then the value '0' needs to be written somewhere (README?) for
this special purpose I guess, to avoid a confusion later on.
Thanks
Minh
On 1/10/19 8:27 pm, Nguyen Minh Vu wrote:
Hi Mi
Hi Vu,
See comments below.
Thanks
Minh
On 1/10/19 8:34 pm, Nguyen Minh Vu wrote:
Hi Minh,
Ack with minor comments. Thanks.
Regards, Vu
On 10/1/19 12:49 PM, Minh Chau wrote:
In the scenario of recovery from split-brain, where both
active director services may suffer mds message loss due
unused
log streams' functionality.
It may be useful when user has previously set max-idle to a specific
value, and want to disable it later.
If the range starts from 1, there is no chance to disable it.
Regards, Vu
On 10/1/19 5:17 PM, Minh Hon Chau wrote:
Hi Vu,
ack for minor comment
Hi Thuan,
ack from me.
Thanks
Minh
On 25/9/19 2:05 pm, thuan.tran wrote:
- Just allocate a small buffer instead of huge buffer
---
src/mds/apitest/mdstipc_api.c | 119 +++---
1 file changed, 53 insertions(+), 66 deletions(-)
diff --git
Hi Thuan,
Some comments:
- a few warnings for >80 chars line
- Need to free(msg) that is returned from each MDS callback
- Another minor comment below
Thanks
Minh
On 24/9/19 1:10 pm, thuan.tran wrote:
- Just allocate a small buffer instead of huge buffer
---
Hi all,
Below is the patch #10 that updates most of comments, it applies on top
of current patch #9.
This patch #10 does not use the shared_ptr and base:Mutex as comments
given by Gary and Vu, the reason is that it will cause a similar problem
reported in #2860 (user call exit() without
Hi Gary,
ack from me (code review only)
Thanks
Minh
On 3/9/19 12:12 pm, Gary Lee wrote:
add assertions where pointers should not be null
fix a couple of typos
---
src/amf/amfd/comp.cc | 1 +
src/amf/amfd/csi.cc| 3 ++-
src/amf/amfd/cstype.cc | 2 ++
Hi Vu,
Agree with your comments. Any comments for patches 8/9 and 9/9?
thanks
Minh
On 16/9/19 5:22 pm, Nguyen Minh Vu wrote:
Hi Minh,
I has few comments below.
Regards, Vu
On 8/14/19 1:38 PM, Minh Chau wrote:
This patch implements the kRcvBuffOverflow state machine as
described in README
Hi Vu,
Thanks for your time to review the patches, the question is interesting.
At this moment with normal load traffic, the resource towards the new
standby (old active) is not released and will be reused if standby
switches back to active. The reason is that mds won't start the "tx
Hi Vu,
I see it, will add.
Thanks
Minh
On 16/9/19 4:21 pm, Nguyen Minh Vu wrote:
Hi Minh,
See my responses to your comments below, started with [Vu2].
Regards, Vu
On 9/16/19 1:06 PM, Minh Hon Chau wrote:
Hi Vu,
Several comments with [M] too :).
Thanks
Minh
On 16/9/19 2:24 pm, Nguyen
Hi Vu,
Some comments with [M]
Thanks
Minh
On 16/9/19 2:56 pm, Nguyen Minh Vu wrote:
Hi Minh,
I has few comments below.
Regards, Vu
On 8/14/19 1:38 PM, Minh Chau wrote:
This patch adds state machine to support tx probation timer.
---
src/mds/mds_tipc_fctrl_intf.cc | 47
Hi Vu,
Some comments with [M]
Thanks
Minh
On 16/9/19 2:37 pm, Nguyen Minh Vu wrote:
Hi Minh,
I have minor comments below.
Regards, Vu
On 8/14/19 1:38 PM, Minh Chau wrote:
If the ack size is configured greater than 1, there should be a timeout
at receiver ends to send the ack message back
Hi Vu,
Several comments with [M] too :).
Thanks
Minh
On 16/9/19 2:24 pm, Nguyen Minh Vu wrote:
Hi Minh,
I have several comments below, started with [Vu].
Regards, Vu
On 8/14/19 1:01 PM, Minh Chau wrote:
This is a collaborative patch of two participants:
- Tran Thuan
- Minh Chau
Main
Hi Hans, Gary, Vu
Do you have any comments on remaining patches?
Thanks
Minh
On 11/9/19 11:01 am, Minh Hon Chau wrote:
Hi Gary,
Thanks for the review, please find comments with [M].
/Minh
On 10/9/19 6:02 pm, Gary Lee wrote:
Hi Minh & Thuan
Some minor comments marked with [GL].
On
Hi Vu,
I have the comments [M].
Thanks
Minh
On 13/9/19 6:40 pm, Nguyen Minh Vu wrote:
Hi Minh,
I have minor comments below.
Regards, Vu
On 8/14/19 1:38 PM, Minh Chau wrote:
This patch makes the solution of TIPC buffer overflow configurable,
as well as the ack timeout/ack size.
For
Hi Gary,
This V2 has fixed the error reported in V1, ack from me.
Thanks
Minh
On 12/9/19 5:20 pm, Gary Lee wrote:
If delayed failover is enabled, and a downgrade to a version without #3060
occurs,
then the standby running a newer version with #3060 may complain about an out
of sync error
Hi Gary,
The patch works fine in the reported scenario, no coredump in amfd.
But after downgrade succeeds (meaning the sc1 is active and running old
software, the sc2 is standby running latest software + #3078), I
continue another switchover to make sc2 back to active, I got error
Thanks
Hi Gary,
Thanks for the review, please find comments with [M].
/Minh
On 10/9/19 6:02 pm, Gary Lee wrote:
Hi Minh & Thuan
Some minor comments marked with [GL].
On 14/8/19 4:38 pm, Minh Chau wrote:
This is a collaborative patch of two participants:Thuan, Minh.
Main changes:
- Add
Hi Hans,
I will update the code for that point.
Thanks
Minh
On 23/8/19 11:14 pm, Hans Nordebäck wrote:
Hi Minh,
see one comment below. /Thanks Hans
On 2019-08-23 03:48, Minh Hon Chau wrote:
Hi Hans,
Thanks for your time to review the patch, please see my replies below
your comments
Hi Hans,
Thanks for your time to review the patch, please see my replies below
your comments.
Regards,
Minh
On 22/8/19 11:07 pm, Hans Nordebäck wrote:
Hi Minh,
it is a large patch so i have to review parts of it, below are my
comments, marked with [HansN], for files:
src/mds/Makefile.am
Hi, Ack, review only.
Quoting Gary Lee :
Otherwise, after two controller failovers, unexpected
reboot of previously rebooted payloads may occur.
---
src/amf/amfd/node_state_machine.cc | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/amf/amfd/node_state_machine.cc
Hi Hans,
I will update txprob -> "tx probation"
The kEnabled, it means for a state of a tipc portid only. There's
another @is_fctrl_enabled, that's for the feature whether mds has flow
control enabled/disabled.
Thanks
Minh
On 14/8/19 5:48 pm, Hans Nordebäck wrote:
Hi Minh,
ack, some
Hi all,
Please ignore this patch series, the patch 2/9 and 9/9 committed under
Thuan name/email, have been dropped (for some reason :) ) when sending
for review.
I am sending again.
Thanks
Minh
On 14/8/19 4:01 pm, Minh Chau wrote:
Summary: mds: Add solution of TIPC buffer overflow at MDS
Hi Thuan,
ack with minor comments.
Thanks
Minh
On 18/3/19 7:04 pm, thuan.tran wrote:
AMFD should try assign SI active for other in-service SUs if fail to assign
for current in-service SU
---
src/amf/amfd/sg_2n_fsm.cc | 75 +--
1 file changed, 46
Hi,
ack (code review only)
Thanks
Minh
On 19/7/19 4:47 pm, Gary Lee wrote:
Failover information is not currently included in coldsync. This means
if a delayed failover is in progress *before* a standby controller is
available, *and* a controller failover occurs, then information about
the
Hi Thang,
Ack from me.
Thanks
Minh
On 11/6/19 4:11 pm, Minh Hon Chau wrote:
Hi Thang,
I can see it's a race in main thread that how amfd processes the mds
down and clm callback.
Node is going down
<143>1 2019-06-11T15:16:42.157517+10:00 SC-1 osafamfd 272 osafamfd
[meta sequ
Hi Thang,
ack (review + test). In below syslog, I got the assignment of sponsor +
dependent on the locked SC removed, and the other SC creates new active
assignments.
Minor comment: In sg_2n_fsm:node_fail_su_oper(), starting from line
3153, the codes are now most likely the same for both
Hi Thuan,
ack with minor comment.
Thanks
Minh
On 3/6/19 5:10 pm, thuan.tran wrote:
COMP restart recovery during SU restart recovery can lead to SU
stuck in INSTANTIATING without further action. Because COMP instaniated
event in RESTARTING does not trigger avnd_su_pres_fsm_run().
---
Hi Thang,
I can see it's a race in main thread that how amfd processes the mds
down and clm callback.
Node is going down
<143>1 2019-06-11T15:16:42.157517+10:00 SC-1 osafamfd 272 osafamfd [meta
sequenceId="38507"] 275:amf/amfd/mds.cc:398 >> avd_mds_svc_evt
<143>1
Hi Gary,
Those variables e.g node_sync_window_closed have been used before
headless sync complete. If there is a failover during the headless sync,
the new active will start the headless sync again, so those variables
have not been needed to checkpoint. But here the scenario happens in
split
-
From: Hans Nordebäck
Sent: Thursday, April 25, 2019 6:10 PM
To: Vu Minh Nguyen ; Thuan Tran
; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 0/1] Review Request for mds: support multicast
fragmented messages [#3033] V3
Hi Vu,
It seems mdtm_mcast_sendto is used
Hi Thang,
+ Hans
If the issue is reproducible, can you upload the full log/trace to
ticket please?
Thanks
Minh
On 27/2/19 10:17 am, thang.d.nguyen wrote:
Summary: amfd: increase mds priority of amfnd down event [#3015]
Review request for Ticket(s): 3015
Peer Reviewer(s): Gary, Minh
Pull
Hi Thuan,
ack (review + test).
Thanks
Minh
:
During SU (many COMPs) restart recovery, if any COMP finish instantiated
then crash while other COMPs are still instantiating, AMF recovery it by
restarting but AMF only cleanup without re-instantiation because AMF see
the COMP is not eligible for
Hi aThanh,
ack for code review.
Thanks
Minh
On 20/2/19 4:19 pm, Thanh Nguyen wrote:
Changing ecoding of time_super using 64 bit instead of 32 bit.
---
src/clm/clmd/clms_mds.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/clm/clmd/clms_mds.cc
Hi Shiva,
Looks like your application is quite similar to an amf sample app, it's
under samples/amf/sa_aware, you can try the sample app and then replace
it with your confD.
Thanks,
Minh
On 12/2/19 11:09 pm, opensaf-devel-requ...@lists.sourceforge.net wrote:
Send Opensaf-devel mailing
Hi Thang,
The patch looks ok, but I'm thinking of not introducing mds_node_down_list.
In SAI-AIS-CLM-B.04.01:
"The term unconfigured node is used in this document to designate an
execution environment that is not configured to host a CLM node."
May we add a check if a node is unconfigured
Hi Gary,
ack with comment
- There's a daemon_sigterm_install(), I think we could make a
daemon_sighup_install() in the /base/daemon.c
- I see there's a @todo that stop the split brain prevention when it's
running, when it's done we might have to document this runtime change.
Thanks
Minh
ack, review only. Thanks/Minh
On 21/1/19 2:52 pm, Gary Lee wrote:
If relaxed node promotion is enabled, allow a SC to remain
active if the peer SC can be seen, even if access to the
consensus service is lost.
---
src/amf/amfd/ndfsm.cc | 2 +-
src/amf/amfd/ndproc.cc | 13 +++--
ack, review only. Thanks/Minh
On 21/1/19 2:52 pm, Gary Lee wrote:
Add FMS_TAKEOVER_PRIORITISE_PARTITION_SIZE option to allow
active SC to be preferred during a network split. The default
behavior is to prefer the larger partition to maintain
existing behaviour.
Add configuration support for
Hi Gary,
I'm trying to understand the patch 3/5 and 4/5, there seems to be logic
of *relaxed mode* left in 3/5 and 4/5.
Thanks
Minh
On 21/1/19 2:52 pm, Gary Lee wrote:
Summary: rded: add relaxed node promotion feature [#2996]
Review request for Ticket(s): 2996
Peer Reviewer(s): Hans, Minh
:* den 11 januari 2019 12:01
*To:* Lennart Lund ; Minh Hon Chau
*Cc:* opensaf-devel@lists.sourceforge.net
*Subject:* RE: Review request ntf: update document for limit of logger
buffer [#2994]
Hi Lennart
Yes, I add new column for “Default value”.
Regards
Canh
*From:*Lennart Lund
*Sent
Hi Thuan,
I think it's ok for sleep() to make the test simple, ack from me.
thanks
Minh
On 29/11/18 7:47 pm, thuan.tran wrote:
TIPC published event received is not as order MDS service install.
Service 600 got published role active before role standby even
install role standby before role
Hi Canh,
ack with comments, please see with [M]
Thanks
Minh
On 9/1/19 8:22 pm, Canh Van Truong wrote:
When writing the notificaion fail with TRY_AGAIN in callback, the notificaion
is pushed
again to the list. If this happens for long time, the list is going to be very
big.
This cause NTFD
Hi Thuan,
ack from me.
Thanks,
Minh
On 12/12/18 7:20 pm, thuan.tran wrote:
---
test.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/test.sh b/test.sh
index daf6293..ce90a62 100755
--- a/test.sh
+++ b/test.sh
@@ -37,6 +37,7 @@ if [[ ! -f
Hi Gary, ack (code review only). Thanks Minh
On 16/11/18 5:38 pm, Gary Lee wrote:
node must be added to failover_list before SetState() is called.
If the state is 'end', then it will be deleted by SetState().
Otherwise, we will leave a node in 'End' state mistakenly in
failover_list.
---
Hi Mohan,
I have pushed the patches.
Thanks
Minh
On 14/11/18 6:19 pm, mo...@hasolutions.in wrote:
Hi minh,
I republished those patches.
please check it and push into the community.
Thanks
Mohan
High Availability Solutions Pvt. Ltd.
www.hasolutions.in
- Original Message
Hi Mohan,
ack for series with minor comments in the sub-patches.
Thanks
Minh
On 9/11/18 11:55 pm, Mohan Kanakam wrote:
Summary: ntf: add new test case of API saNtfInitialize() of apitest [#2958]
Review request for Ticket(s): 2958
Peer Reviewer(s):minh
Pull request to: *** LIST THE PERSON
Hi Mohan,
A minor comment, we could use nullptr instead.
Thanks
Minh
On 9/11/18 11:55 pm, Mohan Kanakam wrote:
---
src/ntf/apitest/tet_saNtfInitialize.cc | 8
1 file changed, 8 insertions(+)
diff --git a/src/ntf/apitest/tet_saNtfInitialize.cc
Hi Mohan,
A minor comment, I think you meant to add saNtfDispatch_04.
Thanks
Minh
On 9/11/18 11:55 pm, Mohan Kanakam wrote:
---
src/ntf/apitest/tet_saNtfDispatch.cc | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/ntf/apitest/tet_saNtfDispatch.cc
Hi Gary, ack from me. Thanks/Minh
On 14/11/18 1:28 pm, Gary Lee wrote:
Hi
A small update to the AMF PR for #2918.
* Renumbered 2.2.18 Excessive assignments to 2.2.19
* Added 2.2.18 Network partitioning
* Added timers to Section 3.3
recovery option? But how will it work?
Thanks
-Nagendra
High Availability Solutions
www.hasolutions.in
cont...@hasolutions.in
Hyderabad, India: +91-9866424860 | Delaware, USA: +1 508-422-7725
-Original Message-
From: Minh Hon Chau [mailto:minh.c...@dektech.com.au]
Sent: 12 November
Hon Chau [mailto:minh.c...@dektech.com.au]
Sent: 12 November 2018 08:04
To: Hans Nordeback; Nagendra Kumar; Gary Lee
Cc: opensaf-devel@lists.sourceforge.net
Subject: Review Request for amf: Update PR [#2929]
Hi all,
Document update for #2929 in item 2.2.18 to be reviewed.
https://sourceforge.net
1 - 100 of 394 matches
Mail list logo
