Looks good. Ack.
-Original Message-
From: Thien Minh Huynh
Sent: Thursday, May 2, 2024 1:11 PM
To: Thang Duc Nguyen ; Dat Tran Quoc Phan
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subject: [PATCH 1/1] pyosaf: Allow SaStringT compare with str by default [#3351]
An
Hi Thien,
It's better if other operators can be applied, e.i, <, >,
B.R/Thang
-Original Message-
From: Thien Minh Huynh
Sent: Tuesday, April 23, 2024 10:45 AM
To: Thang Duc Nguyen ; Dat Tran Quoc Phan
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subjec
Ack.
-Original Message-
From: Thien Minh Huynh
Sent: Wednesday, January 10, 2024 10:19 AM
To: Thang Duc Nguyen ; Dat Tran Quoc Phan
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subject: [PATCH 1/1] amf: retry if imm unavailable during recovery [#3344]
If a component
ACK.
-Original Message-
From: Thien Minh Huynh
Sent: Friday, December 29, 2023 1:51 PM
To: Thang Duc Nguyen ; Dat Tran Quoc Phan
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subject: [PATCH 1/1] amf: check the existing sg before create new one [#3345]
When IMM is
ACK.
-Original Message-
From: Tai Huynh Nguyen
Sent: Thursday, May 25, 2023 4:23 PM
To: Dat Tran Quoc Phan ; Thien Minh Huynh
; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Tai Huynh Nguyen
Subject: [PATCH 1/1] amf: Fix errors reported by valgrind [#3339]
Fix access
Ack.
-Original Message-
From: Khanh Q Nguyen
Sent: Monday, April 17, 2023 2:10 PM
To: Thang Duc Nguyen ; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Khanh Q Nguyen
Subject: [PATCH 2/2] evt: fix pointer used after free [#3332]
This fix moves the free function to a more
Looks good. Ack.
-Original Message-
From: Thien Minh Huynh
Sent: Friday, April 7, 2023 2:22 PM
To: Thang Duc Nguyen ; Dat Tran Quoc Phan
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subject: [PATCH 1/1] log: check the queue capacity before retrieving an item
[#3334
Ack with minor comment.
Use variable to store "Try '$(basename "$0") -h or --help' for more
information" then use it.
-Original Message-
From: Khanh Q Nguyen
Sent: Wednesday, March 29, 2023 3:41 PM
To: Thang Duc Nguyen ; Thien Minh Huynh
Cc: opensaf-deve
Hi Dat,
It's better to fix in new ticket.
B.R/Thang
-Original Message-
From: Dat Tran Quoc Phan
Sent: Monday, March 27, 2023 4:21 PM
To: Thang Duc Nguyen ; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Dat Tran Quoc Phan
Subject: [PATCH 1/1] amf: Fix errors report
Hi Khanh,
Some comments inline from me.
B.R/Thang
-Original Message-
From: Khanh Q Nguyen
Sent: Friday, March 24, 2023 5:01 PM
To: Thang Duc Nguyen ; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Khanh Q Nguyen
Subject: [PATCH 1/1] clm: Add an operation to excute a
Hi Dat,
Ack with minor comment.
Remove file mbcsv_mds.c due to not contain any fixes.
B.R/Thang
-Original Message-
From: Dat Tran Quoc Phan
Sent: Tuesday, March 7, 2023 2:30 PM
To: Thang Duc Nguyen ; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Dat Tran Quoc Phan
Ack. No comment from me.
-Original Message-
From: Thien Minh Huynh
Sent: Friday, November 4, 2022 3:52 PM
To: Hieu Hong Hoang ; Minh Hon Chau
; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subject: [PATCH 1/1] dtm: flush logtrace asap when logtrace
Ack.
-Original Message-
From: Hieu Hong Hoang
Sent: Tuesday, December 20, 2022 1:25 PM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Hieu Hong Hoang
Subject: [PATCH 1/1] mds: Fix errors reported by valgrind [#3328]
Valgrind reports
Ack. No comment.
-Original Message-
From: Thien Minh Huynh
Sent: Thursday, December 8, 2022 8:40 AM
To: Thang Duc Nguyen ; Hieu Hong Hoang
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subject: [PATCH 0/5] Review Request for fix access uninitialised value [#3326
Hi Hieu,
Looks good. Ack.
B.R/Thang
-Original Message-
From: Hieu Hong Hoang
Sent: Tuesday, December 6, 2022 9:25 AM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Hieu Hong Hoang
Subject: [PATCH 1/1] mds: Fix failed test cases in
Hi Hieu,
Ack.
-Original Message-
From: Hieu Hong Hoang
Sent: Friday, November 11, 2022 6:13 PM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Hieu Hong Hoang
Subject: [PATCH 2/2] log: Create a test case for forked processes [#3322
Hi Hieu,
Ack from me.
B.R/Thang
-Original Message-
From: Hieu Hong Hoang
Sent: Thursday, November 3, 2022 6:35 PM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Hieu Hong Hoang
Subject: [PATCH 3/3] mds: Test cases for conflicted
Ack.
-Original Message-
From: Thien Minh Huynh
Sent: Tuesday, September 20, 2022 5:48 PM
To: Thang Duc Nguyen ; Minh Hon Chau
; Hieu Hong Hoang
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subject: [PATCH 1/1] imm: fix multiple value attribute out of order [#3321
Ack. No comment.
-Original Message-
From: Hieu Hong Hoang
Sent: Friday, July 22, 2022 1:53 PM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Hieu Hong Hoang
Subject: [PATCH 1/1] amf: Update handling mds event in amfnd [#3317]
In
Ack.
-Original Message-
From: Hieu Hong Hoang
Sent: Wednesday, July 20, 2022 1:05 PM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Hieu Hong Hoang
Subject: [PATCH 1/1] mds: Not wait for dead Adest to send RSP [#3102]
Currently, the
Ack with comment.
Should replace ntfs_exit() by exit(EXIT_FAILURE).
-Original Message-
From: Hieu Hong Hoang
Sent: Wednesday, July 27, 2022 5:11 PM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Hieu Hong Hoang
Subject: [PATCH 1/1
Ack.
-Original Message-
From: Thien Minh Huynh
Sent: Thursday, June 9, 2022 1:47 PM
To: Thang Duc Nguyen ; Minh Hon Chau
; Hieu Hong Hoang ; Dat
Tran Quoc Phan
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subject: [PATCH 1/1] base: Correctly use the
Ack.
-Original Message-
From: Hoang Minh Vu
Sent: Thursday, April 28, 2022 5:30 AM
To: Thien Minh Huynh ; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Hoang Minh Vu
Subject: [PATCH 1/1] imm: fix PBE logging inconsistent [#3311]
There are some logging syslog for PBE but
Ack.
-Original Message-
From: Thien Minh Huynh
Sent: Tuesday, February 8, 2022 3:59 PM
To: Minh Hon Chau ; Thang Duc Nguyen
; Hieu Hong Hoang
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subject: [PATCH 1/1] imm: fix immnd crash when authenticate non-local user
[#3305
Ack.
-Original Message-
From: Hieu Hong Hoang
Sent: Thursday, January 6, 2022 11:11 AM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Hieu Hong Hoang
Subject: [PATCH 2/2] mds: Correct checking the sequence number in loss
indication
Ack.
-Original Message-
From: Thien Minh Huynh
Sent: Friday, January 7, 2022 3:26 PM
To: Minh Hon Chau ; Thang Duc Nguyen
; Hieu Hong Hoang
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subject: [PATCH 1/1] log: removal of letter 'C'/'R' from msgI
Ack with minor comment.
Update commit msg due to the fix just apply to HC period.
-Original Message-
From: Dat Tran Quoc Phan
Sent: Friday, December 17, 2021 9:29 AM
To: Hieu Hong Hoang ; Huu The Truong
; Minh Hon Chau ; Thang
Duc Nguyen ; Thien Minh Huynh
Cc: opensaf-devel
Ack. No comment.
-Original Message-
From: Hieu Hong Hoang
Sent: Tuesday, November 23, 2021 3:43 PM
To: Thang Duc Nguyen ; Thien Minh Huynh
; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net; Hieu Hong Hoang
Subject: [PATCH 1/1] amf: Correct the version of csi attribute message
Ack from me.
-Original Message-
From: Thien Minh Huynh
Sent: Thursday, October 7, 2021 1:53 PM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thanh Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subject: [PATCH 1/1] ntf: get attribute value from local when value not
Ack.
-Original Message-
From: Minh Hon Chau
Sent: Thursday, September 23, 2021 6:20 AM
To: Thang Duc Nguyen ; Hieu Hong Hoang
Cc: opensaf-devel@lists.sourceforge.net; Minh Hon Chau
Subject: [PATCH 1/1] amfd: Tightens sync window condition to proceed headless
restoration [#3271]
In
Ack.
-Original Message-
From: Thien Minh Huynh
Sent: Friday, September 17, 2021 9:16 AM
To: Thang Duc Nguyen ; Minh Hon Chau
; Hieu Hong Hoang
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subject: [PATCH 1/1] base: using mutex for test case sysf_ipc_test instead of
Ack.
-Original Message-
From: Hieu Hong Hoang
Sent: Thursday, September 16, 2021 4:32 PM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Hieu Hong Hoang
Subject: [PATCH 1/1] amfd: Correct checking CSICOMP while deleting CSI [#3282
Ack.
-Original Message-
From: Thien Minh Huynh
Sent: Tuesday, August 17, 2021 4:26 PM
To: Thang Duc Nguyen ; Minh Hon Chau
; Hieu Hong Hoang
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subject: [PATCH 1/1] build: adaptive python version for rpm build [#3270]
The
Ack.
From: Thien Minh Huynh
Sent: Monday, September 6, 2021 10:09 AM
To: Minh Hon Chau ; Thang Duc Nguyen
; Thanh Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] Review request imm: update PR documentation for configurable
IMMA synchronize timeout [#3278] V2
Hi all,
This
Ack.
-Original Message-
From: Thanh Nguyen
Sent: Friday, August 27, 2021 9:26 AM
To: Thang Duc Nguyen ; Minh Hon Chau
; mo...@hasolutions.in
Cc: opensaf-devel@lists.sourceforge.net; Thanh Nguyen
Subject: [PATCH 1/1] ntf: Fix compilation errors for 32 bit machine [#3279]
Patch for
Ack with minor comment.
Should change the func name from imma_getEnvSyncrTimeout to
imma_getSyncrTimeout .
-Original Message-
From: Thien Minh Huynh
Sent: Monday, August 9, 2021 5:21 PM
To: Minh Hon Chau ; Thang Duc Nguyen
; Surbhi Tripathi
Cc: opensaf-devel@lists.sourceforge.net
Ack.
-Original Message-
From: Thien Minh Huynh
Sent: Wednesday, July 21, 2021 3:54 PM
To: Thang Duc Nguyen ; Hieu Hong Hoang
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subject: [PATCH 1/1] build: checking test is enable before compile basetest
[#3274]
make install
Ack with minor comment.
Should update commit msg to common.
-Original Message-
From: Huu The Truong
Sent: Tuesday, July 20, 2021 12:02 PM
To: Thang Duc Nguyen ; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net; Huu The Truong
Subject: [PATCH 1/1] amf: fix leak memory in
Ack.
-Original Message-
From: Surbhi Tripathi
Sent: Monday, July 12, 2021 10:24 AM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Surbhi Tripathi
Subject: [PATCH 1/1] osaf: Added an saAisStrError(SaAisErrorT) function [#2143]
Added
Ack.
-Original Message-
From: Surbhi Tripathi
Sent: Tuesday, July 6, 2021 12:01 PM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Surbhi Tripathi
Subject: [PATCH 1/1] build: Remove the dtlog directory [#2156]
Do not create dtlog
Ack.
-Original Message-
From: Minh Hon Chau
Sent: Wednesday, May 12, 2021 7:58 AM
To: Thien Minh Huynh ; Surbhi Tripathi
; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Minh Hon Chau
Subject: [PATCH 2/2] imma: Correctly use IMMA_SYNCR_TIMEOUT [#3260]
---
src/imm/agent
OK. No more comment.
-Original Message-
From: Minh Hon Chau
Sent: Tuesday, May 18, 2021 9:47 AM
To: Thang Duc Nguyen ; Thien Minh Huynh
; Surbhi Tripathi
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/2] immnd: Make IMMSV_FEVS_MAX_PENDING environment
variable [#3260
Hi Minh,
Good catch. I will update in V3.
-Original Message-
From: Minh Hon Chau
Sent: Tuesday, May 18, 2021 9:44 AM
To: Thang Duc Nguyen ; Thanh Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] smf: enhance smf to handle timeout in one step upgrade
[#3262
Hi Minh,
One more.
B.R/Thang
-Original Message-
From: Minh Hon Chau
Sent: Tuesday, May 18, 2021 9:36 AM
To: Thang Duc Nguyen ; Thien Minh Huynh
; Surbhi Tripathi
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/2] immnd: Make IMMSV_FEVS_MAX_PENDING environment
variable
Hi Minh,
2 comments inline.
B.R/Thang
-Original Message-
From: Minh Hon Chau
Sent: Tuesday, May 18, 2021 6:51 AM
To: Thien Minh Huynh ; Surbhi Tripathi
; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Minh Hon Chau
Subject: [PATCH 1/2] immnd: Make IMMSV_FEVS_MAX_PENDING
Hi Thien,
Ack.
B.R/Thang
-Original Message-
From: Thien Minh Huynh
Sent: Tuesday, May 4, 2021 5:07 PM
To: Thang Duc Nguyen ; Thanh Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subject: [PATCH 1/1] dtm: Add osaflog options for print log entries between a
range of
Ack. No comment from me.
-Original Message-
From: Anh Tuan Le
Sent: Tuesday, April 20, 2021 9:41 AM
To: Thang Duc Nguyen ; Thanh Nguyen
; Hieu Hong Hoang
Cc: opensaf-devel@lists.sourceforge.net; Anh Tuan Le
Subject: [PATCH 1/1] pyosaf: support for amf api version b4.02 [#3256
: Thang Duc Nguyen ; Thanh Nguyen
; Hieu Hong Hoang
Cc: opensaf-devel@lists.sourceforge.net; Anh Tuan Le
Subject: [PATCH 1/1] pyosaf: support for amf api version b4.02 [#3256]
---
python/pyosaf/saAmf.py | 1365 +---
1 file changed, 710 insertions(+), 655
Hi Hieu,
ACK.
B.R/Thang
-Original Message-
From: Hieu Hong Hoang
Sent: Wednesday, April 14, 2021 10:50 AM
To: Thang Duc Nguyen ; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net; Hieu Hong Hoang
Subject: [PATCH 1/1] amf: Fix invoking the csi attribute change callback [#3255
ACK. No comment from me.
-Original Message-
From: Thanh Nguyen
Sent: Monday, April 12, 2021 9:58 AM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Thanh Nguyen
Subject: [PATCH 1/1] smf: Enhance handling of global variables [#2726
Ack.
-Original Message-
From: Thien Minh Huynh
Sent: Thursday, March 18, 2021 10:08 AM
To: Thang Duc Nguyen ; Hieu Hong Hoang
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subject: [PATCH 1/1] log: improve logtest testsuite 22 [#3253]
- retry more to reveive another
Ack.
-Original Message-
From: Surbhi Tripathi
Sent: Thursday, March 25, 2021 6:44 AM
To: Thang Duc Nguyen ; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net; Surbhi Tripathi
Subject: [PATCH 1/1] imm: potential leak of memory pointed to by ao_node in OM
API [#2826]
---
src
Ack.
-Original Message-
From: Surbhi Tripathi
Sent: Wednesday, March 17, 2021 6:29 AM
To: Thang Duc Nguyen ; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net; Surbhi Tripathi
Subject: [PATCH 1/1] clm: fix memleak detected by valgrind [#3252]
Multiple
Ack.
-Original Message-
From: Thien Minh Huynh
Sent: Friday, February 5, 2021 5:49 PM
To: Thang Duc Nguyen ; Minh Hon Chau
; Surbhi Tripathi
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subject: [PATCH 1/1] imm: ignore enter headless if already entered [#3250]
immnd
Ack.
-Original Message-
From: Thien Minh Huynh
Sent: Wednesday, February 3, 2021 3:42 PM
To: Thang Duc Nguyen ; Thanh Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subject: [PATCH 1/1] clm: use calloc instead malloc to remove garbage value
[#3251]
The buffer
Hi Thien,
Maybe the issue (garbage value) due to using malloc().
You can try with calloc().
B.R/Thang
-Original Message-
From: Thien Minh Huynh
Sent: Friday, January 29, 2021 3:23 PM
To: Thang Duc Nguyen ; Thanh Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Ack.
-Original Message-
From: Thien Minh Huynh
Sent: Thursday, January 14, 2021 5:07 PM
To: Thang Duc Nguyen ; Thanh Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subject: [PATCH 1/1] pyosaf: update pyosaf support python3 [#3247]
- check data type before
ACK.
-Original Message-
From: Thuan Tran
Sent: Monday, December 21, 2020 11:08 AM
To: Minh Hon Chau ; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Thuan Tran
Subject: [PATCH 2/2] log: do not use trace in signal handler [#3245]
Do not use trace in the signal handler.
It
Ack.
-Original Message-
From: Thuan Tran
Sent: Friday, December 18, 2020 10:41 AM
To: Minh Hon Chau ; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Thuan Tran
Subject: [PATCH 1/1] amf: fix cluster stuck unhealthy when SCs brutal reboot
[#3241]
When see AMFD UP
Ack.
-Original Message-
From: Thuan Tran
Sent: Wednesday, November 11, 2020 9:54 AM
To: Minh Hon Chau ; Thang Duc Nguyen
; Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net; Thuan Tran
Subject: [PATCH 1/1] log: fix memleak detected by valgrind [#3234]
---
src/log/logd
Ack.
-Original Message-
From: Thuan Tran
Sent: Monday, October 19, 2020 9:13 PM
To: Thang Duc Nguyen ; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net; Thuan Tran
Subject: [PATCH 1/1] amf: fix lock SU operation keep return TRY_AGAIN forever
[#3227]
- si_dep_state is changed
Hi Thuan,
Ack from me.
B.R/Thang
-Original Message-
From: Thuan Tran
Sent: Friday, October 16, 2020 3:18 PM
To: Thang Duc Nguyen ; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net; Thuan Tran
Subject: [PATCH 1/1] imm: drop re-intro message from down IMMND [#3228]
IMMD
Hi Thuan,
Ack.
B.R/Thang
-Original Message-
From: Thuan Tran
Sent: Thursday, September 24, 2020 4:05 PM
To: Minh Hon Chau ; Thang Duc Nguyen
; Thanh Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Thuan Tran
Subject: [PATCH 1/1] smf: improve admin operation from serial to parallel
Hi Thuan,
Ack.
No more comment from me.
B.R/Thang
-Original Message-
From: Thuan Tran
Sent: Tuesday, August 18, 2020 10:29 AM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thanh Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] mbc: fix agent crash inside
Hi Thuan,
Ack (Not tested).
B.R/Thang
-Original Message-
From: Thuan Tran
Sent: Tuesday, August 18, 2020 3:54 PM
To: Thang Duc Nguyen ; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net; Thuan Tran
Subject: [PATCH 1/1] imm: fix memleak detected by valgrind [#3213]
---
src/imm
Sent: Friday, August 14, 2020 1:33 PM
To: Minh Hon Chau ; Thang Duc Nguyen
; Thanh Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Thuan Tran
Subject: [PATCH 1/1] mbc: fix agent crash inside ncs_mbcsv_null_func() [#3214]
---
src/mbc/mbcsv_peer.c | 8 +++-
src/mbc/mbcsv_util.c | 5 ++---
2
Hi Thuan,
One comment in code review.
From: Thuan Tran
Sent: Thursday, August 13, 2020 8:44 AM
To: Thang Duc Nguyen ; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] rde: allow node start first to be promoted in relax
mode [#3191]
Hi Thang,
See my reply
Hi Thuan,
See my comment inline.
From: Thuan Tran
Sent: Wednesday, August 12, 2020 10:25 PM
To: Thang Duc Nguyen ; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] rde: allow node start first to be promoted in relax
mode [#3191]
Hi Thang,
It is for the case as
Hi Minh,
It can be reproduced. Refer on ticket for more info.
See my respond inline.
-Original Message-
From: Minh Hon Chau
Sent: Wednesday, August 12, 2020 4:24 PM
To: Thang Duc Nguyen ; Thuan Tran
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] amfnd: handle
Hi Thuan,
I think the pending time only need updating/calculating in SendPeerInfoResp(),
when it receives the peer up event.
No need to update again in SetPeerState().
B.R/Thang
-Original Message-
From: Thuan Tran
Sent: Monday, May 25, 2020 11:27 AM
To: Minh Hon Chau ; Thang Duc
Hi,
Ack with very minor comment.
It' update description of ckpt_decode_cold_sync() to notice about the counter
as in ckpt_enc_cold_sync_data().
-Original Message-
From: Thuan Tran
Sent: Wednesday, July 29, 2020 12:55 PM
To: Thien Minh Huynh ; Thang Duc Nguyen
Cc: opensaf-
I missed one info. I tested with NON_ROOT user.
export AMFND_NON_ROOT=1
-Original Message-
From: Thang Duc Nguyen
Sent: Tuesday, July 21, 2020 11:02 AM
To: s.an...@gethighavailability.com; Minh Hon Chau ;
nagen...@gethighavailability.com; p...@gethighavailability.com
Cc: opensaf
.an...@gethighavailability.com
Sent: Tuesday, July 21, 2020 9:22 AM
To: Minh Hon Chau ; Thang Duc Nguyen
; nagen...@gethighavailability.com;
p...@gethighavailability.com
Cc: opensaf-devel@lists.sourceforge.net; Anand Sundararaj
Subject: [PATCH 1/1] amf: remove hard-coding in amfnd [#3205]
From: An
Hi Thanh,
Ack with minor comment inline.
-Original Message-
From: Minh Hon Chau
Sent: Wednesday, July 15, 2020 7:29 PM
To: Thanh Nguyen ; Thang Duc Nguyen
; Thuan Tran
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] ntf: Handle IMM multiple value attribute in
Ack.
-Original Message-
From: Thuan Tran
Sent: Friday, July 10, 2020 11:13 AM
To: Phuc Hoang Chau ; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] imm: fix memory leak reported by valgrind [#3199]
Hi Phuc,
ACK from me.
Best Regards,
ThuanTr
Hi Minh,
Will consider if issue happens with NTF in future.
B.R/Thang
-Original Message-
From: Minh Hon Chau
Sent: Wednesday, July 8, 2020 11:03 AM
To: Thang Duc Nguyen ; Thuan Tran
; Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] lgs: not invoke
Hi Thuan,
Thanks for your comment.
See my respond inline.
-Original Message-
From: Thuan Tran
Sent: Tuesday, June 9, 2020 8:40 PM
To: Thang Duc Nguyen ; Vu Minh Nguyen
; Thien Minh Huynh ;
Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] lgs: fix memory
Hi Vu,
Thanks for your comments.
See my respond inline.
B.R/Thang
-Original Message-
From: Vu Minh Nguyen
Sent: Tuesday, June 2, 2020 12:14 PM
To: Thang Duc Nguyen ; Thien Minh Huynh
; Thuan Tran ; Minh
Hon Chau
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1/1
Hi Minh,
No comment form me.
-Original Message-
From: Minh Hon Chau
Sent: Tuesday, May 19, 2020 7:28 AM
To: Gary Lee ; Thuan Tran ;
Thang Duc Nguyen ; Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: doc: Update Spare System Controller documentation [#3177]
Hi all
Hi Thuan,
Just a minor comment.
Instead of adding asset() below
size = (size + 3) & ~3;
It's better to move it to above.
B.R/Thang
-Original Message-
From: Thuan Tran
Sent: Monday, May 18, 2020 11:15 AM
To: Thang Duc Nguyen ; Minh Hon Chau
Cc: open
Hi Thuan,
Thanks for your comment.
See my respond inline.
-Original Message-
From: Thuan Tran
Sent: Wednesday, April 22, 2020 9:41 AM
To: Thang Duc Nguyen ; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] ntf: set operation invoke name to unknown if
I updated solution and sent out V2.
-Original Message-
From: Minh Hon Chau
Sent: Tuesday, April 21, 2020 2:23 PM
To: Thuan Tran ; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] ntf: restart ntfimcnd if it fails to get operation
invoke name [#3178
Update.
If we accept to avoid coredump, there is @operation_invoke_name that needs to
be freed before exit?
[Thang]: as above can fill invoke_name as unknown in this case to avoid the
coredump.
And free in applyccbcb.
-Original Message-
From: Thang Duc Nguyen
Sent: Tuesday, April 21
Hi Minh,
See my command inline.
-Original Message-
From: Minh Hon Chau
Sent: Monday, April 20, 2020 5:24 PM
To: Thang Duc Nguyen ; Thuan Tran
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] ntf: restart ntfimcnd if it fails to get operation
invoke name [#3178]
Hi
Hi Minh,
See my comment inline.
-Original Message-
From: Minh Hon Chau
Sent: Monday, April 20, 2020 11:51 AM
To: Thuan Tran ; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] ntf: restart ntfimcnd if it fails to get operation
invoke name [#3178]
Hi
Sent: Thursday, April 16, 2020 10:16 AM
To: Thang Duc Nguyen ; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] ntf: restart ntfimcnd if it fails to get operation
invoke name [#3178]
Hi Thang,
>From reproduce method, with solution after exit (instead of cr
Hi Thien,
Just a minor comment.
Instead of using many variables then just use them to compare with 0/1 or
true/false.
I think it's better to use if directly.
E.g,
+ bool hhmmss_format = all_digits(finfo->d_name + time_offset,
+ time_length); if (hhmmss_format == false) return 0;
->
// time fo
Hi Minh,
Ok. I will update the commit in next ps.
-Original Message-
From: Minh Hon Chau
Sent: Thursday, April 9, 2020 7:50 AM
To: Thang Duc Nguyen ; Thuan Tran
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] amfnd: correct update su-si assignment flag [#3176]
Hi
Ack.
-Original Message-
From: Thuan Tran
Sent: Wednesday, April 1, 2020 2:40 PM
To: Minh Hon Chau ; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Thuan Tran
Subject: [PATCH 1/1] amfnd: fix coding issues identified by codechecker [#3174]
---
src/amf/amfnd/clc.cc | 1
Hi Thuan,
Ack with 2 comments.
-Original Message-
From: Thuan Tran
Sent: Wednesday, March 18, 2020 8:57 AM
To: Thang Duc Nguyen ; Minh Hon Chau
; Gary Lee
Cc: opensaf-devel@lists.sourceforge.net; Thuan Tran
Subject: [PATCH 1/1] amfd: fix coding issue identify by codechecker [#3168
Hi Thuan,
Ack from me (not tested).
B.R/Thang
-Original Message-
From: Thuan Tran
Sent: Monday, March 9, 2020 1:08 PM
To: Thang Duc Nguyen ; Minh Hon Chau
; Gary Lee
Cc: opensaf-devel@lists.sourceforge.net; Thuan Tran
Subject: [PATCH 1/1] amfnd: fix unexpected reboot after split
Hi Thuan,
In normal runing/condition the message not printed. So it can not be considered
as spam.
B.R/Thnag
-Original Message-
From: Thuan Tran
Sent: Thursday, March 5, 2020 5:25 PM
To: Thang Duc Nguyen ; Gary Lee
; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE
Hi Minh,
Thanks for your comment.
I update as Thuan's comment. So we can ignore your comment.
-Original Message-
From: Minh Hon Chau
Sent: Monday, March 2, 2020 10:03 AM
To: Thang Duc Nguyen ; Thuan Tran
; Gary Lee
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATC
Hi Thuan,
Thanks for your comment.
See my comment inline.
-Original Message-
From: Thuan Tran
Sent: Monday, March 2, 2020 9:41 AM
To: Thang Duc Nguyen ; Minh Hon Chau
; Gary Lee
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] amfnd: handle comp instantiate event with
Hi Phuc,
Some comments inline.
-Original Message-
From: phuc.h.chau
Sent: Friday, February 28, 2020 2:02 PM
To: Vu Minh Nguyen ; Thuan Tran
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 1/1] imm: imm_list tool add new option --delimiter
[#3155]
Make delimiter of mu
Hi Thuan,
See my comment inline.
-Original Message-
From: Thuan Tran
Sent: Thursday, February 20, 2020 4:17 PM
To: Thang Duc Nguyen ; Minh Hon Chau
; Gary Lee
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] amfnd: correct handling "terminate success&qu
Summary: amfnd: correct handling "terminate success" evt in terminating state
[#3157]
Review request for Ticket(s): 3157
Peer Reviewer(s): Minh, Thuan, Gary
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-3157
Base revision: b3
Amfnd need to exist in node in shutdown state and all
components terminated.
---
src/amf/amfnd/clc.cc | 40
1 file changed, 28 insertions(+), 12 deletions(-)
diff --git a/src/amf/amfnd/clc.cc b/src/amf/amfnd/clc.cc
index de57838c9..f78e1a707 100644
--- a/s
Please ignore to review this version. I will send the update later.
-Original Message-
From: Thang Duc Nguyen
Sent: Wednesday, February 19, 2020 2:04 PM
To: Minh Hon Chau ; Thuan Tran
; Gary Lee
Cc: opensaf-devel@lists.sourceforge.net; Thang Duc Nguyen
Subject: [PATCH 1/1] amfnd
Ignore remove assignment for NPI component if
node is in shutdown state.
---
src/amf/amfnd/susm.cc | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/amf/amfnd/susm.cc b/src/amf/amfnd/susm.cc
index 86811f1e4..c22fce55b 100644
--- a/src/amf/amfnd/susm.cc
+++ b/src/amf/amfnd/susm.cc
@@ -32
1 - 100 of 102 matches
Mail list logo
