,
Zoran
-Original Message-
From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com]
Sent: Tuesday, September 15, 2015 8:47 AM
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0 of 1] Review Request for imm: fix memory leak in display
resources [#1477
Hi Neelakanta,
It was misunderstanding.
I'll do as you described.
Thanks,
Zoran
-Original Message-
From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com]
Sent: Tuesday, September 15, 2015 10:24 AM
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0
Ack from me.
Not tested.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Monday, September 14, 2015 6:14 AM
To: Anders Björnerstedt; Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1
Hi Hung,
Find my comments inline.
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Saturday, September 12, 2015 2:13 PM
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1 of 1] imm: fix memory leak in display
Tests n
Other n
Comments (indicate scope for each "y" above):
-
changeset 4581d497fbff57d03c32108444a47c6aa3c1d232
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Sat, 12 Sep 201
osaf/services/saf/immsv/immnd/immnd_evt.c | 27 +++
1 files changed, 27 insertions(+), 0 deletions(-)
The patch releases allocated memory for the result of admin op for display
resources
diff --git a/osaf/services/saf/immsv/immnd/immnd_evt.c
[mailto:mahesh.va...@oracle.com]
Sent: Friday, September 11, 2015 11:03 AM
To: Zoran Milinkovic; ramesh.bet...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] mds: fixed memory leak in opensf authenticate code
[#1475]
osaf/libs/core/mds/include/mds_dt2c.h | 2 ++
osaf/libs
To: Zoran Milinkovic; ramesh.bet...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1 of 1] mds: fixed memory leak in opensf authenticate code
[#1475]
HI Zoran,
Thanks for the quick review .
In start_mds_down_tmr() the timer was created with tmr_t tmr_id =
ncs_tmr_alloc
osaf/libs/agents/saf/imma/imma_proc.c | 7 ---
osaf/services/saf/immsv/immd/immd_evt.c | 16
osaf/services/saf/immsv/immnd/immnd_evt.c | 12 +---
3 files changed, 9 insertions(+), 26 deletions(-)
In some places memory is allocated by ncs_enc_init_space,
n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
changeset e459b6a05dbf6e5d354e57f62e4a50f894c2a686
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Thu, 03 S
n
Other n
Comments (indicate scope for each y above):
-
changeset 908863d72ab2ad649adfefd9b5b5930ac5487ca7
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Fri, 28 Aug 2015 16:00:52 +0200
imm
osaf/services/saf/immsv/immnd/ImmModel.cc | 126 +++-
osaf/services/saf/immsv/immnd/ImmModel.hh |5 +
osaf/services/saf/immsv/immnd/immnd_evt.c | 48 ++-
osaf/services/saf/immsv/immnd/immnd_init.h |6 +
4 files changed, 156 insertions(+), 29
Hi,
I'll add free() when I push the code.
Thanks,
Zoran
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Thursday, August 27, 2015 10:51 AM
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1 of 1] mds: fix memory leak in MDS
)mds_process_info_del(info);
}
break;
-AVM
On 8/26/2015 9:19 PM, Zoran Milinkovic wrote:
osaf/libs/core/mds/mds_main.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Free allocated memory for MDS_PROCESS_INFO
osaf/libs/core/mds/mds_main.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Free allocated memory for MDS_PROCESS_INFO structure when
mds_register_callback() receives MDS_UNREGISTER_REQ.
diff --git a/osaf/libs/core/mds/mds_main.c b/osaf/libs/core/mds/mds_main.c
---
n
Other n
Comments (indicate scope for each y above):
-
changeset 83bbe59386c0079a45b3f4ea10c60e4a63026a52
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Wed, 26 Aug 2015 17:45:03 +0200
mds: fix
n
Other n
Comments (indicate scope for each y above):
-
changeset 6965f5d2535817425236316cd9339db79b750043
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Wed, 26 Aug 2015 17:17:59 +0200
osaf: fix memory leak
osaf/libs/core/common/osaf_secutil.c | 14 --
1 files changed, 8 insertions(+), 6 deletions(-)
The patch fixes a memory leak adding endgrent() in missed places in
osaf_get_group_list().
diff --git a/osaf/libs/core/common/osaf_secutil.c
b/osaf/libs/core/common/osaf_secutil.c
---
Nguyễn
DEK Technologies
From: Zoran Milinkovic
Sent: Friday, August 14, 2015 4:26PM
To: Neelakanta Reddy
Cc: Opensaf-devel
Subject: [devel] [PATCH 1 of 1] imm: force cleanTheHouse job on aborting
non-critical CCB admin op [#1107]
osaf/services/saf/immsv/immnd
: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com]
Sent: Friday, August 21, 2015 10:51 AM
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1 of 1] immtools: add new checks for PBE audit [#19]
Hi zoran,
Reviewed and tested the patch.
Ack with the following comment
Ack from me.
Reviewed, but not tested.
Best regards,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Thursday, August 20, 2015 12:48 PM
To: Anders Björnerstedt; Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Ack from me.
Reviewed, but not tested.
Best regards,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Thursday, August 20, 2015 12:44 PM
To: Anders Björnerstedt; Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Ack from me.
Reviewed, but not tested.
Best regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: Wednesday, August 05, 2015 12:24 PM
To: Anders Björnerstedt; nagendr...@oracle.com; Zoran Milinkovic
Cc: opensaf-devel
osaf/tools/safimm/immdump/imm_dumper.cc | 32 +---
1 files changed, 17 insertions(+), 15 deletions(-)
Allow immdump to audit PBE when OpenSAF is down.
diff --git a/osaf/tools/safimm/immdump/imm_dumper.cc
b/osaf/tools/safimm/immdump/imm_dumper.cc
---
Ack from me.
Not tested.
Best regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: Friday, August 14, 2015 7:56 AM
To: Anders Björnerstedt; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1
Ack from me.
Not tested.
Best regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: Wednesday, July 01, 2015 4:16 PM
To: Anders Björnerstedt; Zoran Milinkovic; mahesh.va...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Other n
Comments (indicate scope for each y above):
-
changeset b14303f1d0428de738c1aa30a48bf5100d8560f7
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Fri, 14 Aug 2015 09:38:27 +0200
immtools: allow immdump
osaf/services/saf/immsv/immnd/ImmModel.cc | 28 +++-
osaf/services/saf/immsv/immnd/immnd_cb.h | 1 +
osaf/services/saf/immsv/immnd/immnd_main.c | 7 +--
osaf/services/saf/immsv/immnd/immnd_proc.c | 6 +-
4 files changed, 30 insertions(+), 12 deletions(-)
n
Other n
Comments (indicate scope for each y above):
-
changeset ca85abc7241141ece2317bb00594d5a0c32c819a
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Fri, 14 Aug 2015 11:17:10 +0200
imm
very low, but I think that this case
should also be covered.
Best regards,
Zoran
-Original Message-
From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com]
Sent: Wednesday, August 12, 2015 8:48 AM
To: Zoran Milinkovic; Anders Björnerstedt; mahesh.va...@oracle.com
Cc: opensaf-devel
Reviewed but not tested.
Ack from me.
Best regards,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Thursday, July 30, 2015 12:27 PM
To: Anders Björnerstedt; Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
n
Comments (indicate scope for each y above):
-
changeset 65b92521a65a84be860b1432e99428d85e386928
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Wed, 12 Aug 2015 14:07:37 +0200
immtools: add new checks for PBE audit [#19
; Zoran Milinkovic; mahesh.va...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm:Decrement sqliteTransLock when BEGIN EXCLUSIVE
TRANSACTION fails [#1426]
osaf/libs/common/immsv/immpbe_dump.cc | 1 +
1 files changed, 1 insertions(+), 0 deletions
Ack from me.
Best regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: Friday, July 31, 2015 5:25 PM
To: Anders Björnerstedt; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm: search for child
tests/immsv/implementer/Makefile.am| 2 +
tests/immsv/implementer/test_cleanup.c | 37 +
tests/immsv/management/Makefile.am | 2 +
tests/immsv/management/test_cleanup.c | 37 +
4 files changed, 50 insertions(+), 28
n
Samples n
Tests y
Other n
Comments (indicate scope for each y above):
-
changeset 17f712223cf801baca5e27ed4cbfd923dc2c15bc
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Mon, 13
Ack from me.
Tested the patch.
Best regards,
Zoran
-Original Message-
From: Anders Bjornerstedt [mailto:anders.bjornerst...@ericsson.com]
Sent: Friday, July 10, 2015 4:06 PM
To: reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 1 of 1] IMM:
Ack from me.
Not tested.
Best regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: Wednesday, July 01, 2015 4:16 PM
To: Anders Björnerstedt; Zoran Milinkovic; mahesh.va...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
osaf/services/saf/immsv/immnd/immnd_proc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/osaf/services/saf/immsv/immnd/immnd_proc.c
b/osaf/services/saf/immsv/immnd/immnd_proc.c
--- a/osaf/services/saf/immsv/immnd/immnd_proc.c
+++
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset ee50b8d0584694eedb080cbe0c982e9b69053db6
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Fri, 12 Jun 2015 14:50:25 +0200
NO_DANGLING references in
finalizeSync [#1381]
Ack with minor comments on ... the comments.
Not tested.
On 06/08/2015 05:00 PM, Zoran Milinkovic wrote:
osaf/services/saf/immsv/immnd/ImmModel.cc | 66
+++
1 files changed, 66 insertions(+), 0 deletions(-)
When all data
n
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset ea694b0d8469bcca0044f10b02b42556836ae393
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Mon, 08 Jun 2015 16:54:58 +0200
Ack from me.
Best regards,
Zoran
-Original Message-
From: Anders Björnerstedt
Sent: Thursday, June 04, 2015 6:22 PM
To: reddy.neelaka...@oracle.com; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1]
osaf/services/saf/immsv/immnd/ImmModel.cc | 66
Hi Hung,
I'll send a new patch to the review.
Anders pointed out to this problem in our phone conversation yesterday.
Best regards,
Zoran
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Friday, June 05, 2015 8:51 AM
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf
Ack from me.
Best regards,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Friday, June 05, 2015 6:21 AM
To: reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 1 of 1] imm: Check no-dangling map before
Hi Hung,
ommi-first != omi-second can be moved in for loop, just to follow the
pattern of other for and while loops.
You don't need to send new code for the review.
Best regards,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Friday, June 05,
osaf/libs/common/immsv/immpbe_dump.cc | 137 +-
osaf/libs/common/immsv/include/immpbe_dump.hh |3 +
osaf/tools/safimm/immdump/imm_dumper.cc | 38 ++-
3 files changed, 172 insertions(+), 6 deletions(-)
The patch covers only aditing no dangling
n
Other n
Comments (indicate scope for each y above):
-
changeset fd81e7d964c44042dd46f3b432fdb1ef36beb5a3
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Fri, 05 Jun 2015 14:43:51 +0200
immtools: audit
osaf/libs/common/immsv/immpbe_dump.cc | 125 +-
osaf/libs/common/immsv/include/immpbe_dump.hh |3 +
osaf/tools/safimm/immdump/imm_dumper.cc | 35 ++-
3 files changed, 156 insertions(+), 7 deletions(-)
The patch covers only aditing no dangling
n
Other n
Comments (indicate scope for each y above):
-
changeset 74a32d094b21762d5cd226a0f543134ad3d8b654
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Thu, 04 Jun 2015 14:09:20 +0200
immtools: audit
.
Best regards,
Zoran
-Original Message-
From: Anders Björnerstedt
Sent: Thursday, June 04, 2015 2:55 PM
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 1 of 1] immtools: audit no dangling references in
PBE file [#19]
Ack
Hi,
If immdump audit is successful, I'll add a sentence Audit successful to the
output.
Best regards,
Zoran
-Original Message-
From: Anders Björnerstedt
Sent: Thursday, June 04, 2015 2:55 PM
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Hi,
Anders and I have talked about the patch and had more-less same points as
Neelakanta mentioned in the review.
The patch has an impact on the performance, and it will affect every CCB (two
iterations), specially loading data.
The change could be done only for NO_DANGLING objects, changing
Ack from me.
Reviewed, but not tested.
Best regards,
Zoran
-Original Message-
From: Anders Björnerstedt
Sent: Wednesday, May 20, 2015 11:57 PM
To: reddy.neelaka...@oracle.com; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] IMM: Correction to support
Hi Neelakanta,
I'll add the line when I push the patch.
Best regards,
Zoran
-Original Message-
From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com]
Sent: Wednesday, May 13, 2015 11:38 AM
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1 of 1] imm
Hi Neelakanta,
Find my comments inline
-Original Message-
From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com]
Sent: Wednesday, May 13, 2015 1:33 PM
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1 of 1] immtools: add support for ccbObjectModify
Ack with a minor inline comment.
Best regards,
Zoran
-Original Message-
From: Anders Björnerstedt
Sent: Wednesday, May 06, 2015 4:37 PM
To: reddy.neelaka...@oracle.com; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] IMM: Support admin-op for aborting
Hi,
Agree to Neelakanta. IMMA should not depend on internal service protocol.
Only what is relevant for the library is a version.
New message types should be handled by IMM service.
Both IMM library and IMM service on a node come together with the same OpenSAF
version. It cannot happen that on
Nack from me.
Library should not rely on internal service protocol state.
New message types should be handled by IMM service.
Best regards,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Thursday, April 16, 2015 9:21 AM
To: Anders Björnerstedt
n
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset d14e3e33c290b853585a715ac9354d9acbdd3080
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Tue, 05 May 2015 14:28:44 +0200
osaf/services/saf/immsv/README | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
This patch clears missunderstandings for the lowerest and the highest OI
callback timeout set to IMMA_OI_CALLBACK_TIMEOUT.
diff --git a/osaf/services/saf/immsv/README
Ack from me.
Not tested. It's obvious that rc check is missing if isCmdLn is set to true.
Best regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: Tuesday, April 28, 2015 3:08 PM
To: Zoran Milinkovic
Cc: opensaf-devel
Ack from me.
Tested with immomtest and immoitest.
Best regards,
Zoran
-Original Message-
From: Anders Bjornerstedt [mailto:anders.bjornerst...@ericsson.com]
Sent: Monday, April 27, 2015 9:58 AM
To: reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel]
Hi Anders,
Ack from me with a minor comment.
Shouldn't the log message say ... Sync was killed ... instead of ... Sync
was aborted ... ?
Best regards,
Zoran
-Original Message-
From: Anders Björnerstedt
Sent: Thursday, April 09, 2015 7:04 AM
To: reddy.neelaka...@oracle.com; Zoran
Ack from me.
Not tested.
Best regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: Thursday, April 09, 2015 4:49 PM
To: Anders Björnerstedt; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm
osaf/libs/agents/saf/imma/imma_om_api.c |8 +-
osaf/libs/common/immsv/immsv_evt.c | 324 --
osaf/libs/common/immsv/include/immsv_evt.h |8 +-
osaf/libs/common/immsv/include/immsv_evt_model.h |5 +-
4 files changed, 126 insertions(+),
n
Comments (indicate scope for each y above):
-
changeset 5bf4a2ce84eacb8692030d27f2f6f017e13c20c7
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Fri, 27 Mar 2015 12:32:07 +0100
imm: revert #969 for IMM library [#1267
n
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset 98c9e0306edd28e3668339176c74896f6c9a11b3
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Wed, 25 Mar 2015 10:33:10 +0100
osaf/services/saf/immsv/immnd/ImmModel.cc | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
The patch fix the bug introduced in #643. With the path, when
SA_IMM_SEARCH_GET_ALL_ATTR flag is set, the result contains attributes.
diff --git a/osaf/services/saf/immsv/immnd/ImmModel.cc
Hi,
Find my comments inline.
-Original Message-
From: Anders Bjornerstedt [mailto:anders.bjornerst...@ericsson.com]
Sent: Wednesday, March 25, 2015 6:17 AM
To: reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 1 of 1] IMM: Add
osaf/services/saf/immsv/immnd/immnd_evt.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
Fix memory leak in search init
diff --git a/osaf/services/saf/immsv/immnd/immnd_evt.c
b/osaf/services/saf/immsv/immnd/immnd_evt.c
--- a/osaf/services/saf/immsv/immnd/immnd_evt.c
+++
osaf/tools/safimm/immadm/imm_admin.c | 2 +-
osaf/tools/safimm/immcfg/imm_cfg.c | 2 +-
osaf/tools/safimm/immcfg/imm_import.cc | 7 +--
osaf/tools/safimm/immdump/imm_xmlw_dump.cc | 9 +
osaf/tools/safimm/immfind/imm_find.c | 2 +-
osaf/services/saf/immsv/immloadd/imm_loader.cc | 11 +-
osaf/services/saf/immsv/immloadd/imm_pbe_load.cc |2 +-
osaf/services/saf/immsv/immnd/ImmModel.cc | 371 ++--
osaf/services/saf/immsv/immnd/ImmModel.hh |6 +-
Hi Anders,
I'll implement your comments before pushing the code.
Changes that you marked as 'spurious' are mostly done by a tool, and only
indentation is affected.
Thanks,
Zoran
-Original Message-
From: Anders Björnerstedt
Sent: Wednesday, March 11, 2015 1:31 PM
To: Zoran Milinkovic
Hi Anders,
I'll add description of the flag before pushing the code.
Thanks,
Zoran
-Original Message-
From: Anders Björnerstedt
Sent: Wednesday, March 11, 2015 1:30 PM
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH
tests/immsv/common/immtest.c | 4 +-
tests/immsv/implementer/Makefile.am | 1 +
tests/immsv/implementer/test_cleanup.c| 3 +
tests/immsv/implementer/test_saImmOiClassImplementerSet.c | 2 -
y
Other n
Comments (indicate scope for each y above):
-
changeset 57bcdde2358f69b5696fdd7002e3f1decd8da69d
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Tue, 10 Mar 2015 16:37:08 +0100
imm: add new API
Hi Neelakanta,
Reviewed the code.
Ack from me.
Best regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 3 mars 2015 06:38
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm: corrected
Hi Hung,
Reviewed the code.
Ack from me.
Best regards,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 27 februari 2015 04:14
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] immtools: Add wrapper functions
Hi Hung,
I'll remove those lines. They are not needed.
Best regards,
Zoran
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 26 februari 2015 12:16
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 2 of 4] imm: service support
Hi,
objectRdn is not needed at all. I'll remove objectRdn.
I'll replace:
attr-n.attrValue.val.x.buf = strndup(objectRdn.c_str(), objectRdn.size());
with
attr-n.attrValue.val.x.buf = strndup(req-objectName.buf, n);
Best regards,
Zoran
-Original Message-
From: Zoran Milinkovic
...@oracle.com]
Sent: den 24 februari 2015 16:11
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1 of 4] imm: add new API functions for replacement SaNameT
with SaStringT [#643]
Hi zoran,
Following are the review comments:
1. IMMND_EVT_A2ND_IMM_OI_INIT is not required
n
Comments (indicate scope for each y above):
-
changeset 544e3bb0accd13f4d28b4aab918dd6b6da352d02
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Wed, 25 Feb 2015 13:41:32 +0100
imm: change protocol 47 to protocol 46 [#969
osaf/libs/common/immsv/include/immsv_api.h | 2 +-
osaf/services/saf/immsv/immnd/ImmModel.cc | 12 ++--
osaf/services/saf/immsv/immnd/ImmModel.hh | 2 +-
osaf/services/saf/immsv/immnd/immnd_evt.c | 4 ++--
osaf/services/saf/immsv/immnd/immnd_init.h | 2 +-
5 files changed, 11
osaf/services/saf/immsv/immloadd/imm_loader.cc | 11 +-
osaf/services/saf/immsv/immloadd/imm_pbe_load.cc |2 +-
osaf/services/saf/immsv/immnd/ImmModel.cc | 500 +---
osaf/services/saf/immsv/immnd/immnd_evt.c | 21 +-
n
Other n
Comments (indicate scope for each y above):
-
changeset a82235a28c7687d7e131283a084c972cff457a05
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Tue, 10 Feb 2015 17:51:25 +0100
imm: add new API
tests/immsv/common/immtest.c | 4 +-
tests/immsv/implementer/Makefile.am | 1 +
tests/immsv/implementer/test_cleanup.c| 3 +
tests/immsv/implementer/test_saImmOiClassImplementerSet.c | 2 -
opensaf.spec.in |2 +
osaf/libs/agents/saf/imma/imma_cb.h |3 +
osaf/libs/agents/saf/imma/imma_def.h |2 +-
osaf/libs/agents/saf/imma/imma_oi_api.c | 324 +++--
osaf/libs/agents/saf/imma/imma_om_api.c |
osaf/tools/safimm/immadm/imm_admin.c | 2 +-
osaf/tools/safimm/immcfg/imm_cfg.c | 2 +-
osaf/tools/safimm/immcfg/imm_import.cc | 7 +--
osaf/tools/safimm/immdump/imm_xmlw_dump.cc | 9 +
osaf/tools/safimm/immfind/imm_find.c | 2 +-
osaf/services/saf/immsv/immloadd/imm_loader.cc | 11 +-
osaf/services/saf/immsv/immloadd/imm_pbe_load.cc |2 +-
osaf/services/saf/immsv/immnd/ImmModel.cc | 546 +---
osaf/services/saf/immsv/immnd/ImmModel.hh |1 +
osaf/libs/agents/saf/imma/imma_cb.h |3 +
osaf/libs/agents/saf/imma/imma_def.h |2 +-
osaf/libs/agents/saf/imma/imma_oi_api.c | 324 +++--
osaf/libs/agents/saf/imma/imma_om_api.c | 731 ++
tests/immsv/common/immtest.c | 4 +-
tests/immsv/implementer/Makefile.am | 1 +
tests/immsv/implementer/test_cleanup.c| 3 +
tests/immsv/implementer/test_saImmOiClassImplementerSet.c | 2 -
osaf/tools/safimm/immadm/imm_admin.c | 2 +-
osaf/tools/safimm/immcfg/imm_cfg.c | 2 +-
osaf/tools/safimm/immcfg/imm_import.cc | 7 +--
osaf/tools/safimm/immdump/imm_xmlw_dump.cc | 9 +
osaf/tools/safimm/immfind/imm_find.c | 2 +-
Ack from me.
Best regards,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 22 januari 2015 07:47
To: Anders Björnerstedt; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm : Added IMM_ERROR
Reviewed and built code with and without --enable-imm-pbe flag.
Ack from me.
Best regards,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 8 januari 2015 06:55
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 0 of 1
Reviewed and tested.
Ack from me.
Best regards,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 12 december 2014 13:39
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 0 of 1] Review Request for immtools: Support
osaf/services/saf/immsv/immnd/ImmModel.cc | 57 +++---
1 files changed, 44 insertions(+), 13 deletions(-)
In the first patch, a check for multivalue attributes was missed. This patch
adds that checks.
diff --git a/osaf/services/saf/immsv/immnd/ImmModel.cc
n
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset 87301a36ef17883289c91287d2dbacf148d906b3
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Fri, 21 Nov 2014 18:17:02
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset b67a51819f2a2c66c9b41fb0e11d3b96b26ebbff
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Thu, 20 Nov 2014 11:52:35 +0100
osaf/libs/agents/saf/imma/imma_proc.c | 30 +-
1 files changed, 29 insertions(+), 1 deletions(-)
The patch checks SaNameT attribute for extended names if extended names are not
enabled.
If any SaNameT attribute contains long DN, SA_AIS_ERR_NAME_TOO_LONG will be
401 - 500 of 678 matches
Mail list logo
