Re: [devel] [PATCH 2 of 4] AMFND: Admin operation continuation if csi completes during headless [#1725 part 1] V1

2016-09-15 Thread minh chau
-- >> From: Nagendra Kumar >> Sent: 15 September 2016 12:13 >> To: minh chau; hans.nordeb...@ericsson.com; Praveen Malviya; >> gary@dektech.com.au; long.hb.ngu...@dektech.com.au >> Cc: opensaf-devel@lists.sourceforge.net >> Subject: Re: [devel] [PATCH 2 of

Re: [devel] [PATCH 2 of 4] AMFND: Admin operation continuation if csi completes during headless [#1725 part 1] V1

2016-09-14 Thread minh chau
at model. > == > > Thanks > -Nagu > >> -Original Message- >> From: minh chau [mailto:minh.c...@dektech.com.au] >> Sent: 14 September 2016 17:05 >> To: Nagendra Kumar; hans.nordeb...@ericsson.com; Praveen Malviya; >&g

Re: [devel] [PATCH 2 of 4] AMFND: Admin operation continuation if csi completes during headless [#1725 part 1] V1

2016-09-14 Thread minh chau
st > cases" ? I can't see it in the test case doc. > > Thanks > -Nagu > >> -Original Message- >> From: Nagendra Kumar >> Sent: 13 September 2016 11:20 >> To: minh chau; hans.nordeb...@ericsson.com; Praveen Malviya; >> gary@dekte

Re: [devel] [PATCH 1 of 1] AMF: Fix SG unstable from admin continuation of nodegroup after headless [#1987] V2

2016-09-13 Thread minh chau
Hi Praveen, I think I can push the patch with ack from you since comments are targeted to future work. Just a few lines below. Thanks, Minh On 13/09/16 16:47, praveen malviya wrote: > Hi Minh, > > One minor comment, patch restores node->admin_ng pointers and for > clearing these pointers it

Re: [devel] [PATCH 0 of 1] Review Request for ntf: cluster rebooted with ntfd crashed on both controllers [#2006] V2

2016-09-12 Thread minh chau
ack for code review. Thanks, Minh On 12/09/16 12:41, Vu Minh Nguyen wrote: > Summary: ntf: cluster rebooted with ntfd crashed on both controllers [#2006] > V2 > Review request for Trac Ticket(s): #2006 > Peer Reviewer(s): NTF maintainers > Pull request to: <> > Affected branch(es): all >

Re: [devel] [PATCH 1 of 1] AMF: Fix SG unstable from admin continuation of nodegroup after headless [#1987]

2016-09-12 Thread minh chau
itialization sequence. > If you agree, please send quickly updated patch. > > Thanks, > Praveen > > On 12-Sep-16 2:57 PM, minh chau wrote: >> Hi Praveen, >> >> This is whole text documented in IMM README >> " >> Cac

Re: [devel] [PATCH 1 of 1] AMF: Fix SG unstable from admin continuation of nodegroup after headless [#1987]

2016-09-12 Thread minh chau
:20, praveen malviya wrote: > Hi Minh, > > Please see response inline. > > Thanks, > Praveen > > On 12-Sep-16 6:10 AM, minh chau wrote: >> Hi Praveen, >> >> Please find my comments with [Minh] >> >> Thanks, >> Minh >> >> On 09

Re: [devel] [PATCH 2 of 4] AMFND: Admin operation continuation if csi completes during headless [#1725 part 1] V1

2016-09-12 Thread minh chau
, minh chau wrote: > Hi Nagu, > > I'm running the tests with this configuration and will get back to you. > > Thanks, > Minh > > On 09/09/16 22:26, Nagendra Kumar wrote: >> Hi Minh, >> I am using 1725_pending_review.tgz >> (1725_02_V

Re: [devel] [PATCH 2 of 4] AMFND: Admin operation continuation if csi completes during headless [#1725 part 1] V1

2016-09-11 Thread minh chau
Hi Nagu, I'm running the tests with this configuration and will get back to you. Thanks, Minh On 09/09/16 22:26, Nagendra Kumar wrote: > Hi Minh, > I am using 1725_pending_review.tgz > (1725_02_V2_bugfix_01_resend_buffer_in_set_leds.diff, >

Re: [devel] [PATCH 1 of 1] AMF: Fix SG unstable from admin continuation of nodegroup after headless [#1987]

2016-09-11 Thread minh chau
Hi Praveen, Please find my comments with [Minh] Thanks, Minh On 09/09/16 21:57, praveen malviya wrote: > Hi Minh, > > Please find inline. > > Thanks, > Praveen > > On 09-Sep-16 4:30 PM, minh chau wrote: >> Hi Praveen, >> >> Please see comment

Re: [devel] [PATCH 1 of 1] AMFND: Fix amfnd coredump if sc failover while shutting down [#2008]

2016-09-09 Thread minh chau
Hi Praveen, I saw Hans gave ack on this #2008 yesterday so I pushed it this morning. As if it's simpler fix by introducing new flag then I think you can float another patch. Maybe it's after 5.1RC? Thanks, Minh On 09/09/16 17:22, praveen malviya wrote: > Hi, > > I saw the ticket is pushed. But

Re: [devel] [PATCH 1 of 1] AMF: Fix SG unstable from admin continuation of nodegroup after headless [#1987]

2016-09-09 Thread minh chau
Hi Praveen, Please see comment in line with [Minh] Thanks, Minh On 09/09/16 17:06, praveen malviya wrote: > Hi Minh, > > I could not understand why AMF should become implementer/applier earlier. [Minh]: We need to read osaAmfSGFsmState for differentiation of nodegroup operation while exploring

Re: [devel] [PATCH 0 of 1] Review Request for AMF: Fix SG unstable from admin continuation of nodegroup after headless [#1987]

2016-09-08 Thread minh chau
er n > > > Comments (indicate scope for each "y" above): > ----- > <> > > changeset 3a6bc0645a7d6ce8ce57f51271e0c129f6ecf0f4 > Author: minh-chau <minh.c...@dektech.com.au> > Date: Mon, 05 Sep 2016 09:19:14 +1000 > > AMF: Fix SG unstab

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

2016-09-07 Thread minh chau
anks, > Praveen > > On 05-Sep-16 5:07 AM, minh chau wrote: >> Hi Praveen, >> >> I think in all cases we need to restore @admin_ng, that can tell whether >> an admin operation on ng was executing. Also, we need to restore >> ng_using_saAmfSGAdminState in case 2N

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

2016-09-04 Thread minh chau
of case 1, then nodegroup operation continuation also works fine. I have sent out the patch for reivew, please check. Thanks, Minh On 01/09/16 18:11, praveen malviya wrote: > Hi Minh, > Please see response inline with [Praveen] > > Thanks, > Praveen > > > On 31-Aug-16 1

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

2016-08-30 Thread minh chau
. Thanks, Minh On 29/08/16 16:25, praveen malviya wrote: > Hi Minh, > > Please see inline with [Praveen] > > Thanks, > Praveen > > On 29-Aug-16 5:57 AM, minh chau wrote: >> Hi Praveen, >> >> Thanks for looking through the patch. >> The potential problem

Re: [devel] [PATCH 1 of 1] amfnd: cppcheck warnings with severity error [#1642]

2016-08-29 Thread minh chau
Ack, Thanks, Minh On 29/08/16 16:25, Long HB Nguyen wrote: > osaf/services/saf/amf/amfnd/cbq.cc | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > > diff --git a/osaf/services/saf/amf/amfnd/cbq.cc > b/osaf/services/saf/amf/amfnd/cbq.cc > --- a/osaf/services/saf/amf/amfnd/cbq.cc

Re: [devel] [PATCH 1 of 1] amfd: fix cppcheck errors [#1642]

2016-08-29 Thread minh chau
Ack Thanks,Minh On 29/08/16 16:13, Gary Lee wrote: > osaf/services/saf/amf/amfd/ckpt_enc.cc | 2 +- > osaf/services/saf/amf/amfd/ndproc.cc | 8 > osaf/services/saf/amf/amfd/role.cc | 3 +-- > 3 files changed, 6 insertions(+), 7 deletions(-) > > > fix cppcheck errors

Re: [devel] [PATCH 1 of 1] amfd: support NplusM model for supported admin ops on NG [#1454]

2016-08-29 Thread minh chau
le SG is >> mapped in NG is very less. So, as of now, in other models >> AVD_SG_FSM_SG_REALIGN states is used by keeping multiple SUs in oper >> list for this case also. >> But when SI deps, is completely supported with in SU in these models, >> then AMFD cannot use

Re: [devel] [PATCH 1 of 1] amfd: support NplusM model for supported admin ops on NG [#1454]

2016-08-29 Thread minh chau
Hi Praveen, Yes it's for #1454 and #1608 Thanks, Minh On 29/08/16 17:08, praveen malviya wrote: > Hi Minh, > > Thanks for reviewing and testing. > I guess the ack is for both #1454 and #1608. > I will add a note. > > > Thanks, > Praveen > > On 29-Aug-16 12:21 P

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

2016-08-28 Thread minh chau
Hi Nagu, Thanks for your time to verify the patches. Yes, versioning changes for AMFD-AMFD is not required, I will remove it before push Thanks, Minh On 26/08/16 22:13, Nagendra Kumar wrote: > Hi Minh, > Ack for patches (1725_01_V5_intro_new_rta_states_longDn.diff, >

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

2016-08-28 Thread minh chau
si_response_for_ng() is for tracking the state of admin > operation so that AMFD replies to IMM for admin operation and this is > not required after headless state. > > I think problem is not that much complex as it is valid for only 2N > models and only in case a). > >

Re: [devel] [PATCH 1 of 1] amfa: fixed freeing notification buff [#1642]

2016-08-25 Thread minh . chau
s, > Praveen > > > > On 26-Aug-16 7:35 AM, minh chau wrote: >> Hi Praveen, >> >> Just to confirm if I understand correctly the problem you mentioned in >> saAmfFinalize(). As the specification says application should call >> free()/Free_4() to release

Re: [devel] [PATCH 1 of 1] amfa: fixed freeing notification buff [#1642]

2016-08-25 Thread minh chau
ze() call to release all the resources. > > I think as of now please go ahead with your suggested solution. From > finalize perspective this is a defect and applicable to all the > branches. So please raise a ticket for that. > > Thanks, > Praveen > > >

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

2016-08-25 Thread minh chau
Hi, The test failed because two reasons: 1. There are two places that nodegroup operation borrows 2N SG FSM, but the AdminState of SG is not stored to IMM saAmfSGAdminState = ng->saAmfNGAdminState; ... su->sg_of_su->saAmfSGAdminState = SA_AMF_ADMIN_UNLOCKED; This setting needs to

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

2016-08-25 Thread minh chau
Hi Praveen, I think we need to come back a bit to non-headless feature. The cluster init timer expiry ensures all nodes having MW SUs assigned and node state are PRESENT. It's the unique entry point to non-ncs SU assignment phase. We also need to keep this principle in headless for #1725. ...

Re: [devel] Review Request for ntf: update PR documentation [#1952]

2016-08-25 Thread minh chau
Hi Vu, Ack from me for PR doc. I see this limitation still documented in README, but I think it's just fine to be there (under 4.5). You can also make another paragraph to say it's removed in 5.1. I'm ok with both, since nothing is interesting in 5.1 to say. Thanks, Minh On 25/08/16 12:39,

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

2016-08-24 Thread minh chau
Hi Nagu, Second thought, Praveen's one is better I think. You can try with his patch. Thanks Minh On 24/08/16 22:21, minh chau wrote: > Hi Nagu, > > Can you please apply the below patch on top of > 1725_02_V2_bugfix_resend_buffer_in_set_leds.diff? > In your test, PL3 get set_led

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

2016-08-24 Thread minh chau
Hi Nagu, Can you please apply the below patch on top of 1725_02_V2_bugfix_resend_buffer_in_set_leds.diff? In your test, PL3 get set_leds, but PL-4 has not, so SU2 can not respond su_si msg. @Praveen: Thanks for you help, I guess SU2 need to be ready to send su_si msg at the same as SU1. diff

Re: [devel] [PATCH 1 of 1] amfd: support NplusM model for supported admin ops on NG [#1454]

2016-08-24 Thread minh chau
think we could also see this kind of problem in future. Thanks, Minh On 23/08/16 16:58, praveen malviya wrote: > Hi Minh, > > I have attached patches for #1454 and #1608 in the ticket #1454. > Please apply them in order. > > Thanks, > Praveen > > On 23-Aug-16 11:56

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

2016-08-24 Thread minh chau
inh, > > Please see responses with [Praveen]. > > > Thanks, > Praveen > > On 23-Aug-16 7:18 PM, minh chau wrote: >> Hi Praveen, >> >> Please let me copy your questions and answer here in email, so it's >> easier we can add commen

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

2016-08-23 Thread minh chau
hanks, Praveen - On 23/08/16 21:03, minh chau wrote: > Hi Nagu, > > I see in the trace you provided, the SU2/SU3 become IN_SERVICE late. > If there's a delay in PL4 joining cluster after headless in your test > then you could also see it in the latest patches (longDN r

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

2016-08-23 Thread minh chau
e timers. What if AMFND starts some timer (larger value among cluster timer and node sync timer) on receiving AMFD up and on expiry of this timer sends the buffered assignment message. Thanks, Praveen Thanks, Praveen On 23-Aug-16 4:33 PM, minh chau wrote: Hi Nagu, I see in the trace you provid

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

2016-08-23 Thread minh chau
Hi Nagu, I see in the trace you provided, the SU2/SU3 become IN_SERVICE late. If there's a delay in PL4 joining cluster after headless in your test then you could also see it in the latest patches (longDN rebased version) I'm looking in to this issue. Thanks. Minh On 23/08/16 20:24, Nagendra

Re: [devel] [PATCH 1 of 1] amfd: support NplusM model for supported admin ops on NG [#1454]

2016-08-23 Thread minh chau
Hi Praveen, I will use them for test. Thanks, Minh On 23/08/16 16:58, praveen malviya wrote: > Hi Minh, > > I have attached patches for #1454 and #1608 in the ticket #1454. > Please apply them in order. > > Thanks, > Praveen > > On 23-Aug-16 11:56 AM, minh chau wrote:

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

2016-08-23 Thread minh chau
Hi Nagu, Please use the patches attached to ticket to test, there are many changes from the version you are testing. https://sourceforge.net/p/opensaf/tickets/_discuss/thread/7b203666/ad7f/attachment/1725_phase_1.tgz It's a rebased longDN version, so you will not have to tested again I just

Re: [devel] [PATCH 1 of 1] amfa: fixed freeing notification buff [#1642]

2016-08-23 Thread minh chau
em is coming. > But still all longdn patches can be pushed and this discussion can > continue. > > What do you think? > > > Thanks, > praveen > > > > On 22-Aug-16 12:08 PM, minh chau wrote: >> Hi Praveen, >> >> The case you just mentioned is stil

Re: [devel] [PATCH 1 of 1] amfd: support NplusM model for supported admin ops on NG [#1454]

2016-08-23 Thread minh chau
ith [Praveen] > > Thanks, > Praveen > > > > On 23-Aug-16 5:53 AM, minh chau wrote: >> Hi Praveen, >> >> One comment in line with [Minh] >> >> Thanks >> Minh >> >> On 20/07/16 18:57, praveen.malv...@oracle.com wrote: >>> osaf/servic

Re: [devel] [PATCH 1 of 1] amfd: support NplusM model for supported admin ops on NG [#1454]

2016-08-22 Thread minh chau
Hi Praveen, One comment in line with [Minh] Thanks Minh On 20/07/16 18:57, praveen.malv...@oracle.com wrote: > osaf/services/saf/amf/amfd/include/sg.h | 1 + > osaf/services/saf/amf/amfd/nodegroup.cc | 4 +- > osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 62 >

Re: [devel] [PATCH 1 of 1] ntfsv: refactor logging long dn notification [#1585]

2016-08-22 Thread minh chau
Hi Vu, Ack from me (tested) Thanks, Minh On 16/08/16 13:30, Vu Minh Nguyen wrote: > Hi all, > > Do you have any comments on the updated patch (update test code)? Thanks. > > Regards, Vu > >> -Original Message- >> From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] >> Sent:

Re: [devel] [PATCH 1 of 1] amfa: fixed freeing notification buff [#1642]

2016-08-22 Thread minh chau
re not fully implemented, agent copies from old > type of structure to new type in ava_cpy_protection_group_ntf(). > > > Thanks, > Praveen > > On 22-Aug-16 10:51 AM, minh chau wrote: >> Hi Praveen, >> >> The problem with B.04.01 is the API: >> saAmfProtection

Re: [devel] [PATCH 1 of 1] amfa: fixed freeing notification buff [#1642]

2016-08-21 Thread minh chau
cumented. > > > Thanks, > Praveen > > > On 20-Aug-16 2:22 PM, minh chau wrote: >> Hi Long, Praveen, >> >> Regarding this TODO >> + if(notification) { >> +// TODO (minhchau): memleak if notification is an array >> + osaf_extended_na

Re: [devel] [PATCH 1 of 1] amfa: fixed freeing notification buff [#1642]

2016-08-20 Thread minh chau
Hi Long, Praveen, Regarding this TODO + if(notification) { +// TODO (minhchau): memleak if notification is an array +osaf_extended_name_free(>member.compName); free(notification); + } Client currently uses saAmfProtectionGroupNotificationFree_4(handle, buff->notification) to

Re: [devel] [PATCH 4 of 4] AMFD: Validate headless cached RTA read from IMM [#1725]

2016-08-19 Thread minh chau
Hi Praveen, I attached them to ticket. Thanks, Minh On 19/08/16 21:08, praveen malviya wrote: > Hi Minh, > All patches are not received. > Please attached them in the ticket. > > Thanks, > Praveen > > On 18-Aug-16 5:45 AM, Minh Hon Chau wrote: >> osaf/services/saf/amf/amfd/include/sg.h | 4

Re: [devel] [PATCH 1 of 1] amfd: mark stby_sync_state out of sync if peer amfd is absent [#1850]

2016-08-17 Thread minh chau
Ack from me (code review only) Thanks, Minh On 17/08/16 16:39, Nagendra Kumar wrote: > Hi Minh, > Please change cb to avd_cb and then test. Sorry for the typo. > > Thanks > -Nagu > >> -Original Message- >> From: minh chau [mailto:minh.c...@dekt

Re: [devel] [PATCH 1 of 1] amfd: mark stby_sync_state out of sync if peer amfd is absent [#1850]

2016-08-17 Thread minh chau
Hi Nagu, I think I can just replace "cb" by "avd_cb", and testing the patch. Then you can correct it later. Thanks, Minh On 17/08/16 12:50, minh chau wrote: > Hi Nagu, > > I got this. > > CXX osafamfd-sg_2n_fsm.o > CXX osafamfd-sg_nored_fs

Re: [devel] [PATCH 1 of 1] amfd: mark stby_sync_state out of sync if peer amfd is absent [#1850]

2016-08-16 Thread minh chau
Hi Nagu, I got this. CXX osafamfd-sg_2n_fsm.o CXX osafamfd-sg_nored_fsm.o sg_2n_fsm.cc: In member function ‘virtual SaAisErrorT SG_2N::si_swap(AVD_SI*, SaInvocationT)’: sg_2n_fsm.cc:775:6: error: ‘cb’ was not declared in this scope ((cb->node_id_avd_other != 0) &&

Re: [devel] [PATCH 0 of 2] Review Request for AMF: Support admin operation continuation after headless [#1725 Part 1] V2

2016-08-12 Thread minh chau
Hi Nagu, Praveen, Can you please give me comments if you have any so far, that would help me revise some codes first while you can continue reviewing? There are some changes in SG codes, I hope it doesn't break the SG's existing logic. Thanks, Minh On 05/08/16 07:20, Minh Hon Chau wrote: >

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

2016-08-10 Thread minh chau
Hi Nagu, Have you enabled IMM schema changes and adding these new attributes before upgrade? This could be tested in the same way as previous additional attributes were introduced as before. Thanks, Minh On 10/08/16 21:10, Nagendra Kumar wrote: > Hi Minh, > > I was doing upgrade and

Re: [devel] [PATCH 1 of 1] amfd: do not send duplicate removal of assignment, 2N model [#1772]

2016-08-08 Thread minh chau
Hi Praveen, This patch has also fixed the coredump in the other tests are failing in test report of #1725 part 1, which are 14, 64, 68, 84, 124, 128 In the above test cases, still get "ER avd_sg_su_oper_list_del: su not found". Can we change ER to WA? Ack from me with this minor comment.

Re: [devel] [PATCH 2 of 2] AMFND: Admin operation continuation if csi callback completes during headless [#1725 part 1] V1

2016-08-04 Thread minh chau
Hi Praveen, There's a bug in V1 at AMFD side, so I floated V2. The change is commented in V2: " This V2 avoid AMFD crash if scAbsence is not configured. V2's diff (from V1) is at avd_process_state_info_queue() " So latest patches are below: [PATCH 0 of 2] Review Request for AMF: Support admin

Re: [devel] [PATCH 1 of 1] AMFD: Initialize CLM, NTF handle in thread [#1828]

2016-07-26 Thread minh chau
Hi Mathi, I noticed that #1781 has moved the CLM init before amfd get assigned role. Would you be happy if I change amfd to make it does CLM init when it actually gets active/standby role? Thanks, Minh On 25/07/16 11:25, minh chau wrote: > I mean "... no objection ..." >

Re: [devel] [PATCH 1 of 1] AMFD: Initialize CLM, NTF handle in thread [#1828]

2016-07-24 Thread minh chau
I mean "... no objection ..." Thanks, Minh On 25/07/16 10:53, minh chau wrote: > Hi, > > I have tried to reproduce the problem in #1781, when amfd in > non-member node gets assigned role, amfd initializes CLM successfully. > Only sfmd, cpkt got UNAVAILABLE from saClmCl

Re: [devel] [PATCH 1 of 1] ntfsv: refactor logging long dn notification [#1585]

2016-07-24 Thread minh chau
Hi Vu, The patch looks good. Can I test this patch after #1315 is pushed? I run into osaf_abort() for now. Thanks, Minh On 22/07/16 21:16, Vu Minh Nguyen wrote: > osaf/services/saf/ntfsv/ntfs/NtfLogger.cc | 51 > +++--- > 1 files changed, 13 insertions(+), 38

Re: [devel] [PATCH 1 of 1] AMFD: Initialize CLM, NTF handle in thread [#1828]

2016-07-24 Thread minh chau
s also a small possibility that a bug causes the handle to simply not >>> work. A "fresh", newly initialized handle would be safer than a >>> one-year >>> old handle. >>> >>> Do you think it would work if you defer creating these ba

Re: [devel] [PATCH 1 of 1] AMFD: Initialize CLM, NTF handle in thread [#1828]

2016-07-22 Thread minh chau
Hi, I think Praveen's comment on #1812 was worrying about amfd hanging when init with CLM, this patch does not change position of CLM initialization and also it's done in thread so it will be ok? Regarding Anders' comment: I did quick test, lock clm on standby controller and reboot it, when it

Re: [devel] [PATCH 1 of 1] amfd: allow lock and unlock operation on NoRed MW SI. [#1834]

2016-07-08 Thread minh chau
On 08/07/16 16:05, praveen malviya wrote: > > > On 07-Jul-16 6:31 PM, minh chau wrote: >> Hi Praveen, >> >> NoRed MW allows locking SU only, and not allow locking SI, which means >> to me if NoRed MW SUs are unlocked it must provide its services (SMFND, >&

Re: [devel] [PATCH 1 of 1] amfd: allow lock and unlock operation on NoRed MW SI. [#1834]

2016-07-07 Thread minh chau
Hi Praveen, NoRed MW allows locking SU only, and not allow locking SI, which means to me if NoRed MW SUs are unlocked it must provide its services (SMFND, IMMND, CPND, CLMNA) I'm not sure whether this is a must-have requirement or not, since this behavior has existed for long. Thanks, Minh

Re: [devel] [PATCH 1 of 1] amfd: avoid resetting alarm for duplicate node ups [#1893]

2016-06-27 Thread minh . chau
t. > > Thanks > -Nagu >> -Original Message- >> From: minh chau [mailto:minh.c...@dektech.com.au] >> Sent: 27 June 2016 07:42 >> To: Nagendra Kumar; hans.nordeb...@ericsson.com; Praveen Malviya; >> gary@dektech.com.au >> Cc: opensaf-devel@lists.sourcefo

Re: [devel] [PATCH 1 of 1] amfd: avoid resetting alarm for duplicate node ups [#1893]

2016-06-26 Thread minh chau
Hi Nagu, Patch looks good. Can we think an alternative that condition of calling avd_process_state_info_queue() by checking node_state as AVD_AVND_STATE_ABSENT, so that we don't have to introduce new static var? Thanks, Minh On 23/06/16 20:45, nagendr...@oracle.com wrote: >

Re: [devel] [PATCH 1 of 1] AMFD: Update RTA saAmfSUHostedByNode after headless [#1720] V2

2016-06-08 Thread minh chau
Hi Praveen, saAmfSUHostedByNode should be cold synced after headless. The avd_process_state_info_queue() is called before active amfd creates Opensaf-2N assignment for SCs. The standby assignment for Opensaf-2N on standby controller includes RDE csi which then set node role as standby, thus

Re: [devel] [PATCH 1 of 1] ntfa: Lower intialize req message [#1818] V2

2016-06-05 Thread minh chau
Hi Lennart, I'm not sure what the comment "fixme?" intended to fix, but it seems not giving any information about the bug to be fixed, so I remove it Please help to push the attached patch. Thanks, Minh On 03/06/16 23:53, Lennart Lund wrote: Ack Review only. Comment: Is the "/* fixme? */"

Re: [devel] [PATCH 1 of 1] amfnd: ignore hc expiry in unhealthy state [#1858]

2016-06-01 Thread minh chau
Hi Nagu, Ack from me, not tested because I could not reproduce. Thanks, Minh On 01/06/16 22:32, nagendr...@oracle.com wrote: > osaf/services/saf/amf/amfnd/chc.cc | 10 ++ > 1 files changed, 10 insertions(+), 0 deletions(-) > > > If the component is not in instantiated state, then hc

Re: [devel] [PATCH 1 of 1] amfnd: fix COMP-FO recovery when cleanup time is more than sufailoverprob[#1839]

2016-05-23 Thread minh chau
Ack from me with a *missing place* to be updated Thanks, Minh On 23/05/16 16:52, praveen malviya wrote: > Hi All, > > I would like to push this patch today. > Please provide feedback. > > Thanks, > Praveen > > On 20-May-16 2:07 PM, praveen malviya wrote: >> >&

Re: [devel] [PATCH 1 of 1] ntfa: Lower mds priority for initialize msg [#1818]

2016-05-20 Thread minh . chau
Hi, This patch was aimed to fix the problem in test of running multiple api life cycle parallel. But now I realise there is still same problem due to mailbox priority at ntfd side. I will have to check and refloat another patch Thanks, Minh > > > On 16-May-16 7:04 AM, minh chau wro

Re: [devel] [PATCH 1 of 1] amfnd: fix COMP-FO recovery when cleanup time is more than sufailoverprob[#1839]

2016-05-20 Thread minh chau
Hi Praveen, I have tested the patch, it fixes the reported issue. The problem seems to be a data race condition between thread handling clc fsm and timer expiry thread which reset all variables of a su while these variables have being used elsewhere in clc fsm. This race condition should cause

Re: [devel] [PATCH 1 of 1] ntf: To change log severity level from LOG_ER to LOG_NO [#1832]

2016-05-19 Thread minh chau
ack On 19/05/16 13:47, Nhat Pham wrote: > osaf/services/saf/ntfsv/ntfs/NtfLogger.cc | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > During testing SC failover, the following ER log sometimes happens. > > ER Failed to log an alarm or security alarm notification (6) > > The

Re: [devel] [PATCH 1 of 1] ntfa: Lower mds priority for initialize msg [#1818]

2016-05-15 Thread minh chau
Hi Praveen, Please see comments in line. Thanks, Minh On 13/05/16 17:17, praveen malviya wrote: > Hi Minh, > > I am trying to understand the problem. > > As per these ntfd traces, in the down event at below at 3) ntfd clears > the client data so subsequent requests for Unsubscribe() and >

Re: [devel] [PATCH 1 of 1] NTFA: Update server state NTFA_NTFSV_NEW_ACTIVE to NTFA_NTFSV_UP at failover [#1785]

2016-04-29 Thread minh chau
Hi Lennart, I don't know how to test this, probably repeatedly sending notification during failover. The code is quite clear to see the only place that server state changes to NTFA_NTFS_NEW_ACTIVE is at switch-case of NTFA_NTFS_NONE. Can you please help to push this? This bug makes agent bad

Re: [devel] [PATCH 1 of 1] NTFA: Update server state NTFA_NTFSV_NEW_ACTIVE to NTFA_NTFSV_UP at failover [#1785]

2016-04-28 Thread minh chau
Hi Praveen, Yes this is problem that agent coming up during failover, the server state then set as NTFA_NTFSV_NEW_ACTIVE. At this state, server state will never set to NTFA_NTFSV_UP because the implementation treats NTFA_NTFSV_NEW_ACTIVE as NTFA_NTFSV_UP, since at both of those states NTF

Re: [devel] [PATCH 1 of 1] amfnd: mark SU RESTARTING in comp FSM during restart of comps [#1752] V2

2016-04-27 Thread minh chau
Ack from me Thanks, Minh On 27/04/16 16:17, praveen.malv...@oracle.com wrote: > osaf/services/saf/amf/amfnd/clc.cc| 73 > ++- > osaf/services/saf/amf/amfnd/include/avnd_su.h | 2 + > osaf/services/saf/amf/amfnd/susm.cc | 10 ++- > 3 files

Re: [devel] [PATCH 1 of 1] amfnd: mark SU RESTARTING in comp FSM during restart of comp(s) [#1752]

2016-04-26 Thread minh chau
sed in comp FSM as the current COMPCSI will be marked > RESTARTING in comp_restart_init() very lately. At most for comp FSM , > the for loop in discussion can be moved in a function like > all_csis_in_restarting_execpt_given(su, csi). > > Thanks, > Praveen > > On 26-Apr-16 3:24 PM, mi

Re: [devel] [PATCH 1 of 1] ntfa: return ERR_UNAVAILABLE on non-member node after headless state [#1744]

2016-04-21 Thread minh chau
CLM indication or b)when we have more > clarity on CLM status of nodes during headless. > > Attached patch in on top of #1744 patch and it fixes ntfsubscribe also > to call saNTfFinalise() and exit on receiving ERR_UNAVAILABLE.I would > like to push 1744 before RC2. > > T

Re: [devel] [PATCH 1 of 1] ntfa: return ERR_UNAVAILABLE on non-member node after headless state [#1744]

2016-04-20 Thread minh chau
, and that should be documented. Thanks, Minh On 14/04/16 07:01, minh chau wrote: > > > On 13/04/16 15:43, praveen malviya wrote: >> >> >> On 12-Apr-16 10:24 PM, minh chau wrote: >>> >>> >>> On 12/04/16 21:49, praveen malviya wrote: >>

Re: [devel] [PATCH 1 of 1] ntfa: return ERR_UNAVAILABLE on non-member node after headless state [#1744]

2016-04-13 Thread minh chau
On 13/04/16 15:43, praveen malviya wrote: > > > On 12-Apr-16 10:24 PM, minh chau wrote: >> >> >> On 12/04/16 21:49, praveen malviya wrote: >>> >>> >>> On 12-Apr-16 3:56 PM, minh chau wrote: >>>> Hi Praveen >>&g

Re: [devel] [PATCH 1 of 1] ntfa: return ERR_UNAVAILABLE on non-member node after headless state [#1744]

2016-04-12 Thread minh chau
On 12/04/16 21:49, praveen malviya wrote: > > > On 12-Apr-16 3:56 PM, minh chau wrote: >> Hi Praveen >> >> NTF server also accepts initialize request (and here it comes from >> reinitializeClient() after headless) if NTF server has not initialized

Re: [devel] [PATCH 1 of 1] ntfa: return ERR_UNAVAILABLE on non-member node after headless state [#1744]

2016-04-12 Thread minh chau
Hi Praveen NTF server also accepts initialize request (and here it comes from reinitializeClient() after headless) if NTF server has not initialized with CLM. So after headless, this situation will most likely happen. The recovery would succeeds, but after that what if NTF server notifies the

Re: [devel] [PATCH 1 of 1] AMFND: Do not disable healthy SU [#1721]

2016-04-11 Thread minh chau
Hi Praveen Please see comments inline Thanks, Minh On 11/04/16 16:13, praveen malviya wrote: > > On 07-Apr-16 7:17 PM, Minh Hon Chau wrote: >> osaf/services/saf/amf/amfnd/su.cc | 5 - >> 1 files changed, 0 insertions(+), 5 deletions(-) >> >> >> Currently avnd_su_curr_info_del() is

Re: [devel] NTF PR doc update for #1639.

2016-04-07 Thread minh chau
Hi, Ack with comments: - The statement of 5) seems to be included in 2), maybe can combine 2) and 5) - Since ERR_UNAVAILABLE could be returned in A.02.01, PR doc should recommend what's client's behavior when receiving this error code, eg. try API again since node has not joined cluster, or

Re: [devel] [PATCH 1 of 1] amfnd: return TRY_AGAIN for saAmfProtectionGroupTrack and saAmfProtectionGroupTrackStop while headless [#1718]

2016-04-07 Thread minh chau
Ack from me Thanks, Minh On 07/04/16 13:53, Gary Lee wrote: > osaf/services/saf/amf/amfnd/pg.cc | 18 ++ > 1 files changed, 18 insertions(+), 0 deletions(-) > > > return TRY_AGAIN for saAmfProtectionGroupTrack and > saAmfProtectionGroupTrackStop > while headless, since

Re: [devel] AMF PR doc for #1533.

2016-04-07 Thread minh chau
Ack with minor comment: In first page, do we need to update " Release 4.7 Programmer's Reference October 2015"? Thanks, Minh On 07/04/16 16:12, praveen malviya wrote: > Hi All, > > Please find attached AMF PR doc updated for #1533. > Only one minor change is done in section 2.2.10.1 Scope of

Re: [devel] [PATCH 2 of 5] NTF: Add support cloud resilience for NTF Agent [#1180] V3

2016-03-19 Thread minh chau
iginal Message- >> From: Minh Chau H >> Sent: den 16 mars 2016 15:58 >> To: Lennart Lund; praveen.malv...@oracle.com; Vu Minh Nguyen >> Cc: opensaf-devel@lists.sourceforge.net; Anders Widell; Minh Chau H >> Subject: Re: [PATCH 2 of 5] NTF: Add support clou

Re: [devel] [PATCH 2 of 5] NTF: Add support cloud resilience for NTF Agent [#1180] V3

2016-03-19 Thread minh chau
_t structure seems not being used at all. I think refactoring object orientation would give a support to the idea of implementation of cb handler as above. If this sounds right to you, there seems to be some things to do > > Thanks > Lennart > >> -Original Message---

Re: [devel] [PATCH 2 of 5] NTF: Add support cloud resilience for NTF Agent [#1180] V3

2016-03-14 Thread minh chau
issues. > > Thanks > Lennart > >> -Original Message- >> From: Minh Hon Chau [mailto:minh.c...@dektech.com.au] >> Sent: den 14 mars 2016 03:08 >> To: Lennart Lund; praveen.malv...@oracle.com; Vu Minh Nguyen; Minh >> Chau H >> Cc: opensaf-devel@

Re: [devel] [PATCH 01 of 15] amfd: Add support for cloud resilience at common libs [#1620]

2016-03-14 Thread minh chau
Hi Nagu, Praveen Since #1-#4 have been acked, can you please push them? #5 and #11_2 allows comp/su failover during headless, so we may have to visit them later. However, the patches: #9 #10 #11_1 #12 #13 are bug fixes that does not relate to *delayed failover* and needed for #1-#4. Can you

Re: [devel] Proof Of Concept patch reusing SG FSM code for better handling of transient nodes during headless state(was Re: [PATCH 01 of 15] amfd: Add support for cloud resilience at common libs [#162

2016-03-11 Thread minh chau
On 11/03/16 17:23, praveen malviya wrote: > > > On 10-Mar-16 5:31 PM, minh chau wrote: >> To clarify my doubts: These sg fsm code are working in non-headless in >> the way it prevents user issue a new admin op while the previous admin >> op has been in progress, beca

Re: [devel] Proof Of Concept patch reusing SG FSM code for better handling of transient nodes during headless state(was Re: [PATCH 01 of 15] amfd: Add support for cloud resilience at common libs [#162

2016-03-10 Thread minh chau
is issued, then faulty su happens during assignment. But after headless, everything had already happened so how these fsm code will be called in the right order (or running concurrently) on all entities while sharing one fsm state. Thanks, Minh On 10/03/16 16:13, minh chau wrote: > Hi Prav

Re: [devel] [PATCH 0 of 5] Review Request for Add cloud resilience support [#1180] V2

2016-03-09 Thread minh chau
> >> -Original Message- >> From: minh chau [mailto:minh.c...@dektech.com.au] >> Sent: den 4 mars 2016 09:40 >> To: Lennart Lund; praveen.malv...@oracle.com; Vu Minh Nguyen >> Cc: opensaf-devel@lists.sourceforge.net >> Subject: Re: [PATCH 0 of 5] Revi

Re: [devel] Proof Of Concept patch reusing SG FSM code for better handling of transient nodes during headless state(was Re: [PATCH 01 of 15] amfd: Add support for cloud resilience at common libs [#162

2016-03-09 Thread minh chau
e at the time of controller down and resuming SG in the same >> state. >> 4)There are FIVE SG FSM states in our code out of which STABLE >> state of SG is not applicable for transition state. So there are only >> FOUR SG fsm states to be resumed. >> >> No

Re: [devel] [PATCH 01 of 15] amfd: Add support for cloud resilience at common libs [#1620]

2016-03-04 Thread minh chau
Hi Nagu, From your test description TC#1, it says SU2 hosted on SC-2. And after SC-1 comes back, SU2 on PL-4 gets assignment. This description is symptom of su mapping issue which is addressed in patch 11_1. But now looking at the trace file, SU2 is being hosted in PL-4 actually (not as in

Re: [devel] [PATCH 01 of 15] amfd: Add support for cloud resilience at common libs [#1620]

2016-03-03 Thread minh chau
of v1 on amfd patch. Those are important comments and needs > to be addressed. [Minh] We have received 2 emails for comments on V2 so far and all of those had been responded. In V4 we have corrected patches according to some of your comments Belows are date time of responses were sent Date:

Re: [devel] [PATCH 01 of 15] amfd: Add support for cloud resilience at common libs [#1620]

2016-03-02 Thread minh chau
sient SUSI. The difference is decision to be made, one can reboot the node, another can adjust the state. Though it seems rebooting node will loose the availability? Thanks, Minh On 03/03/16 11:32, minh chau wrote: > Hi Nagu, Praveen > > From patch 09 to patch 14, they are fixes for bugs

Re: [devel] [PATCH 01 of 15] amfd: Add support for cloud resilience at common libs [#1620]

2016-03-02 Thread minh chau
Hi Nagu, Praveen From patch 09 to patch 14, they are fixes for bugs that you also need on top of patches #4. The problems you reported should not happen if you have them. They are regardless whether we *reboot node if transient states* or *adjust transient states* (delayed failover). Patch

Re: [devel] [PATCH 04 of 15] amfnd: Add support for cloud resilience at node director [#1620]

2016-03-02 Thread minh chau
>>> >>> Quoting Mathivanan Naickan Palanivelu <mathi.naic...@oracle.com>: >>> >>>> Hi All, >>>> >>>> What is 'delayed failover'? That sounds against the principles of >>>> 'software fault isolation'!? >>>>

Re: [devel] [PATCH 04 of 15] amfnd: Add support for cloud resilience at node director [#1620]

2016-03-01 Thread minh chau
Hi Praveen, Please see comments in line [Minh] Thanks, Minh On 02/03/16 18:12, praveen malviya wrote: > > > On 02-Mar-16 12:26 PM, minh chau wrote: >> Hi Praveen, >> >> If node_up of amfnd comes after node sync timer expires, amfd will send >> reboot message

Re: [devel] [PATCH 04 of 15] amfnd: Add support for cloud resilience at node director [#1620]

2016-03-01 Thread minh chau
Hi Praveen, If node_up of amfnd comes after node sync timer expires, amfd will send reboot message to that amfnd, regardless of susi states. Sending reboot message in avd_comp_pres_state_set() if comp is inst/term-failed has already been in code base of #1620. The change in #1620 that marks

Re: [devel] [PATCH 1 of 5] NTF: Add support cloud resilience for NTF Agent [#1180]

2016-02-28 Thread minh chau
Hi Vu, Please see comments in line with [Minh] Thanks, Minh On 25/02/16 17:57, Vu Minh Nguyen wrote: > Hi Minh, > > I have few comments below [Vu] and one question. > > I see, in some places, NTF APIs not always return TRY_AGAIN if both SCs > down. > I am not sure if I feel correctly or not. >

Re: [devel] [PATCH 03 of 15] amfd: Add support for cloud resilience at director [#1620]

2016-02-25 Thread minh chau
Hi, I made a mistake in rebase the patch, that I reverted fix of #1595 (the last diff) I'll remove that last diff in next version. Thanks, Minh On 25/02/16 19:44, Minh Hon Chau wrote: > osaf/services/saf/amf/amfd/cluster.cc| 48 +++- > osaf/services/saf/amf/amfd/comp.cc

Re: [devel] [PATCH 2 of 5] amfd: Add support for cloud resilience at director [#1620] V2

2016-02-25 Thread minh chau
Hi Praveen, We have been lost in emails of #1620, sorry for late reply. V4 has been sent out though your comments here are still valid on V4. So please find our comments inline with [Gary] and [Minh] Thanks, Gary/Minh On 11/02/16 22:15, praveen malviya wrote: > Hi Minh, > > Please find some

Re: [devel] [PATCH 0 of 5] Review Request for amf: Add support for cloud resilience [#1620] V2

2016-02-22 Thread minh chau
Hi Nagu, Attached patch is for TC 41, 42. We have noticed one bug in sidep, will update it soon. Thanks, Minh On 22/02/16 23:48, Hans Nordebäck wrote: Hi, please see enclosed patch for TC #1, #6, #7, #8, #9, #10 and #11/Thanks HansN On 02/19/2016 10:09 AM, minh chau wrote: Hi Nagu

<    1   2   3   4   5   >