Summary: amf: Buffer and resend data req messages in Headless state [#2601]
Review request for Ticket(s): 2601
Peer Reviewer(s): minh.c...@dektech.com.au, hans.nordeb...@ericsson.com,
gary....@dektech.com.au
Pull request to: Myself
Affected branch(es): develop
Development branch: ticket-2601
Base revision: e7fb995f41a4bfabe3d1e48bda3ba004e2935074
Personal repository: git://git.code.sf.net/u/ravi-sekhar/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
NOTE: Patch(es) contain lines longer than 80 characers
Comments (indicate scope for each "y" above):
---------------------------------------------
Issue:
After Headless scenario, once AMFND receives AMFD up event, if data Req
messages are generated(due to any SU faults) at AMFND it sends to AMFD by
incrementing cb->msg_id
AMFD processes Messages only after sendig Set_LED evet to all AMFNDs, and it
expects messages with Messages Id 2 onwards(AMFND_Node_up will set the msg_id
to 1).
After receving set_led event, AMFND is sending messages with msg_id > 2 as it
has already incremented msg_id counter for data Req messages before
But at AMFD is expecting messages with msg_id starting from 2. As Message id
won't match as expected, AMFD dropts all the messages
Solution:
During Headless, buffer the Data req Messages also by resetting the msg_id to
0
After receiving set_led evt, deque the buffered messages assignt the current
msg_id and send it it AMFD
revision 61dc8231d7ad6d0329bb77c9db25a52eeda0b604
Author: ravi-sekhar <ravisekhar.ko...@oracle.com>
Date: Tue, 17 Oct 2017 17:01:14 +0530
amf: Buffer and resend data req messages in Headless state [#2601]
Complete diffstat:
------------------
src/amf/amfnd/di.cc | 42 +++++++++++++++++++++++++++++++-----------
1 file changed, 31 insertions(+), 11 deletions(-)
Testing Commands:
-----------------
As specified in Ticket
Testing, Expected Results:
--------------------------
After Headless, once AMFD sends set_led to all AMFNDS, there should not be any
missmatch in the msg_id from AMFND to AMFD
Conditions of Submission:
-------------------------
*** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC ***
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
