Summary: imm: not allow creating reserved IMM class names [#2771]
Review request for Ticket(s): 2771
Peer Reviewer(s): Zoran, Ravi
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop, release
Development branch: ticket-2771
Base revision: 81ef74a531f84720fd905d25e3d06b1ff799f83d
Personal repository: git://git.code.sf.net/u/winhvu/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 8be516e90d971b3fc3e100c8f1f45d251e3a8003
Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>
Date: Tue, 30 Jan 2018 21:11:48 +0700
imm: not allow creating reserved IMM class names [#2771]
PBE will be restarted and will not be able to come up if user requests
creating IMM object class with same name of reserved ones.
This patch adds code to reject such request with SA_AIS_ERR_INVALID_PARAM.
Added Files:
------------
src/imm/immnd/immnd_common.c
src/imm/immnd/immnd_common.h
Complete diffstat:
------------------
src/imm/Makefile.am | 2 +
src/imm/agent/imma_om_api.cc | 1 -
.../apitest/management/test_saImmOmClassCreate_2.c | 48 +++++++++++
src/imm/immnd/ImmModel.cc | 55 +-----------
src/imm/immnd/immnd.conf | 9 ++
src/imm/immnd/immnd_cb.h | 1 +
src/imm/immnd/immnd_common.c | 75 ++++++++++++++++
src/imm/immnd/immnd_common.h | 32 +++++++
src/imm/immnd/immnd_evt.c | 17 ++++
src/imm/immnd/immnd_main.c | 99 +++++++++++++++++++++-
10 files changed, 285 insertions(+), 54 deletions(-)
Testing Commands:
-----------------
Run added tests `immomtest 2 19`, `immomtest 2 20`.
Testing, Expected Results:
--------------------------
Tests PASS
Conditions of Submission:
-------------------------
Ack from peer reviewers
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
