Summary: log: duplicated code in lga_client and lga_stream [#2567] Review request for Ticket(s): 2567 Peer Reviewer(s): Lennart, Canh, Mahesh Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2567 Base revision: 2b65ecdaac6d0b80073149f137b0744aeeb6582b Personal repository: git://git.code.sf.net/u/winhvu/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision c79ece5853a201d2664709fab2f0f4a7569b1b5d Author: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Date: Fri, 1 Sep 2017 12:09:34 +0700 log: duplicated code in lga_client and lga_stream [#2567] Introduce `RefCounter` class to remove duplicated code in LogClient and LogStreamInfo. Introduce also one new parameter `caller`, the purpose is mainly for debug - know who is the caller to `RefCounter` methods. Added Files: ------------ src/log/agent/lga_ref_counter.cc src/log/agent/lga_ref_counter.h Complete diffstat: ------------------ src/log/Makefile.am | 5 +- src/log/agent/lga_agent.cc | 82 +++++++++++++++------------ src/log/agent/lga_client.cc | 62 ++++----------------- src/log/agent/lga_client.h | 45 ++++++++------- src/log/agent/lga_common.h | 8 --- src/log/agent/lga_mds.cc | 7 +-- src/log/agent/lga_ref_counter.cc | 73 ++++++++++++++++++++++++ src/log/agent/lga_ref_counter.h | 117 +++++++++++++++++++++++++++++++++++++++ src/log/agent/lga_stream.cc | 46 +-------------- src/log/agent/lga_stream.h | 40 ++++++------- 10 files changed, 300 insertions(+), 185 deletions(-) Testing Commands: ----------------- Run logtest Testing, Expected Results: -------------------------- All PASS Conditions of Submission: ------------------------- Ack from peer reviewers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel