Summary: pyosaf: Support python3 [#3210]
Review request for Ticket(s): 3210
Peer Reviewer(s): Thuan, Thang, Minh
Pull request to: Thuan
Affected branch(es): develop
Development branch: ticket-3210
Base revision: db5e0c24ff713126d2912b6c3ec59cfbcfbda491
Personal repository: git://git.code.sf.net/u/thienhuynh/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services n
Core libraries n
Samples n
Tests n
Other y
NOTE: Patch(es) contain lines longer than 80 characers
Comments (indicate scope for each "y" above):
---------------------------------------------
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision f494aec20f64e5de258043389540296f6faaa790
Author: thien.m.huynh <thien.m.hu...@dektech.com.au>
Date: Thu, 13 Aug 2020 09:15:52 +0700
pyosaf: Support python3 [#3210]
Adapt pyosaf to support python3, and be compatible with python2
Complete diffstat:
------------------
python/pyosaf/saAis.py | 51 ++++++++++++++++++++++++++++++-----
python/pyosaf/saAmf.py | 8 ++++--
python/pyosaf/saImm.py | 4 ++-
python/pyosaf/saLog.py | 4 ++-
python/pyosaf/utils/immoi/agent.py | 2 +-
python/pyosaf/utils/immom/accessor.py | 10 +++----
python/pyosaf/utils/immom/agent.py | 11 +++++---
python/pyosaf/utils/immom/ccb.py | 19 ++++++-------
python/pyosaf/utils/immom/iterator.py | 9 ++++---
python/pyosaf/utils/immom/object.py | 2 +-
python/pyosaf/utils/ntf/producer.py | 24 +++++++++--------
src/imm/tools/immxml-merge | 32 ++++++++++++++++------
12 files changed, 123 insertions(+), 53 deletions(-)
Testing Commands:
-----------------
N/A
Testing, Expected Results:
--------------------------
N/A
Conditions of Submission:
-------------------------
ACK from reviewers
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
