Summary: rded: fence only one SC if split brain is detected [#2935]
Review request for Ticket(s): 2935
Peer Reviewer(s): Hans, Minh
Pull request to:
Affected branch(es): develop
Development branch: ticket-2935
Base revision: 3b80698770d599bc15b97119cbfd4098943d7643
Personal repository: git://git.code.sf.net/u/userid-2226215/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services y
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
revision 3c530e1f8cd1ed64826ac0fe4d461809af9c5d7b
Author: Gary Lee <gary....@dektech.com.au>
Date: Tue, 23 Oct 2018 06:35:21 +0000
rded: fence only one SC if split brain is detected [#2935]
Keep the SC with the earlier boot time alive, if split brain is
detected. In the unlikely event that the boot up time
is equal, the node with the lower ID survives.
Complete diffstat:
------------------
src/rde/rded/rde_cb.h | 2 ++
src/rde/rded/rde_main.cc | 21 ++++++++++++++++++++-
src/rde/rded/rde_mds.cc | 22 +++++++++++++++-------
3 files changed, 37 insertions(+), 8 deletions(-)
Testing Commands:
-----------------
1. Split SC-1 and SC-2 into separate network partitions
2. Merge partitions
Testing, Expected Results:
--------------------------
Only one SC reboots
2018-10-23 14:29:00.974 SC-1 osafrded[178]: EM Split-brain detected. My node ID
0x2010f (Tue Sep 18 23:58:09 2018#012), peer node ID 0x2020f (Tue Sep 18
23:58:09 2018#012)
2018-10-23 14:29:00.974 SC-1 osafrded[178]: EM Peer node will self fence
instead of us
2018-10-23 14:29:00.973 SC-2 osafrded[182]: EM Split-brain detected. My node ID
0x2020f (Tue Sep 18 23:58:09 2018#012), peer node ID 0x2010f (Tue Sep 18
23:58:09 2018#012)
2018-10-23 14:29:00.974 SC-2 osafrded[182]: Rebooting OpenSAF NodeId = 0 EE
Name = No EE Mapped, Reason: Split-brain detected, OwnNodeId = 131599,
SupervisionTime = 60
Conditions of Submission:
-------------------------
Ack from any reviewer, or in 5 days
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
