Summary: smf: Validation error for rollback CCB and a related core dump [#2858]
Review request for Ticket(s): 2858
Peer Reviewer(s): nguyen.tk@dektech.com.au
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-2858
Base
Hi Nguyen,
Yes, I will use this information and check this. Maybe some sort of internal
length check is needed in order to prevent this kind of assert.
Thanks
Lennart
From: Nguyen Luu
Sent: den 1 juni 2018 09:55
To: Lennart Lund
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH
Hi Nguyen,
I will send out a new review request as you suggest. I will probably not be
able to do this today
I also would like to understand why you get a coredump. I cannot reproduce that
problem in my environment also it does not happen in Osaftest or CoreMW test.
The imm_modify_config has
Hi Lennart,
I've run *test_ccbhdl* in OpenSAF UML cluster and the same core dump was
still generated as described in my previous mail.
My UML cluster was built and installed with the latest OpenSAF develop
commit (*5d8d104 rded: run controller promotion code in new thread
[#2857]*), and with
Hi Lennart,
Thanks for your answers to my comments. I agree with most of the major
points.
So Ack from me for the diff file. I can do a double-check review if you
will send out a new patch (with comments removed).
Thanks,
Nguyen
On 5/31/2018 10:48 PM, Lennart Lund wrote:
Hi Nguyen,
Hi Nguyen,
Attached is a diff with your comments still in there and my answers tagged
[Lennart].
I have also kept your uncommented fixes.
If you ack this I will use the patch with review comments removed.
Thanks
Lennart
From: Nguyen Luu
Sent: den 31 maj 2018 11:10
To: Lennart Lund
Cc:
Hi Nguyen,
I have tried to reproduce the coredump but I have not succeeded. Did you just
run test_ccbhdl without any special settings?
I am testing in an OpenSAF UML cluster that is built and started using the
tools in …/tools/cluster_sim_uml/
I have also tested when the test class is not in
Hi Lennart,
I've reviewed and tested your patch.
- For the code review, please check comments in the attached diff file.
- For the testing, a core dump occurred when executing *test_ccbhdl*
(always reproducible). Test printouts, core dump backtrace, and syslog
as shown below. Looks like some
Summary: smf: Validation error for rollback CCB and a related core dump [#2858]
Review request for Ticket(s): 2858
Peer Reviewer(s): nguyen.tk@dektech.com.au
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-2858
Base
