Summary: amf: improve error checking display [#2628] Review request for Ticket(s): 2628 Peer Reviewer(s): AMF devs Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2628 Base revision: 3d33c10e172b69a989304cc57199e2c714ae4059 Personal repository: git://git.code.sf.net/u/userid-2226215/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests n Other y Comments (indicate scope for each "y" above): --------------------------------------------- revision 51bddf9bfb788f3c86f7ef05addbb954b7e311d2 Author: Gary Lee <gary....@dektech.com.au> Date: Tue, 17 Oct 2017 18:04:49 +1100 amf: improve error checking and display [#2628] * nodes are prefixed with '0x', eg '0x2010f' instead of '2010f' to match input * options 's', 'c', 'u' are incompatible and are rejected when used together revision daa348d45d3b308ada1c2bfda22e7f6c46c2d9be Author: Gary Lee <gary....@dektech.com.au> Date: Tue, 17 Oct 2017 18:04:21 +1100 amf: fix whitespace issues [#2628] whitespace changes only Complete diffstat: ------------------ src/amf/tools/amf_cluster_status.cc | 58 +++++++++++++++++++++++-------------- 1 file changed, 36 insertions(+), 22 deletions(-) Testing Commands: ----------------- root@SC-1:~# amfclusterstatus -c 0x2010f 0x2010f is a Controller node root@SC-1:~# amfclusterstatus -c blah Invalid node root@SC-1:~# amfclusterstatus -s At least one controller is up root@SC-1:~# amfclusterstatus -s -c Too many options specified root@SC-1:~# amfclusterstatus -c -u Too many options specified root@SC-1:~# amfclusterstatus -s -u Too many options specified Testing, Expected Results: -------------------------- See above Conditions of Submission: ------------------------- ack from any reviewer, or in 1 week Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel