Hi Gary,
in general const member functions and using logical constness is to prefer, I
think. (If needed mutable can be used).
/Regards HansN
-Original Message-
From: Gary Lee [mailto:gary@dektech.com.au]
Sent: den 13 april 2018 09:45
To: Hans Nordebäck
Hi Hans
Yes, they could be declared const member functions, as they generally
don't change anything in the object. The changes are actually in the KV
store.
But I guess we could potentially mislead callers about the intentions of
the functions though.
What do you think?
/Gary
On
Hi,
On 04/12/2018 04:15 PM, Gary Lee wrote:
Hi
On 12/04/18 23:34, Anders Widell wrote:
Ack with comments:
* There is no need to use "const" when passing function arguments by
value. E.g. the argument "const uint64_t cluster_size" should be
"uint64_t cluster_size".
[GL] Sure, but it
Hi
On 12/04/18 23:34, Anders Widell wrote:
Ack with comments:
* There is no need to use "const" when passing function arguments by
value. E.g. the argument "const uint64_t cluster_size" should be
"uint64_t cluster_size".
[GL] Sure, but it doesn't do any harm, and would stop accidental
Ack with comments:
* There is no need to use "const" when passing function arguments by
value. E.g. the argument "const uint64_t cluster_size" should be
"uint64_t cluster_size".
* You assume that all nodes in the cluster have synchronized clocks
(probably using NTP). Would it be possible to
Summary: split-brain: select active SC from largest network partition V3
[#2795]
Review request for Ticket(s): 2795
Peer Reviewer(s): Anders, Ravi, Hans
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-2795
Base revision:
