[devel] [PATCH 0 of 1] Review Request for IMM: free the client node intialization if IMMA fails(#602)

2013-10-24 Thread reddy . neelakanta
Summary: IMM: free the client node intialization if IMMA fails(#602) Review request for Trac Ticket(s):602 Peer Reviewer(s): AndersBj, Zoran Affected branch(es):4.2.x,4.3.x,default Development branch:default Impacted area Impact y/n

Re: [devel] [PATCH 0 of 1] Review Request for IMM: free the client node intialization if IMMA fails(#602)

2013-10-24 Thread Anders Bjornerstedt
Ack from me. Not tested. /AndersBj reddy.neelaka...@oracle.com wrote: Summary: IMM: free the client node intialization if IMMA fails(#602) Review request for Trac Ticket(s):602 Peer Reviewer(s): AndersBj, Zoran Affected branch(es):4.2.x,4.3.x,default Development branch:default

Re: [devel] [PATCH 0 of 1] Review Request for IMM: free the client node intialization if IMMA fails(#602)

2013-10-24 Thread Zoran Milinkovic
Ack from me with a minor change. Checking, if cl_node is NULL, is not necessary. Best regards, Zoran -Original Message- From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com] Sent: den 24 oktober 2013 10:43 To: Anders Björnerstedt Cc: opensaf-devel@lists.sourceforge.net

Re: [devel] [PATCH 0 of 1] Review Request for IMM: free the client node intialization of IMMA fails(#602)

2013-10-23 Thread Anders Björnerstedt
Hi Neel, First, obviously we did not review your fix for #560 properly. I also now see that the changesets for the fix for #560 are actually tagged with #563. Ticket #560 says that the problem is related to #563, but I dont see how. Or perhaps you just mean that you discovered problem #560 while