Ack from me.
Tested.
Did not re-review the code.
/AndersBj
reddy.neelaka...@oracle.com wrote:
Summary:Imm:Make immcfg aware of safImmService admin owner for
opensafImm=opensafImm,safApp=safImmService [#840]
Review request for Trac Ticket(s): 840
Peer Reviewer(s): AndersBj, Zoran
Affected
Summary:Imm:Make immcfg aware of safImmService admin owner for
opensafImm=opensafImm,safApp=safImmService [#840]
Review request for Trac Ticket(s): 840
Peer Reviewer(s): AndersBj, Zoran
Affected branch(es):4.4.x, default
Development branch: default
Docs
Hi Neelakanta,
I have few comments to the patch:
1. Why did you disable enabling and disabling notifications in explicit commit
mode ?
2. strcpy() in line 788 is not safe. adminOwnerName may have less allocated
bytes than safImmService. For example: if an application change immcfg name
into
Hi zoran,
comments inline.
/Neel.
- Original Message -
From: zoran.milinko...@ericsson.com
To: reddy.neelaka...@oracle.com, anders.bjornerst...@ericsson.com
Cc: opensaf-devel@lists.sourceforge.net
Sent: Friday, April 25, 2014 3:08:07 PM GMT +05:30 Chennai, Kolkata, Mumbai,
New Delhi
Hi zoran,
Ok, will publish a new patch, which is backward compatible.
/Neel.
- Original Message -
From: zoran.milinko...@ericsson.com
To: reddy.neelaka...@oracle.com
Cc: anders.bjornerst...@ericsson.com, opensaf-devel@lists.sourceforge.net
Sent: Friday, April 25, 2014 6:16:33 PM GMT
Ack from Me.
Tested the positive cases for enabling and disabling imcn notifications.
/AndersBj
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 18 april 2014 15:25
To: Anders Björnerstedt
Cc: opensaf-devel@lists.sourceforge.net
Summary:IMM :Make immcfg aware of safImmService admin owner for
opensafImm=opensafImm,safApp=safImmService [#840]
Review request for Trac Ticket(s): 840
Peer Reviewer(s): AndersBj, Zoran
Affected branch(es): 4.4.x, default
Development branch: default
Impacted
