Summary: amfd: convert avnd_ng_tag to a class [#1142]
Review request for Trac Ticket(s): 1142
Peer Reviewer(s): Hans N, Praveen, Nagendra
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): default
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 4fd6dd3b2b10307649f6e1eaa64e71af727c2d54
Author: Gary Lee <gary....@dektech.com.au>
Date: Mon, 09 Feb 2015 17:12:17 +1100
amfd: convert avnd_ng_tag to a class [#1142]
* change saAmfNGNodeList to a std::set
* use std::includes to check for subsets to simplify code
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/include/node.h | 19 ++++++++++++-------
osaf/services/saf/amf/amfd/node.cc | 5 +++++
osaf/services/saf/amf/amfd/nodegroup.cc | 73
+++++++++++++++++++++++++++----------------------------------------------
osaf/services/saf/amf/amfd/sg.cc | 14 ++++++--------
osaf/services/saf/amf/amfd/su.cc | 42
++++++++++++++----------------------------
5 files changed, 64 insertions(+), 89 deletions(-)
Testing Commands:
-----------------
1) create a node group 'controllers' that consists of SC-1 only. Attempt to
replace the nodegroup in 'safSg=2N,safApp=OpenSAF'
to this new group.
immcfg -c SaAmfNodeGroup -a
saAmfNGNodeList=safAmfNode=SC-1,safAmfCluster=myAmfCluster
safAmfNodeGroup=controllers,safAmfCluster=myAmfCluster
immcfg -a
saAmfSGSuHostNodeGroup=safAmfNodeGroup=payloads,safAmfCluster=myAmfCluster
safSg=2N,safApp=OpenSAF
2) add SC-2 to the nodegroup
immcfg -a saAmfNGNodeList+=safAmfNode=SC-2,safAmfCluster=myAmfCluster
safAmfNodeGroup=controllers,safAmfCluster=myAmfCluster
immcfg -a
saAmfSGSuHostNodeGroup=safAmfNodeGroup=payloads,safAmfCluster=myAmfCluster
safSg=2N,safApp=OpenSAF
Testing, Expected Results:
--------------------------
1) should fail with
OI reports: 'safAmfNodeGroup=SCs,safAmfCluster=myAmfCluster' is not a subset of
'safAmfNodeGroup=controllers,safAmfCluster=myAmfCluster'
2) should succeed
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
