Please see my comments inline.
Regards, Vu.
>-Original Message-
>From: Mathivanan Naickan Palanivelu [mailto:mathi.naic...@oracle.com]
>Sent: Tuesday, March 15, 2016 1:29 PM
>To: Vu Minh Nguyen; Anders Widell; Lennart Lund
>Cc: opensaf-devel@lists.sourceforge.net; Beatriz Brandao; Jorge
Please see a comment inline:
> -Original Message-
> From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
> Sent: Tuesday, March 15, 2016 11:53 AM
> To: Mathivanan Naickan Palanivelu; Anders Widell; Lennart Lund
> Cc: opensaf-devel@lists.sourceforge.net; Beatriz Brandao; Jorge Pacheco
Hi Mathi,
See my responses inline, with [Vu].
Regards, Vu.
>-Original Message-
>From: Mathivanan Naickan Palanivelu [mailto:mathi.naic...@oracle.com]
>Sent: Tuesday, March 15, 2016 1:07 PM
>To: Anders Widell; Vu Minh Nguyen; Lennart Lund
>Cc: opensaf-devel@lists.sourceforge.net; Beatriz
Hi,
Comments inline:
> -Original Message-
> From: Anders Widell [mailto:anders.wid...@ericsson.com]
> Sent: Monday, March 14, 2016 4:52 PM
> To: Vu Minh Nguyen; Lennart Lund; Mathivanan Naickan Palanivelu
> Cc: opensaf-devel@lists.sourceforge.net; Beatriz Brandao; Jorge Pacheco
> Garcia
Hi Vu
Ack
Can push when the location of the .xml files is solved and is included in a
patch to push and all other reviewers has acked.
Thanks
Lennart
> -Original Message-
> From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
> Sent: den 14 mars 2016 11:03
> To: Lennart Lund;
See my comments inline.
regards,
Anders Widell
On 03/08/2016 03:49 AM, Vu Minh Nguyen wrote:
> Hi Lennart,
>
> Please see my responses inline, with [Vu].
>
> Regards, Vu.
>
>> -Original Message-
>> From: Lennart Lund [mailto:lennart.l...@ericsson.com]
>> Sent: Thursday, March 03, 2016
Hi Vu
Ack with comment:
I think you should fix the get_attr_value() function before pushing.
What is the decision for placement of gcfg_classes.xml and gcfg_objects.xml?
Must of course also be fixed
Thanks
Lennart
> -Original Message-
> From: Vu Minh Nguyen
Hi Mathi,
Have you had time to look at this yet?
Regards, Vu.
>-Original Message-
>From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
>Sent: Friday, February 26, 2016 8:49 AM
>To: anders.wid...@ericsson.com; lennart.l...@ericsson.com;
>mathi.naic...@oracle.com
>Cc:
Hi Lennart,
Please see my responses inline, with [Vu].
Regards, Vu.
>-Original Message-
>From: Lennart Lund [mailto:lennart.l...@ericsson.com]
>Sent: Thursday, March 03, 2016 10:38 PM
>To: Vu Minh Nguyen; Anders Widell; mathi.naic...@oracle.com
>Cc: opensaf-devel@lists.sourceforge.net;
Hi Vu
My comments:
---
logtest.c
get_attr_value()
This function looks like it can get a value from any attribute in any object
but this does not seems to be the case.
It can only get values from some specific objects and also not for all
attributes in those
Summary: log: Extend information about origin of log record [#1480]
Review request for Trac Ticket(s): #1468
Peer Reviewer(s): Lennart, Anders W, Mathi
Pull request to: Lennart
Affected branch(es): Default
Development branch: Default
Impacted area Impact y/n
11 matches
Mail list logo
