I would like to set the ticket to `accepted` state. Will back to this
discussion later.
Regards, Vu.
>-Original Message-
>From: Lennart Lund [mailto:lennart.l...@ericsson.com]
>Sent: Thursday, May 26, 2016 8:12 PM
>To: Vu Minh Nguyen; Canh Truong V; mathi.naic...@oracle.com; 'A V Mahesh'
Hi Vu
I'm afraid I cannot ack this fix since it will introduce a the possibility to
(constantly and silently) lose log records.
See my comments inline [Lennart]
Thanks
Lennart
> -Original Message-
> From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
> Sent: den 26 maj 2016 13:17
>
Hi Lennart,
If we check the saLogStreamMaxLogFileSize after writing the record, the log
file size in disk may be bigger than expected. This may not be wanted
behavior. The patch changes to check saLogStreamMaxLogFileSize before.
LOG SPEC: "maxLogFileSize - The maximum size in bytes to which a l
Hi Lennart,
In logsv, we seems have mechanism to make sure that and log record size must
not bigger than log file size.
So, your concern about dropping log record when not fix the log file size.
And giving we allow the case log file size can be larger than the
max_log_file_size,
I am afraid it co
Hi Canh
Are you sure this is a wanted behavior? I have always thought that it was
intentional to write a last log record to the file even if the
saLogStreamMaxLogFileSize size was passed. I think this is to guarantee that at
least one log record can be written to the file so that is not possibl
Summary: log: fix log file size is bigger than saLogStreamMaxLogFileSize [#1438]
Review request for Trac Ticket(s): #1438
Peer Reviewer(s): Lennart, Mathi, Vu
Pull request to: Vu
Affected branch(es): opensaf-4.7.x, opensaf-5.0.x, default(5.1)
Development branch: default
---
