Summary: ntftest: Fix ntftest suite 22 test 3 fails [#1379]
Review request for Trac Ticket(s): #1379
Peer Reviewer(s): praveen.malv...@oracle.com, lennart.l...@ericsson.com
Pull request to: lennart.l...@ericsson.com
Affected branch(es): 4.5, 4.6, default
Development branch: <<IF ANY GIVE THE REPO URL>>
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services n
Core libraries n
Samples n
Tests y
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 415e9e29422dbaba2a14e68042712f770a68ed55
Author: Vu Minh Nguyen <vu.m.nguy...@dektech.com.au>
Date: Mon, 01 Jun 2015 13:27:16 +0700
ntftest: Fix ntftest suite 22 test 3 fails [#1379]
Test suite 22 test 3 invokes the test script
tests/ntfsv/ntf_search_criteria_test.sh. This script then passed an
invalid
non-option `return` to ntfread tool.
This fix removed that non-option and also unused variable id.
Complete diffstat:
------------------
tests/ntfsv/ntf_search_criteria_test.sh | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
Testing Commands:
-----------------
Run the test suite below:
# ntftest 22 3
Testing, Expected Results:
--------------------------
# ntftest 22 3
Suite 22: Consumer operations - Reader API 3
3 PASSED saNtfSearchCriteriaT test all
=====================================================================================
Test Result:
Total: 1
Passed: 1
Failed: 0
Conditions of Submission:
-------------------------
Ack from peer reviewers
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
