Summary:osaf: configuration support for OS whic has TIPC builtin kernel module
[#1951] V1
Review request for Trac Ticket(s): #1951
Peer Reviewer(s): Anders Widell /Srikanth
Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>>
Affected branch(es): default
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files y
Startup scripts n
SAF services n
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
changeset 3f8bdc62a043aa39e931f27f2b4b06a99b72c30f
Author: A V Mahesh <mahesh.va...@oracle.com>
Date: Tue, 06 Sep 2016 15:20:10 +0530
osaf: configuration support for OS whic has TIPC builtin kernel module
[#1951] V1
V1 patch : Fixed make shellcheck reported warnings on the modified code
Issue: In some OS like Montavista, TIPC is built in kernel
module, the default node address will be <0.0.0>.
Fix : This patch determines such OS which has TIPC is built in kernel
module
and configures the TIPC node address to OpenSAF requirements.
Notes :
1) In OS like Montavista where TIPC is built in kernel module, once
TIPC has
joined a network with a network id & address it cannot change node
address
once assigned, until node reboots, in other words opensafd stop will not
Reset tipc link/link Lost. the only way to get Reset tipc link/link
Lost is
rebooting node.
2 ) As If once TIPC has joined a network with a network-id & address it
is
not possible to change node address until node reboots, so duplicate
node
verification is not possible and enable disable duplicate node
verification (TIPC_DUPLICATE_NODE_DETECT=YES/NO) has NO effect.
Complete diffstat:
------------------
00-README.conf | 11 +++++++++--
osaf/services/infrastructure/nid/scripts/configure_tipc.in | 51
++++++++++++++++++++++++++++++---------------------
2 files changed, 39 insertions(+), 23 deletions(-)
Testing Commands:
-----------------
start opensaf on OS like Montavista, where TIPC is built in kernel module
Testing, Expected Results:
--------------------------
<<PASTE COMMAND OUTPUTS / TEST RESULTS>>
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
