HI Lennart,
Yes you are right, the published patch will work for Bot TIPC & TCP
you can integrated and test BOTH .
I will move the `FILE *fp;` out of `#ifdef ENABLE_TIPC_TRANSPORT` ,
so that if some one wont build only TCP should also be able to compile .
-AVM
On 2/12/2016 2:07 PM, Lennart
Hi Mahesh
Sorry, I didn't realize that this prototype did not yet support TCP but I have
tested with --enable-tipc and that worked fine. You mentioned earlier that it
could be a problem to make this work with tipc so it's nice to see that you
have been able to handle that. This solution will
Hi Mahesh
It is correct that I didn't apply patch 2 of 3. The reason is that the patch
didn't show up in my outlook mailbox. So I assumed that you for some reason
didn't sent that patch or maybe would send it later. But I have looked in the
devel list on sourceforge and there it is!
I will try
Hi Mahesh
With patch 2 of 3 it builds fine when configured for tipc but not when
configured for TCP.
Got the following error:
make[6]: Entering directory
`/home/elunlen/workspace/opensaf-staging-dev1/osaf/libs/core/mds'
CC libmds_la-mds_dt_tcp.lo
CC libmds_la-mds_dt_trans.lo
Hi Lennart,
It looks like you are configured Opensaf without `--enable-tipc` option
and currently `FILE *fp;` is `#ifdef ENABLE_TIPC_TRANSPORT` under compile
time flag, that is why you are seeing the problem , for now configure
Opensaf
with `--enable-tipc` option and proceed for your testing .
Hi Lennar,
On 2/10/2016 5:10 PM, Lennart Lund wrote:
> mds_dt_trans.c: In function 'mds_mdtm_process_recvdata':
> mds_dt_trans.c:928:5: error: too few arguments to function 'mds_mcm_node_up'
> mds_mcm_node_up(svc_hdl, node_id, node_ip, addr_family);
It seems you didn't applied the `[devel]
Hi Lennart ,
On 2/5/2016 5:30 PM, Lennart Lund wrote:
A patch (2 of 3) seems to be missing and it's not possible to build.
I Just copyed the ` PATCH_1_of_3.patch , PATCH_2_of_3.patch &
PATCH_3_of_3.patch` form the published mail ( please find attached
for your reference)
and able to
Hi Mahesh
I have looked at the test logs in the log code and I have not seen any
surprises. Since this will work with both TIPC and TCP it will be form the log
perspective a good solution.
However I have not been able to build and test, a patch (2 of 3) seems to be
missing and it's not
Summary:MDS: Include node name as a part of Transport callback_info events
[#1522]
Review request for Trac Ticket(s): #1522
Peer Reviewer(s): Lennart /Beatriz /Mathi /Ramesh
Pull request to: avm
Affected branch(es): default
Development branch: default
Impacted
