Summary: amfd: SI refactoring part 4 [#713]
Review request for Trac Ticket(s): 713
Peer Reviewer(s): AMF maintainers
Pull request to:
Affected branch(es): default
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
This patch set is part 4 of SI refactoring.
changeset 2c574664d8c2c58b36c962d3f212309ad204b01d
Author: Gary Lee <gary....@dektech.com.au>
Date: Fri, 13 Jun 2014 15:39:39 +1000
amfd: move svctype and svctypecstype declarations to separate files
[#713]
Move declarations relating to svctype and svctypecstype from si.h to
their
own header files.
changeset 0a834104979fe8e52d80655149df14e1cc3d1b33
Author: Gary Lee <gary....@dektech.com.au>
Date: Fri, 13 Jun 2014 15:39:40 +1000
amfd: Move sirankedsu declarations to its own header file [#713]
changeset fa7b95074d79ef3f1f8222a415a2fc26f2d36ad3
Author: Gary Lee <gary....@dektech.com.au>
Date: Fri, 13 Jun 2014 15:39:40 +1000
amfd: convert remaining macros in si.cc to functions [#713]
Added Files:
------------
osaf/services/saf/amf/amfd/include/sirankedsu.h
osaf/services/saf/amf/amfd/include/svctypecstype.h
osaf/services/saf/amf/amfd/include/svctype.h
Complete diffstat:
------------------
osaf/services/saf/amf/amfd/include/si.h | 51
++++++++-------------------------------------------
osaf/services/saf/amf/amfd/include/sirankedsu.h | 25
+++++++++++++++++++++++++
osaf/services/saf/amf/amfd/include/svctype.h | 38
++++++++++++++++++++++++++++++++++++++
osaf/services/saf/amf/amfd/include/svctypecstype.h | 35
+++++++++++++++++++++++++++++++++++
osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 10 +++++-----
osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc | 10 +++++-----
osaf/services/saf/amf/amfd/si.cc | 20 ++++++++++++++++++++
7 files changed, 136 insertions(+), 53 deletions(-)
Testing Commands:
-----------------
<<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>>
Testing, Expected Results:
--------------------------
<<PASTE COMMAND OUTPUTS / TEST RESULTS>>
Conditions of Submission:
-------------------------
<<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>>
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
