Re: [devel] [PATCH 1/1] amf: Validate env variable format set in comptype/comp objects [#2409]

Ack, review only. Will push on Nguyen's behalf. On Fri, 16 Feb 2018 at 7:29 pm, Ravi Sekhar Reddy Konda < ravisekhar.ko...@oracle.com> wrote: > Hi Nguyen, > > Ack, code review only > > Regards, > Ravi > > -Original Message- > From: Nguyen Luu [mailto:nguyen.tk@dektech.com.au] >

[devel] [PATCH 1/1] amf: Validate env variable format set in comptype/comp objects [#2409]

Valid environment variable should have the format 'var=value'. This validation shall now be done by AMF during CCB operations on SaAmfCompType (CREATE) and SaAmfComp (CREATE/MODIFY) objects regarding the saAmfxxxCmdEnv attribute. --- src/amf/amfd/comp.cc | 59

Re: [devel] [PATCH 1/1] amf: validate env variable format set in comptype/comp objects [#2409]

Hi Gary, Thank you for your comments. Please see my corresponding answers below, marked with [Nguyen]. Thanks, Nguyen On 2/7/2018 11:30 AM, Gary Lee wrote: Hi Nguyen Some comments below marked with [GL]. Thanks Gary On 6/2/18, 6:35 pm, "Nguyen Luu" wrote:

Re: [devel] [PATCH 1/1] amf: validate env variable format set in comptype/comp objects [#2409]

Hi Nguyen Some comments below marked with [GL]. Thanks Gary On 6/2/18, 6:35 pm, "Nguyen Luu" wrote: Valid environment variable should have the format 'var=value'. AMF currently does not validate this format during CREATE CCBs for comptype and

[devel] [PATCH 1/1] amf: validate env variable format set in comptype/comp objects [#2409]

Valid environment variable should have the format 'var=value'. AMF currently does not validate this format during CREATE CCBs for comptype and comp objects (MODIFY allowed for comp after #2255) related to saAmfxxxCmdEnv attribute. Besides, the existing validation in avnd_comp_clc_cmd_execute() is

[devel] [PATCH 1/1] amf: validate env variable format set in comptype/comp objects [#2409]

Valid environment variable should have the format 'var=value'. AMF currently does not validate this format during CREATE CCBs for comptype and comp objects (MODIFY allowed for comp after #2255) related to saAmfxxxCmdEnv attribute. Besides, the existing validation in avnd_comp_clc_cmd_execute() is

[devel] [PATCH 1/1] amf: validate env variable format set in comptype/comp objects [#2409]

Valid environment variable should have the format 'var=value'. AMF currently does not validate this format during CREATE CCBs for comptype and comp objects (MODIFY allowed for comp after #2255) related to saAmfxxxCmdEnv attribute. Besides, the existing validation in avnd_comp_clc_cmd_execute() is

Re: [devel] [PATCH 1/1] amf: validate env variable format set in comptype/comp objects [#2409]

Hi Nguyen Some comments below. Thanks On 13/4/17, 10:48 pm, "Nguyen Luu" wrote: Valid environment variable should have the format 'var=value'. AMF currently does not validate this format during CREATE CCBs for comptype and comp objects (MODIFY

[devel] [PATCH 1/1] amf: validate env variable format set in comptype/comp objects [#2409]

Valid environment variable should have the format 'var=value'. AMF currently does not validate this format during CREATE CCBs for comptype and comp objects (MODIFY allowed for comp after #2255) related to saAmfxxxCmdEnv attribute. Besides, the existing validation in avnd_comp_clc_cmd_execute() is