Re: [devel] [PATCH 1/1] amfd: Fix misordered and dropped item in job queue [#2981]

2018-12-11 Thread Gary Lee
Hi Minh ack with minor comments: - it seems like we have the wrong data structure here, maybe fix in an enhancement. - try to simplify the else statement, eg a single place that calls dequeue/queue? On 10/12/18 4:44 pm, Minh Chau wrote: --- src/amf/amfd/imm.cc | 54 ++--

[devel] [PATCH 1/1] amfd: Fix misordered and dropped item in job queue [#2981]

2018-12-09 Thread Minh Chau
--- src/amf/amfd/imm.cc | 54 ++-- src/amf/amfd/imm.h | 2 -- src/amf/amfd/role.cc | 2 +- 3 files changed, 19 insertions(+), 39 deletions(-) diff --git a/src/amf/amfd/imm.cc b/src/amf/amfd/imm.cc index 82d2b13..d917b0d 100644 --- a/src/amf/amf