Re: [devel] [PATCH 1/1] amfnd: unlock before releasing the monitoring thread to avoid deadlock [#2818]

2018-04-05 Thread Hans Nordebäck
Hi Ravi, ack, review only. (I agree, NCS_TASK_RELEASE should not be called with the mutex taken as pthread_mutex_lock is not a cancellation point). /Regards HansN On 03/29/2018 07:59 AM, ravi-sekhar wrote: --- src/amf/amfnd/mon.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [devel] [PATCH 1/1] amfnd: unlock before releasing the monitoring thread to avoid deadlock [#2818]

2018-04-04 Thread Minh Hon Chau
Hi Ravi, Ack from me (legacy test run) with one comment. Since we move m_NCS_UNLOCK before releasing the mon thread, so it is ok to me if inside avnd_mon_pids(), after taking the LOCK(), we don't hit any cancellation point before UNLOCK(). Otherwise, the thread is canceled while the LOCK is

Re: [devel] [PATCH 1/1] amfnd: unlock before releasing the monitoring thread to avoid deadlock [#2818]

2018-04-04 Thread Minh Hon Chau
Hi Ravi, I start reviewing today Thanks Minh On 04/04/18 17:19, Ravi Sekhar Reddy Konda wrote: Hi Minh, Did you get time to look at this patch, please consider reviewing it with priority Thanks, Ravi -Original Message- From: ravi-sekhar [mailto:ravisekhar.ko...@oracle.com] Sent:

Re: [devel] [PATCH 1/1] amfnd: unlock before releasing the monitoring thread to avoid deadlock [#2818]

2018-04-04 Thread Ravi Sekhar Reddy Konda
Hi Minh, Did you get time to look at this patch, please consider reviewing it with priority Thanks, Ravi -Original Message- From: ravi-sekhar [mailto:ravisekhar.ko...@oracle.com] Sent: Thursday, March 29, 2018 11:30 AM To: hans.nordeb...@ericsson.com; minh.c...@dektech.com.au;

[devel] [PATCH 1/1] amfnd: unlock before releasing the monitoring thread to avoid deadlock [#2818]

2018-03-29 Thread ravi-sekhar
--- src/amf/amfnd/mon.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amf/amfnd/mon.cc b/src/amf/amfnd/mon.cc index 9cdfc37..4932d50 100644 --- a/src/amf/amfnd/mon.cc +++ b/src/amf/amfnd/mon.cc @@ -161,6 +161,8 @@ uint32_t avnd_mon_req_del(AVND_CB *cb, SaUint64T