Re: [devel] [PATCH 1/1] dtm: configure trace file size and no of backups in transportd.conf [#2731]

2017-12-28 Thread Anders Widell
Hi! Here are my initial review comments: * Avoid using preprocessor macros: TRANSPORTD_CONFIG_FILE should be a string constant. Also, according to naming conventions (Google C++ style guide) it should be named kTransportdConfigFile. * LogServer::no_of_backups and LogServer:kmax_file_size

[devel] [PATCH 1/1] dtm: configure trace file size and no of backups in transportd.conf [#2731]

2017-12-27 Thread syam-talluri
--- opensaf.spec.in| 2 + src/dtm/Makefile.am| 3 + src/dtm/transport/log_server.cc| 95 -- src/dtm/transport/log_server.h | 10 +++- src/dtm/transport/log_writer.cc| 6 +-