Hi Vu,
ack, review only. (The indentation is still not correct). /Thanks HansN
On 06/20/2018 08:28 AM, Vu Minh Nguyen wrote:
The coordinator IMMND on PL-3 was crashed, the active IMMD then elected the new
coordinator on the standby node, SC-2, but failed because IMMND on the SC-2 was
The coordinator IMMND on PL-3 was crashed, the active IMMD then elected the new
coordinator on the standby node, SC-2, but failed because IMMND on the SC-2 was
restarted also. As the result, the active IMMD exited and failure-over
happened. After that, SC-2 took active role and found no candidate
Hi Hans,
Thanks for your comments. See my responses inline.
- the indentation is not correct after the first while stmt.
[Vu] Yes, you are right. I will correct it in V2 patch.
- why adding a new similar while loop? Instead remove the newly added while loop
and change the first while loop
Hi Vu, the formatting of the code was not so good, a new attempt below:
} else {
/* Try to elect a new coord. */
IMMD_IMMND_INFO_NODE *candidate_coord_node = 0;
cb->payload_coord_dest = 0LL;
memset(, 0, sizeof(MDS_DEST));
immd_immnd_info_node_getnext(>immnd_tree, ,
Hi Vu,
a few comments,
- the indentation is not correct after the first while stmt.
- why adding a new similar while loop? Instead remove the newly added
while loop
and change the first while loop to something like this (not tested though):
} else{
/* Try to elect a new coord. */
Here is the case:
The coordinator IMMND on PL-3 was crashed, the active IMMD then elected the new
coordinator on the standby node SC-2 but failed because IMMND on the SC-2 was
also restarted. As the result, the active IMMD exited and failure-over
happened. After that, SC-2 took active role and
